[Bug 7959] New: Update OPAC suggestions interface to match lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7959 Priority: P5 - low Change sponsored?: --- Bug ID: 7959 Assignee: oleonard@myacpl.org Summary: Update OPAC suggestions interface to match lists QA Contact: koha.sekjal@gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: OPAC Product: Koha The OPAC's suggestions list is similar to that of lists in that there is an action you can take directly (new suggestion) and an action you can take if items are selected (delete suggestion). The "toolbar" should match the one on lists in that the delete option should only be available if an item is selected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7959 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9188&action=edit Bug 7959 - Update OPAC suggestions interface to match lists Marking up suggestions "toolbar" to match the interface in lists. Actions which require an item to be selected (deleting a suggestion) should not be available if nothing is selected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7959 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7959 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9188|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9369&action=edit [SIGNED-OFF] Bug 7953 - add opacuserjs to the sco template To test: add some jquery to opacuserjs that would change the screen a la: $(".checkout label[for='patronid']").css("border","3px solid red"); verify you see a red box on the sco-main page. Also adds the ability to use opacusercss to style sco-main.tt to test: Add some css to opacusercss that would change the screen: .checkout { background: grey; } verify you see a grey box around the checkout div. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7959 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9369|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7959 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9188|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7959 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Sorry, git bz typo. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7959 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9188|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 9454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9454&action=edit [SIGNED-OFF] Bug 7959 - Update OPAC suggestions interface to match lists Marking up suggestions "toolbar" to match the interface in lists. Actions which require an item to be selected (deleting a suggestion) should not be available if nothing is selected. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7959 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7959 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Owen, Is there a reason to use double quote instead of simple quote in your html replacement ? I think: $("span.checkall").html("<a id=\"CheckAll\" href=\"#\">"+_('Select all')+"<\/a>"); is not easier to read than: $("span.checkall").html('<a id="CheckAll" href="#">'+_('Select all')+'</a>'); -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7959 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #5)
Is there a reason to use double quote instead of simple quote in your html replacement ?
I agree about the readability, but I also like the consistency of always using a double quote when I start typing something like .html() knowing that I can escape any quotes I'll need later. I'd be happy to agree to either pattern and set a coding guideline for it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7959 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- The patch does not apply, CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-suggestions.tt I feel it's not hard to fix, but I don't want to do a mistake, so please rebase & resubmit -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7959 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9454|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9708&action=edit Bug 7959 - Update OPAC suggestions interface to match lists Rebased against current master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7959 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7959 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version|master |rel_3_10 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: template change only, passes tests for validity/translatability passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7959 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org