[Bug 9719] New: Changing the rows per page on a custom report fails if it has user supplied parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Bug ID: 9719 Summary: Changing the rows per page on a custom report fails if it has user supplied parameters Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com If you create an SQL report that includes one or more parameters, using the 'rows per page' pulldown does not work. Instead, it will prompt for the parameters again and shows the first page of output. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15724&action=edit Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters If you create an SQL report that includes one or more parameters, using the 'rows per page' pulldown does not work. Instead, it will prompt for the parameters again and shows the first page of output. Test Plan: 1) Create a new report from sql as follows: SELECT * FROM borrowers WHERE surname LIKE <<Last Name>> AND firstname LIKE <<First Name>> 2) Run this report 3) Change the 'Rows per page' and click 'Update' 4) This should kick you back to the start where the report asks you for your parameters 5) Apply the patch 6) Repeat step 3, this time is should work correctly -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15724|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17851&action=edit [SIGNED-OFF] Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters If you create an SQL report that includes one or more parameters, using the 'rows per page' pulldown does not work. Instead, it will prompt for the parameters again and shows the first page of output. Test Plan: 1) Create a new report from sql as follows: SELECT * FROM borrowers WHERE surname LIKE <<Last Name>> AND firstname LIKE <<First Name>> 2) Run this report 3) Change the 'Rows per page' and click 'Update' 4) This should kick you back to the start where the report asks you for your parameters 5) Apply the patch 6) Repeat step 3, this time is should work correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17851|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17865&action=edit [PASSED QA] Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters If you create an SQL report that includes one or more parameters, using the 'rows per page' pulldown does not work. Instead, it will prompt for the parameters again and shows the first page of output. Test Plan: 1) Create a new report from sql as follows: SELECT * FROM borrowers WHERE surname LIKE <<Last Name>> AND firstname LIKE <<First Name>> 2) Run this report 3) Change the 'Rows per page' and click 'Update' 4) This should kick you back to the start where the report asks you for your parameters 5) Apply the patch 6) Repeat step 3, this time is should work correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely now. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Does not apply to 3.10.x please rebase if needed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 9994 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9417 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 --- Comment #7 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #5)
Does not apply to 3.10.x please rebase if needed
This bug corrects an enhancement added by bug 9417 which has only been pushed on master. So no need to create a 3.10.x rebase. @Kyle : nice job, you're like a bug hunter. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org