[Bug 10266] New: Restricted status doesn't show in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Bug ID: 10266 Summary: Restricted status doesn't show in OPAC Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: rkk0@poczta.onet.pl Reporter: katrin.fischer@bsz-bw.de To Test: Give an item a special restricted value, define one if you have to in the authorised values. Observe that, without this patch, statuses are not shown in the OPAC in parentheses. My example was an item that had a restricted value of "Library Staff Only" It should have been shown under status on the detail page of the OPAC, but was not -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4173 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18181&action=edit Proposed patch Moved patch and bug description to a new bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18181|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18182&action=edit [PASSED QA] Bug 4173 - Statuses not appearing in the OPAC Simply revert order of 2 lines in Items.pm. Previous line write to variable used in next line as function argument. To Test: Give an item a special restricted value, define one if you have to in the authorised values. Observe that, without this patch, statuses are not shown in the OPAC in parentheses. My example was an item that had a restricted value of "Library Staff Only" It should have been shown under status on the detail page of the OPAC, but was not. Apply the patch, observe that restricted values are now shown for your item, for example: Available (Library Staff Only) in the status column. Signed-off-by: Liz Rea <liz@catalyst.net.nz> http://bugs.koha-community.org/show_bug.cgi?id=10266 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and test plan. Simple change fixing a display problem, no string changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off Patch complexity|Small patch |--- --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As we are very close to release I suggest to file a separate bug for using the new TT plugin for displaying all item status and use this patch to fix the existing bug in the upcoming release and the older releases. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. I agree with Katrin- I'd rather see this go into 3.12, as the patch is merely correcting the order of two lines already in Koha. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 --- Comment #5 from Rafal <rkk0@poczta.onet.pl> --- (In reply to comment #1)
Created attachment 18181 [details] [review] Proposed patch
Moved patch and bug description to a new bug.
Thanks Katrin for correcting this bugfix :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Rafal, thx to you for fixing an annoying bug and welcome :) http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=3898e70fe55b9e56... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org