http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23359|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 23752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23752&action=edit Bug 10907: Optionally show the staff member's name who managed a suggestion in OPAC The name of a staff member who managed a suggestion is shown in the the OPAC if the new system preference OpacSuggestionManagedBy is set to 'Show'. This is also the default. If the preference is set to 'Don't show' the staff members name is not displayed and the column 'Managed by' in the table of suggestions in the patron account is not displayed. To test: - Create a one or more suggestions - 'Manage' them by accecpting or rejecting - Go to your patron account and check that the staff member name is shown for your suggestions - Apply patch, run database update - Check the name is still shown - Switch the preference to 'Don't show' - Check the name is no longer shown and the table still displays correctly, but without the 'Managed by' column - Repeat those tests for both bootstrap and prog theme! Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Works as advertised, the only little nitpick is you could just do [% IF Koha.Preference( 'OpacSuggestionManagedBy' ) %] However you are following the custom in that file already, so that's fine -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23752|0 |1 is obsolete| | --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 24449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24449&action=edit Bug 10907: Optionally show the staff member's name who managed a suggestion in OPAC The name of a staff member who managed a suggestion is shown in the the OPAC if the new system preference OpacSuggestionManagedBy is set to 'Show'. This is also the default. If the preference is set to 'Don't show' the staff members name is not displayed and the column 'Managed by' in the table of suggestions in the patron account is not displayed. To test: - Create a one or more suggestions - 'Manage' them by accecpting or rejecting - Go to your patron account and check that the staff member name is shown for your suggestions - Apply patch, run database update - Check the name is still shown - Switch the preference to 'Don't show' - Check the name is no longer shown and the table still displays correctly, but without the 'Managed by' column - Repeat those tests for both bootstrap and prog theme! Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Works as advertised, the only little nitpick is you could just do [% IF Koha.Preference( 'OpacSuggestionManagedBy' ) %] However you are following the custom in that file already, so that's fine Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master, along with a follow-up to repair table sorting. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I did this mostly thinking about data privacy as we have to use personalized accounts for each staff member. So JQuery/CSS was not enough to achieve the goal here and hide the information safely. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just trying to explain - I agree it's a pref for a small thing :) -- You are receiving this mail because: You are watching all bug changes.