[Bug 10771] New: three disused scripts in misc/cronjobs/stats should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Bug ID: 10771 Summary: three disused scripts in misc/cronjobs/stats should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: gmcharlt@gmail.com QA Contact: testopia@bugs.koha-community.org The following scripts in misc/cronjobs/stats/ were added in 2008: monthly_circulation_statistics.pl monthly_new_items_statistics.pl monthly_new_patron_statistics.pl The commit message indicate that they were added for the Athens County Public Library. IRC conversation with Owen Leonard today indicates that ACPL doesn't use them at present. The commit message also says that "they don't work 100% with stock 3.0 yet". All three scripts make reference to a column that doesn't exist, biblioitems.ccode, and attempts to run them result in a lot of warning messages. There's been next to no work on them over the years. Consequently, I think that they should be removed as dead code. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10426 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 20510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20510&action=edit Bug 10771: remove disused statistical reports cronjobs This patch removes three cronjobs that are believed to be unused for the following reasons: [1] The commit message that introduces them indicates that they were written for a particular library. A staff member from that library has confirmed that they are not in use. [2] The scripts have received essentially no patches since they were introduced except for being caught up in a broader code-improvement patch. [3] They refer to a column that no longer exists in biblioitems. [4] They no longer adhere to guidelines for command-line utilities, and there's been no sign that anybody has felt the urge to correct that. [5] They are not referenced by another code or the manual, and the mailing list archives do not include any substantive discussion of their use. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20510|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 20813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20813&action=edit Bug 10771: remove disused statistical reports cronjobs This patch removes three cronjobs that are believed to be unused for the following reasons: [1] The commit message that introduces them indicates that they were written for a particular library. A staff member from that library has confirmed that they are not in use. [2] The scripts have received essentially no patches since they were introduced except for being caught up in a broader code-improvement patch. [3] They refer to a column that no longer exists in biblioitems. [4] They no longer adhere to guidelines for command-line utilities, and there's been no sign that anybody has felt the urge to correct that. [5] They are not referenced by another code or the manual, and the mailing list archives do not include any substantive discussion of their use. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20813|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20834&action=edit Bug 10771: remove disused statistical reports cronjobs This patch removes three cronjobs that are believed to be unused for the following reasons: [1] The commit message that introduces them indicates that they were written for a particular library. A staff member from that library has confirmed that they are not in use. [2] The scripts have received essentially no patches since they were introduced except for being caught up in a broader code-improvement patch. [3] They refer to a column that no longer exists in biblioitems. [4] They no longer adhere to guidelines for command-line utilities, and there's been no sign that anybody has felt the urge to correct that. [5] They are not referenced by another code or the manual, and the mailing list archives do not include any substantive discussion of their use. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10771 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org