[Bug 10426] New: Remove unused sub GetCcodes from C4::Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Bug ID: 10426 Summary: Remove unused sub GetCcodes from C4::Koha Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: colin.campbell@ptfs-europe.com Only reference to routine is in a comment. Delete it Lets not waste time maintaining unused code (and I can see at least 3 things that could be fixed in it, if we were) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |colin.campbell@ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 18702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18702&action=edit proposed patch Removes unused code and comment -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Needs removing from t/db_dependent/lib/KohaTest/Koha.pm as well I guess. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle.m.hall@gmail.com --- Comment #3 from Kyle M Hall <kyle.m.hall@gmail.com> --- In addition to Srdjan's comment, this sub is used in misc/cronjobs/stats/monthly_circulation_statistics.pl To remove the GetCcodes sub, this script will need to be refactored or deleted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Depends on| |10771 --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Kyle M Hall from comment #3)
In addition to Srdjan's comment, this sub is used in misc/cronjobs/stats/monthly_circulation_statistics.pl
To remove the GetCcodes sub, this script will need to be refactored or deleted.
This may not be a long term blocker. See bug 10771. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Srdjan Jankovic from comment #2)
Needs removing from t/db_dependent/lib/KohaTest/Koha.pm as well I guess.
Yes, but not necessarily a blocker overall: see bug 10539. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Depends on| |10539 --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- On balance, I think the issues raised by Srdjan and Kyle need not block testing and signoff of the proposed patch, although the dependent bugs will block pushing to master. Setting to needs signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18702|0 |1 is obsolete| | --- Comment #7 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 20518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20518&action=edit Bug 10426 Remove unused sub GetCcodes from Koha.pm Remove uncalled sub GetCcodes Also remove comment in opac-search.pl which is remaining reference to it and serves no useful purpose Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20518|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20736&action=edit Everything checks out. Still needs dependencies to pass qa before it could be pushed though. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- One of the dependent bugs has been pushed to master, leaving bug 10771, which needs signoff. I encourage anybody interested in seeing this patch get pushed to review the patches for 10771. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10426 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org