http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 Ata ur Rehman <ata.rehman@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ata.rehman@gmail.com --- Comment #2 from Ata ur Rehman <ata.rehman@gmail.com> --- Dear All I'm also getting the same error in Koha 3.6.4 Ata ur Rehman LISolutions -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 Katie <kaust@nhusd.k12.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kaust@nhusd.k12.ca.us -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 --- Comment #4 from Albert Oller <ago@bywatersolutions.com> --- Hi, same problem with 3.8 missing unzip fixed with : sudo apt-get install unzip current 3.8 picture-upload.pl gives this error: Patron image failed to upload Unpacking completed 1 directories scanned. 1 directories processed. - Cardnumber: WARNING: This image not imported because the cardnumber and filename is missing. installed the older picture-upload.pl and it now works fine. Here's the diff of the two: (picture-upload.pl.orig = 3.8 version) kohaclone/tools$ diff picture-upload.pl picture-upload.pl.orig 61c61 < picture-upload.p. - Script for handling uploading of both single and bulk patronimages and importing them into the database. ---

picture-upload.pl - Script for handling uploading of both single and bulk patronimages and importing them into the database. 81c81,84 < my $filesuffix = $1 if $uploadfilename =~ m/(\..+)$/i;

my $filesuffix; if ( $uploadfilename =~ m/(\..+)$/i ) { my $filesuffix = $1; }

98c101 < unless (system("unzip $tempfile -d $dirname") == 0) { ---

unless (system("unzip", $tempfile, '-d', $dirname) == 0) {

257,258c260,264 < my $dberror = PutPatronImage($cardnumber,$mimetype, $imgfile) if $mimetype; < if ( !$dberror && $mimetype ) { # Errors from here on are fatal only to the import of a particular image, so don't bail, just note the error and keep going ---

my $dberror; if ($mimetype) { $dberror = PutPatronImage( $cardnumber, $mimetype, $imgfile ); } if ( !$dberror && $mimetype ) { # Errors from here on are fatal only to the import of a particular image, so don't bail, just note the error and keep going

298,299d303 < < =back -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 --- Comment #6 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #5)

I think I have managed to fix this.

In the new code:

my $filesuffix; if ( $uploadfilename =~ m/(\..+)$/i ) { my $filesuffix = $1; }

$filesuffix is being declared as local (with my) twice.

If the second my is deleted, the upload works.

Good catch indeed! And here is the commit which broke it: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=b5b71339f3e3dfd6... Maybe you would consider submitting a patch to fix this bug? In return, you'll get your name added to the list of those who make Koha what it is. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #8 from Chris Nighswonger <cnighswonger@foundations.edu> --- Updating status -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12503|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12577&action=edit [SIGNED-OFF] Bug 7643 - Can't upload and import zipped file of patron images Fixed problem with re-declaration of $filesuffix Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact|koha.sekjal@gmail.com |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #9)

Created attachment 12577 [details] [SIGNED-OFF] Bug 7643 - Can't upload and import zipped file of patron images

Fixed problem with re-declaration of $filesuffix

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

patch looks good, passing QA... thanks for the patch Ivan! :p $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 0c75d66) * 7ab41ad Bug 7643 - Can't upload and import zipped file of patron images tools/picture-upload.pl * tools/picture-upload.pl OK -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.6. Thanks Ivan and welcome to the Koha contributors family! -- You are receiving this mail because: You are watching all bug changes.