[Bug 8898] New: Remove unused mainmenu include and related styles in the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8898 Priority: P5 - low Change sponsored?: --- Bug ID: 8898 Assignee: oleonard@myacpl.org Summary: Remove unused mainmenu include and related styles in the staff client Severity: minor Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Templates Product: Koha There is an unused include file, mainmenu.inc, and related CSS which can be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8898 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- A similar file, additem-menu.inc should be removed also. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8898 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8898 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12764&action=edit Bug 8898 - Remove unused mainmenu include and related styles in the staff client This patch removes the mainmenu and additem-menu includes and #navigation references in staff-global.css which were used by those includes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8898 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12764|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12784&action=edit [SIGNED-OFF] Bug 8898 - Remove unused mainmenu include and related styles in the staff client This patch removes the mainmenu and additem-menu includes and #navigation references in staff-global.css which were used by those includes. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8898 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Applied patch, checked many different pages, no ill effects were percieved. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8898 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com QA Contact| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * remove things only (but some string, thus QAing before String Freeze) * grep mainmenu.inc and additem-menu show it's not used anymore passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8898 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8898 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8898 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org