https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73139|0 |1 is obsolete| | --- Comment #3 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73140&action=edit Bug 18316 - Add weighting/relevancy options to ElasticSearch These are proof of concept that we can add weighting simply at time of search query. Testable but not suitable for pushing. To test: Apply patch Use the advanced search page in the intranet Choose a field and enter a number to weight Note diffrently ordered results than without any weighing To DO: 1 - Add a config page for default wieghting to be used 2 - Allow addition of any indexed field to wieghting at search 3 - All more than one fields to be weighted 4 - Better code/variables Rebased-by Alex Arnaud <alex.arnaud@biblibre.com> (2018-03-21) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson@biblibre.com --- Comment #4 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- Alex is working on this. We are assuming relevancy working is mostly important for simple search, or what zebra calls the "keyword" index. What we plan to do: Add columns to the "search fields" tab of the search engine configuration page, where the user will be able to indicate a weight for each field. This will allow to configure the way the simple search is weighted: it will search in all fields for which a weight has been indicated. If no weight was indicated it will search in all fields. (In addition, this allows excluding some search fields from the simple search!) This will not affect advanced search, in which the user can pick indices himself. (But it could, and we would then run the query with the weight defined for each field.) The possibility to add a weight to a search field will only be offered if this field is used in the biblio mapping. So it won't be possible to give weight to a field only used in the authorities mapping, or defined but unused. In the future it should be possible to have "koha indices" that search across multiple elasticsearch fields, each with a different weight. But this seems a bit ambitious for now, especially with 18.05 so close. So this seems like a reasonable goal for the next release, and certainly a very useful one. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73140|0 |1 is obsolete| | --- Comment #6 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73492&action=edit Bug 18316 - Ability to weight search fields Weight can be defined between 1 and 99. only search fields mapped with biblios can be weighted Test plan: - apply this patch, - update schema file (perl misc/devel/update_dbix_class_files.pl), - go to Administration > Search engine configuration, - in search fields tab, define weights for some fields and save, - check weights has been saved, - reset some weights (empty) and save, - check weights has been reset -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73493|0 |1 is obsolete| | --- Comment #9 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 73601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73601&action=edit Bug 18316 - Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on these fields only and with the coresponding weights. Else, search is done on the entire record. Test plan (having Koha working with Elasticsearch): - apply this patch, - try searches with and without weight defined on search fields Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #11 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Séverine Queune from comment #10)

Patchs work as described.

I misunderstood the way to use numbers, thinking "1" was the most important field(s) I wanted to search in. Maybe a warning or more detailed description would be useful for reindex can take time for big databases, it would be sad if others make the same mistake as I. You mean add a warning to tell users that more the weight is hight more the field is important?

This weighting add a lot of relevance to the simple search.

In reaction to Gaetan's comment, it also appears that having weight on sub-fields used on the same index would be great. For example, when searching with index "title" in our Unimarc system, we would like to display books that contains the searched word in 200$b before the ones in 410$t. I'm not yet confortable enough with all ES capabilities, but it could be done by adding a "other-title" search field with a different weight. Does it make sens for you?

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand@bulac.fr --- Comment #12 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- (In reply to Alex Arnaud from comment #11)

(In reply to Séverine Queune from comment #10)

...

Patchs work as described.

I misunderstood the way to use numbers, thinking "1" was the most important field(s) I wanted to search in. Maybe a warning or more detailed description would be useful for reindex can take time for big databases, it would be sad if others make the same mistake as I. You mean add a warning to tell users that more the weight is hight more the field is important?

I think that's what she meant.

...

This weighting add a lot of relevance to the simple search.

In reaction to Gaetan's comment, it also appears that having weight on sub-fields used on the same index would be great. For example, when searching with index "title" in our Unimarc system, we would like to display books that contains the searched word in 200$b before the ones in 410$t. I'm not yet confortable enough with all ES capabilities, but it could be done by adding a "other-title" search field with a different weight. Does it make sens for you?

Yes, but not to our librarians colleagues who want to describe titles in a myriad of MARC' subfield while uniting them all under one index entry. I'm not sure to be able to convince them this may not be a good idea :). The 4XX$t as a title index for instance, is a relevancy killer. I'll try to convince them to bind it to a linked-with-title index. Anyway, having a different relevancy for same index/different subfield may be another bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #14 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Nick Clemens from comment #13)

I agree - different weighting for specific fields in an index would be a separate bug +1

Searching and weighting works well and tests pass

I have questions about the comments:

...

Weight: define weight between 1 and 99. add: Higher numbers indicate increased relevenacy

...

search will be done on weighted fields only this doesn't seem to be the case - weight author - search for an isbn, you get the record Right. Search is done on all fields but boost the weighted ones.

...

if no field is weighted, search will be done on all the record true, but we search all fields even with some wieghts

I think the behaviour is correct, searching _all and adding weighted fields, just need to adjust comments

Should we indicate that weights are not used during adv search? (If we want them I think that can be done on a future patch) I can do it. The future patch for adv search will have to remove the comment.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 74116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74116&action=edit Bug 18316: Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on these fields only and with the coresponding weights. Else, search is done on the entire record. Test plan (having Koha working with Elasticsearch): - apply this patch, - try searches with and without weight defined on search fields Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20602 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20602 [Bug 20602] Use search fields weight/relecancy on OPAC simple search -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1.

From Koha::SearchFields->weighted_fields

+ while ( my $field = $fields->next ) { + push @$w_fields, $field->name; + push @$weight, $field->weight; + } + + return ($w_fields, $weight);

From search.pl: ($w_fields, $weight) = Koha::SearchFields->weighted_fields();

then we call build_query_compat with { w_fields => @$w_fields, weight => @$weight } which will finally do: + if ( defined $weights[0] ) { + for (my $i = 0 ; $i < (scalar @weights) ; $i++ ){ + push @fields, "$w_fields[$i]^$weights[$i]"; + } + } so basically you want to fetch the weighted fields from build_query_compat, with something like: push @fields, sprintf("%s^%s", $_->name, $_->weight) for Koha::SearchFields->weighted_fields; That seems much more easier, what did I miss? 2. Sounds like you could replaced the loop in is_mapped_biblios, with $self->search_marc_maps->search({ index_name => 'biblios' })->count ? 1 : 0; 3. search_marc_maps reads wrong too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #20 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Jonathan Druart from comment #19)

1. From Koha::SearchFields->weighted_fields

+ while ( my $field = $fields->next ) { + push @$w_fields, $field->name; + push @$weight, $field->weight; + } + + return ($w_fields, $weight);

From search.pl: ($w_fields, $weight) = Koha::SearchFields->weighted_fields();

then we call build_query_compat with { w_fields => @$w_fields, weight => @$weight }

which will finally do: + if ( defined $weights[0] ) { + for (my $i = 0 ; $i < (scalar @weights) ; $i++ ){ + push @fields, "$w_fields[$i]^$weights[$i]"; + } + }

so basically you want to fetch the weighted fields from build_query_compat, with something like: push @fields, sprintf("%s^%s", $_->name, $_->weight) for Koha::SearchFields->weighted_fields;

That seems much more easier, what did I miss? We don't want to use weighted fields on advanced search and build_query_compat is called for both simple and adv search. But i can propose something similar in search.pl

2. Sounds like you could replaced the loop in is_mapped_biblios, with $self->search_marc_maps->search({ index_name => 'biblios' })->count ? 1 : 0; Right.

3. search_marc_maps reads wrong too. What is wrong?

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74116|0 |1 is obsolete| | --- Comment #24 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 74752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74752&action=edit Bug 18316: Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on these fields only and with the coresponding weights. Else, search is done on the entire record. Test plan (having Koha working with Elasticsearch): - apply this patch, - try searches with and without weight defined on search fields Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #26 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 74754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74754&action=edit Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a result set - code refactoring for gettings weighted fields - Koha::SearchFields::weighted_fields return a result set Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |glasklas@gmail.com --- Comment #28 from David Gustafsson <glasklas@gmail.com> --- Nice work. I was unable to apply patch using git bz apply, getting: error: sha1 information is lacking or useless (Koha/SearchEngine/Elasticsearch/QueryBuilder.pm). error: could not build fake ancestor Am I doing something wrong or is there an issue with the current patches? I also have some questions/suggestions: 1) I find it slightly confusing that "weight" is in the patch whilst "boost" is used in elastic. Not a big deal at all, but would be nicer to use the same terminology as Elastic imho. 2) Weight/boost should be decimal, for example DECIMAL(5,2) should be more than enough precision. 3) Why not use field boosting in advanced search? As a user I would find it confusing to get different results performing the same search in both interfaces. 4) It seems like field boosts/weights specified in mappings.yaml will not be picked up, this could be added in reset_elasticsearch_mappings in Elasticsearch.pm. I can contribute patches for some or all of the above s depending on which ones are deemed good suggestions once I am able to apply the current patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Patch doesn't apply --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, please change to 'Patch doesn't apply' in this case. Some devs use saved searches to see where they need to take action, this makes it easier. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #30 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to David Gustafsson from comment #28)

Nice work. I was unable to apply patch using git bz apply, getting:

error: sha1 information is lacking or useless (Koha/SearchEngine/Elasticsearch/QueryBuilder.pm). error: could not build fake ancestor

Am I doing something wrong or is there an issue with the current patches? Fixed!

I also have some questions/suggestions:

1) I find it slightly confusing that "weight" is in the patch whilst "boost" is used in elastic. Not a big deal at all, but would be nicer to use the same terminology as Elastic imho. I'm not against renaming it. In my mind, boost is most seen as a yes/not choice (boosted/not boosted) and not as range of values.

2) Weight/boost should be decimal, for example DECIMAL(5,2) should be more than enough precision. Currently we can set it between 1 and 99. Do you think we need more precision?

3) Why not use field boosting in advanced search? As a user I would find it confusing to get different results performing the same search in both interfaces. We plan to do that later. We believed that adv search allows to search on specific(s) field(s). So boosting seems less relevant.

4) It seems like field boosts/weights specified in mappings.yaml will not be picked up, this could be added in reset_elasticsearch_mappings in Elasticsearch.pm. See bug 20607 which depend on this one

I can contribute patches for some or all of the above s depending on which ones are deemed good suggestions once I am able to apply the current patch.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74752|0 |1 is obsolete| | --- Comment #32 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75074&action=edit Bug 18316: Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on these fields only and with the coresponding weights. Else, search is done on the entire record. Test plan (having Koha working with Elasticsearch): - apply this patch, - try searches with and without weight defined on search fields Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74754|0 |1 is obsolete| | --- Comment #34 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75076&action=edit Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a result set - code refactoring for gettings weighted fields - Koha::SearchFields::weighted_fields return a result set Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #35 from David Gustafsson <glasklas@gmail.com> --- Sorry about the late reply.

Fixed! Great :)

I'm not against renaming it. In my mind, boost is most seen as a yes/not choice (boosted/not boosted) and not as range of values.

As previously noted, not a big deal, my main issue with it is that boost is used in lucene/elastic.

Currently we can set it between 1 and 99. Do you think we need more precision?

In lucene/elastic weight is a decimal number. So I really think it should be a decimal for that reason. The admin interface should then probably use text inputs instead of selects with predefined values. There are also situations where you just want to adjust the relevancy a very small amount to make sure queries are perfectly balanced and that one does not always dominate the relevance scoring. With integers this is much more difficult, and you will be forced to assign boosts to many more fields to get the increased precision.

We plan to do that later. We believed that adv search allows to search on specific(s) field(s). So boosting seems less relevant.

Ok, I adjusted some of the queries for authorities search to utilize fields better in bug 20589. So perhaps I can include the field boots if I rebase that patch on this one when it has been merged in Koha.

See bug 20607 which depend on this one

Aha, ok. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #37 from David Gustafsson <glasklas@gmail.com> --- Created attachment 75458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75458&action=edit Change search field weight field to decimal and add column declaration to DBIx results source -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Alex Arnaud from comment #38)

(In reply to David Gustafsson from comment #37)

...

Created attachment 75458 [details] [review] [review] Change search field weight field to decimal and add column declaration to DBIx results source

Hello David,

You provide changes on Koha/Schema/Result/SearchField.pm. This should be done in a dedicated patch. RM will ignore it.

Also, you replaced the input type number with a input text. This cause errors when typing non-numeric characters in. You can use a input number with step=0.1 to increment decimal numbers.

Need to fail QA

Input number for decimals can be problematic for translations in my experience. Please test for example with de-DE if the value is correctly stored (it will force a decimal comma instead of . on input, which is inconsistent with our other input fields right now) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #41 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to David Gustafsson from comment #40)

(In reply to Alex Arnaud from comment #38)

...

(In reply to David Gustafsson from comment #37)

...

Created attachment 75458 [details] [review] [review] [review] Change search field weight field to decimal and add column declaration to DBIx results source

Hello David,

You provide changes on Koha/Schema/Result/SearchField.pm. This should be done in a dedicated patch. RM will ignore it.

Also, you replaced the input type number with a input text. This cause errors when typing non-numeric characters in. You can use a input number with step=0.1 to increment decimal numbers.

Need to fail QA

Ok, I can fix this, though precision should be 0.01 in that case. There is server side validation, so everything that is not a number will be ignored regardless of input type.

I was not aware that Koha/Schema/Result/* files should not be changed. How does that work for signing off, since without the change Koha will throw an error when trying to save weights in admin UI?

Generally you make your code changes, commit the patches, then run: misc/devel/update_dbix_class_files.pl And commit those as their own patch - that way the changes are included for testers but can be regenerated when pushing to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #43 from David Gustafsson <glasklas@gmail.com> --- Created attachment 75490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75490&action=edit Update Koha/Schema/Result/SearchField.pm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #45 from David Gustafsson <glasklas@gmail.com> --- (In reply to Nick Clemens from comment #41)

Generally you make your code changes, commit the patches, then run: misc/devel/update_dbix_class_files.pl And commit those as their own patch - that way the changes are included for testers but can be regenerated when pushing to master

Thanks for clarifying this, now I understand how to go about it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Alex Arnaud from comment #42)

(In reply to Katrin Fischer from comment #39)

...

Input number for decimals can be problematic for translations in my experience. Please test for example with de-DE if the value is correctly stored (it will force a decimal comma instead of . on input, which is inconsistent with our other input fields right now)

I just tried on a Koha translated into German. Sounds that there no problem with the values stored. Any test plan to reproduice issue you talked about?

The problem we had was that it forced you to enter decimal values with comma but Koha didn't undertand them and then truncated the value. 1,1 = 1. This happened in fines in an older version, some more info here: Bug 17098 - Validation problems with form field type "number" (decimal separator) We are still using the patch described there. It might depend on the browser and version you use and will only appear if the template language is one that uses decimal commas. But what remains, I think, is a problem of consistency. Having some inputs ask for comma and others for . is confusing to libraries. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #48 from David Gustafsson <glasklas@gmail.com> --- Created attachment 75519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75519&action=edit Bug 18316: Update Koha/Schema/Result/SearchField.pm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75520|0 |1 is obsolete| | --- Comment #50 from David Gustafsson <glasklas@gmail.com> --- Created attachment 75521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75521&action=edit Bug 18316: Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on these fields only and with the coresponding weights. Else, search is done on the entire record. Test plan (having Koha working with Elasticsearch): - apply this patch, - try searches with and without weight defined on search fields Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #52 from David Gustafsson <glasklas@gmail.com> --- Created attachment 75523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75523&action=edit Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a result set - code refactoring for gettings weighted fields - Koha::SearchFields::weighted_fields return a result set Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #54 from David Gustafsson <glasklas@gmail.com> --- Created attachment 75525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75525&action=edit Bug 18316: Update Koha/Schema/Result/SearchField.pm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75521|0 |1 is obsolete| | --- Comment #56 from David Gustafsson <glasklas@gmail.com> --- Created attachment 75527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75527&action=edit Bug 18316: Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on these fields only and with the coresponding weights. Else, search is done on the entire record. Test plan (having Koha working with Elasticsearch): - apply this patch, - try searches with and without weight defined on search fields Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75523|0 |1 is obsolete| | --- Comment #58 from David Gustafsson <glasklas@gmail.com> --- Created attachment 75529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75529&action=edit Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a result set - code refactoring for gettings weighted fields - Koha::SearchFields::weighted_fields return a result set Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75525|0 |1 is obsolete| | --- Comment #60 from David Gustafsson <glasklas@gmail.com> --- Created attachment 75531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75531&action=edit Bug 18316: Update Koha/Schema/Result/SearchField.pm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #62 from Séverine Queune <severine.queune@bulac.fr> --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 18316: <h1>Something went wrong !</h1>Applying: Bug 18316: Ability to weight search fields Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/searchengine/elasticsearch/mappings.tt Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 18316: Ability to weight search fields The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 18316 - Add weighting/relevancy options to ElasticSearch 75526 - Bug 18316: Ability to weight search fields 75527 - Bug 18316: Add weighting/relevancy options to ES query on simple search 75528 - Bug 18316: String changes 75529 - Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a result set - code refactoring for gettings weighted fields - Koha::SearchFields::weighted_fields return a result set 75530 - Bug 18316: Change search field weight field to decimal 75531 - Bug 18316: Update Koha/Schema/Result/SearchField.pm Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-18316-Ability-to-weight-search-fields-MFIcJl.patch . Same result on my test instance :/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75526|0 |1 is obsolete| | --- Comment #64 from David Gustafsson <glasklas@gmail.com> --- Created attachment 75536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75536&action=edit Bug 18316: Ability to weight search fields Weight can be defined between 1 and 99. only search fields mapped with biblios can be weighted Test plan: - apply this patch, - update schema file (perl misc/devel/update_dbix_class_files.pl), - go to Administration > Search engine configuration, - in search fields tab, define weights for some fields and save, - check weights has been saved, - reset some weights (empty) and save, - check weights has been reset Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75528|0 |1 is obsolete| | --- Comment #66 from David Gustafsson <glasklas@gmail.com> --- Created attachment 75538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75538&action=edit Bug 18316: String changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75530|0 |1 is obsolete| | --- Comment #68 from David Gustafsson <glasklas@gmail.com> --- Created attachment 75540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75540&action=edit Bug 18316: Change search field weight field to decimal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #70 from David Gustafsson <glasklas@gmail.com> --- Now patches should apply to latest master. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #72 from Séverine Queune <severine.queune@bulac.fr> --- Sorry David, I took a few days off and didn't try this patch earlier, it doesn't apply on last master... Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18316: Ability to weight search fields Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... error: The following untracked working tree files would be overwritten by merge: installer/data/mysql/atomicupdate/bug_18316_add-weight-column.perl t/db_dependent/Koha/SearchField.t Please move or remove them before you can merge. Aborting Failed to merge in the changes. Patch failed at 0001 Bug 18316: Ability to weight search fields -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #74 from David Gustafsson <glasklas@gmail.com> --- Hmm, thought I had fixed the merge conflicts, but perhaps I was using a non up to date or something has changed since last time. Can have a look at it tomorrow if no one else does before then. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #76 from David Gustafsson <glasklas@gmail.com> --- Yes, work for the master I did the rebase on, but the signature comment in SearchField.pm had changed since then. Now should work again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #80 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, I fixed the conflict in kohastructure.sql, but then the 4th patch won't apply: sloth:/usr/local/vagrant/kohaclone_master (32-18316-qa-elastic_weight|AM 1/1) $ git bz apply --continue Applying: Bug 18316: Ability to weight search fields Applying: Bug 18316: Add weighting/relevancy options to ES query on simple search Applying: Bug 18316: String changes Applying: Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a result set - code refactoring for gettings weighted fields - Koha::SearchFields::weighted_fields return a result set error: sha1 information is lacking or useless (Koha/SearchEngine/Elasticsearch/QueryBuilder.pm). error: could not build fake ancestor Patch failed at 0001 Bug 18316 - QA improvement - Koha::SearchField::search_marc_maps return a result set - code refactoring for gettings weighted fields - Koha::SearchFields::weighted_fields return a result set Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18316---QA-improvement---KohaSearchFieldsearch-dKxuaY.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75536|0 |1 is obsolete| | Attachment #75537|0 |1 is obsolete| | Attachment #75538|0 |1 is obsolete| | Attachment #75539|0 |1 is obsolete| | Attachment #75540|0 |1 is obsolete| | Attachment #75699|0 |1 is obsolete| | Attachment #75730|0 |1 is obsolete| | --- Comment #81 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77661&action=edit Bug 18316: Ability to weight search fields Weight can be defined between 1 and 99. only search fields mapped with biblios can be weighted Test plan: - apply this patch, - update schema file (perl misc/devel/update_dbix_class_files.pl), - go to Administration > Search engine configuration, - in search fields tab, define weights for some fields and save, - check weights has been saved, - reset some weights (empty) and save, - check weights has been reset Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #83 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77663&action=edit Bug 18316: String changes Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #85 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77665&action=edit Bug 18316: Change search field weight field to decimal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #87 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77667&action=edit Bug 18316: Fix field weight validation/deletion bug -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Joonas Kylmälä <joonas.kylmala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi --- Comment #89 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Katrin Fischer from comment #88)

3.2) Can you explain this line? <input type="hidden" name="advsearch" value="1"/>

It is used in search.pl to enable weighted field search to any other search expect the one done in the Advanced search page (/cgi-bin/koha/catalogue/search.pl): unless ( $cgi->param('advsearch') ) { $build_params->{weighted_fields} = 1; } So if the advsearch parameter equals '1' the weighted search is disabled. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #91 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx, Joonas. Waiting for a follow-up here so I can continue testing - hopefully soon! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #94 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78397&action=edit Bug 18316: Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on all fields plus those with the coresponding weights. Else, search is done on the entire record with no weighting. The advanced search page is unaffected by these changes Test plan (having Koha working with Elasticsearch): - apply this patch - have some weights defined for various fields - try searches from the search bar and from the advanced search page - confirm weighting affects the relevancy (in expected ways) e.g. 1. search for 'a' from advanced search, note results 2. give 'title' a weight 3. search for 'a' using the simple search bar 4. results with 'a' in the title should now be more relevant - confirm search results on advanced search page are unaffected Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #96 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78399&action=edit Bug 18316: (follow-up) Koha::SearchField::search_marc_maps return a result set - code refactoring for gettings weighted fields - Koha::SearchFields::weighted_fields return a result set Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #98 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78401&action=edit Bug 18316: Update Koha/Schema/Result/SearchField.pm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #100 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 78403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78403&action=edit Bug 18316: (follow-up) Fix tests and update statement -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala@helsinki.fi -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #105 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Joonas Kylmälä from comment #104)

This bug already happens even without this patch. Also for example if you have specified multiple keywords in the search only one will be left after clicking the return button.

Is there already a bug report open for this problem ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #107 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Alex Arnaud from comment #106)

Created attachment 80278 [details] [review] Bug 18316: remove use_dis_max

There should be a (follow-up) in the title. Otherwise looks good and will sign-off after the change. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #109 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Joonas Kylmälä from comment #108)

...

Is there already a bug report open for this problem ?

yes: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20114

Thanks -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78397|0 |1 is obsolete| | --- Comment #112 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 81005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81005&action=edit Bug 18316: Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on all fields plus those with the coresponding weights. Else, search is done on the entire record with no weighting. The advanced search page is unaffected by these changes Test plan (having Koha working with Elasticsearch): - apply this patch - have some weights defined for various fields - try searches from the search bar and from the advanced search page - confirm weighting affects the relevancy (in expected ways) e.g. 1. search for 'a' from advanced search, note results 2. give 'title' a weight 3. search for 'a' using the simple search bar 4. results with 'a' in the title should now be more relevant - confirm search results on advanced search page are unaffected Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78399|0 |1 is obsolete| | --- Comment #114 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 81007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81007&action=edit Bug 18316: (follow-up) Koha::SearchField::search_marc_maps return a result set - code refactoring for gettings weighted fields - Koha::SearchFields::weighted_fields return a result set Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78401|0 |1 is obsolete| | --- Comment #116 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 81009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81009&action=edit Bug 18316: Update Koha/Schema/Result/SearchField.pm https://bugs.koha-community.org/show_bug.cgi?id=18316 Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78403|0 |1 is obsolete| | --- Comment #118 from Ere Maijala <ere.maijala@helsinki.fi> --- Created attachment 81011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81011&action=edit Bug 18316: (follow-up) Fix tests and update statement Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #120 from Ere Maijala <ere.maijala@helsinki.fi> --- I took the liberty of fixing the md5sum of the schema file while signing off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81005|0 |1 is obsolete| | --- Comment #122 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81508&action=edit Bug 18316: Add weighting/relevancy options to ES query on simple search The idea is the following: if some search field(s) are weighted in search engine config page, Koha will query ES on all fields plus those with the coresponding weights. Else, search is done on the entire record with no weighting. The advanced search page is unaffected by these changes Test plan (having Koha working with Elasticsearch): - apply this patch - have some weights defined for various fields - try searches from the search bar and from the advanced search page - confirm weighting affects the relevancy (in expected ways) e.g. 1. search for 'a' from advanced search, note results 2. give 'title' a weight 3. search for 'a' using the simple search bar 4. results with 'a' in the title should now be more relevant - confirm search results on advanced search page are unaffected Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81007|0 |1 is obsolete| | --- Comment #124 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81510&action=edit Bug 18316: (follow-up) Koha::SearchField::search_marc_maps return a result set - code refactoring for gettings weighted fields - Koha::SearchFields::weighted_fields return a result set Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Rebased-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81009|0 |1 is obsolete| | --- Comment #126 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81512&action=edit Bug 18316: Update Koha/Schema/Result/SearchField.pm https://bugs.koha-community.org/show_bug.cgi?id=18316 Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81011|0 |1 is obsolete| | --- Comment #128 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81514&action=edit Bug 18316: (follow-up) Fix tests and update statement Signed-off-by: Ere Maijala <ere.maijala@helsinki.fi> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #130 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 81516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81516&action=edit Bug 18316: (QA follow-up) Add final missing filter Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Keywords| |release-notes-needed --- Comment #132 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #134 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Nick Clemens from comment #133)

Created attachment 82050 [details] [review] Bug 18316: (follow-up) Don't let 'fields' be undef and adjust tests

Followup pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #136 from David Gustafsson <glasklas@gmail.com> --- Hmm, no second thought this seems to have been done in Koha-master. So perhaps release-manager took care of this. I will fix this in my local branch then and RM will have to fix this manually again where regenerating the schema files for that in case it get merged. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 e.betemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29010 [Bug 29010] Weight input pattern wrong -- You are receiving this mail because: You are watching all bug changes.