https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316 --- Comment #41 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to David Gustafsson from comment #40)
(In reply to Alex Arnaud from comment #38)
(In reply to David Gustafsson from comment #37)
Created attachment 75458 [details] [review] [review] [review] Change search field weight field to decimal and add column declaration to DBIx results source
Hello David,
You provide changes on Koha/Schema/Result/SearchField.pm. This should be done in a dedicated patch. RM will ignore it.
Also, you replaced the input type number with a input text. This cause errors when typing non-numeric characters in. You can use a input number with step=0.1 to increment decimal numbers.
Need to fail QA
Ok, I can fix this, though precision should be 0.01 in that case. There is server side validation, so everything that is not a number will be ignored regardless of input type.
I was not aware that Koha/Schema/Result/* files should not be changed. How does that work for signing off, since without the change Koha will throw an error when trying to save weights in admin UI?
Generally you make your code changes, commit the patches, then run: misc/devel/update_dbix_class_files.pl And commit those as their own patch - that way the changes are included for testers but can be regenerated when pushing to master -- You are receiving this mail because: You are watching all bug changes.