[Bug 15731] New: C4::Reports::Guided::build_authorised_value_list is not used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Bug ID: 15731 Summary: C4::Reports::Guided::build_authorised_value_list is not used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org ...and can be removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47603&action=edit Bug 15731: Remove C4::Reports::Guided::build_authorised_value_list This subroutine has been added by commit 42acfbf75b7bb4ee53c6a6f035e258a0b522ce10 Bug 7993: Save reports with Group/Subgroup hierarchy But it has never been used (or git grep cheats me). Test plan: 1/ git grep build_authorised_value_list should not return any result 2/ Create a report, execute it Everything should work fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47603|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 47643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47643&action=edit [SIGNED-OFF]Bug 15731: Remove C4::Reports::Guided::build_authorised_value_list This subroutine has been added by commit 42acfbf75b7bb4ee53c6a6f035e258a0b522ce10 Bug 7993: Save reports with Group/Subgroup hierarchy But it has never been used (or git grep cheats me). Test plan: 1/ git grep build_authorised_value_list should not return any result 2/ Create a report, execute it Everything should work fine. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47643|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 47683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47683&action=edit Bug 15731: Remove C4::Reports::Guided::build_authorised_value_list This subroutine has been added by commit 42acfbf75b7bb4ee53c6a6f035e258a0b522ce10 Bug 7993: Save reports with Group/Subgroup hierarchy But it has never been used (or git grep cheats me). Test plan: 1/ git grep build_authorised_value_list should not return any result 2/ Create a report, execute it Everything should work fine. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15758 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15731 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! (I love seeing the truncating of these scripts) Keep em coming... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org