[Bug 15769] New: C4::Koha::slashifyDate is outdated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 Bug ID: 15769 Summary: C4::Koha::slashifyDate is outdated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47808&action=edit Bug 15769: Remove outdated C4::Koha::slashifyDate subroutine This subroutine does not make sense anymore (Koha::DateUtils should be used) and is no longer used. It can be removed safely. Test plan: git grep slashifyDate should not return any results prove t/Koha.t and prove t/db_dependent/Koha.t should return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47808|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 47827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47827&action=edit [SIGNED-OFF]Bug 15769: Remove outdated C4::Koha::slashifyDate subroutine This subroutine does not make sense anymore (Koha::DateUtils should be used) and is no longer used. It can be removed safely. Test plan: git grep slashifyDate should not return any results prove t/Koha.t and prove t/db_dependent/Koha.t should return green Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> slashifyDate removed, all test pass successfully -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #3 from Marc Véron <veron@veron.ch> --- Hi Hécror, Did you forget to switch to Signed-off? :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15800 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15800 [Bug 15800] Koha::AuthorisedValues - Remove C4::Koha::IsAuthorisedValueCategory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch complexity|--- |Small patch QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47827|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 47951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47951&action=edit Bug 15769: Remove outdated C4::Koha::slashifyDate subroutine This subroutine does not make sense anymore (Koha::DateUtils should be used) and is no longer used. It can be removed safely. Test plan: git grep slashifyDate should not return any results prove t/Koha.t and prove t/db_dependent/Koha.t should return green Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> slashifyDate removed, all test pass successfully Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15769 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org