[Bug 7125] New: can't change tag in frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 Bug #: 7125 Summary: can't change tag in frameworks Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com see attached. When I go to edit a framework and change the tag number it looks like I'm able to, but when I hit save my changes aren't saved and no error message is generated. If this tag number isn't editable it shouldn't appear as if it is. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> 2011-11-01 15:12:37 UTC --- Created attachment 6132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6132 edit framework tag -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.6 |master --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- As far as I can tell this bug is in master too, as of 3.12 beta2 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 27494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27494&action=edit Bug 7125 - can't change tag in frameworks When you edit an existing tag in a MARC framework the form makes it appear as if you can change the tag number when in fact you cannot. This patch changes the template so that the tag number does not appear as an editable form field during the edit process. To test, apply the patch and open an existing MARC framework in Adminstration -> MARC bibliographic framework. - Choose an existing tag from the list and click 'Edit.' - The line labeled "Tag" should display the tag as text. - Making a change to any of the tag's details should work correctly. - Return to the list of the MARC framework's tags. - Click 'New tag.' - The line labeled "Tag" should display a blank form field. - Create a new tag and confirm that it saves correctly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |oleonard@myacpl.org Severity|major |normal -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27494|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27499&action=edit [SIGNED-OFF] Bug 7125 - can't change tag in frameworks When you edit an existing tag in a MARC framework the form makes it appear as if you can change the tag number when in fact you cannot. This patch changes the template so that the tag number does not appear as an editable form field during the edit process. To test, apply the patch and open an existing MARC framework in Adminstration -> MARC bibliographic framework. - Choose an existing tag from the list and click 'Edit.' - The line labeled "Tag" should display the tag as text. - Making a change to any of the tag's details should work correctly. - Return to the list of the MARC framework's tags. - Click 'New tag.' - The line labeled "Tag" should display a blank form field. - Create a new tag and confirm that it saves correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as describes, on edit and new. No koha-qa errors -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27499|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27654&action=edit [PASSED QA] Bug 7125 - can't change tag in frameworks When you edit an existing tag in a MARC framework the form makes it appear as if you can change the tag number when in fact you cannot. This patch changes the template so that the tag number does not appear as an editable form field during the edit process. To test, apply the patch and open an existing MARC framework in Adminstration -> MARC bibliographic framework. - Choose an existing tag from the list and click 'Edit.' - The line labeled "Tag" should display the tag as text. - Making a change to any of the tag's details should work correctly. - Return to the list of the MARC framework's tags. - Click 'New tag.' - The line labeled "Tag" should display a blank form field. - Create a new tag and confirm that it saves correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as describes, on edit and new. No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Work as described, template change only. Checked editing and adding tags. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7125 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org