[Bug 12127] New: Incorrect DataTable types in Holds to Pull list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 Bug ID: 12127 Summary: Incorrect DataTable types in Holds to Pull list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org At the moment, it appears that the branch filtering isn't working correctly in the Holds to Pull list. That is, it is being too restrictive rather than too fuzzy (bug 11502). It will only show rows that have a single branch when filtering. It won't show rows that have multiple available branches. I would swear that this wasn't happening earlier in the year. I repeatedly tested the patch on bug 11502 and it went through the QA process without a problem. I would also swear that the DataTables JS hasn't changed in the past few months. I would swear this because I'm using the exact same code on my machine but the filtering isn't working correctly. The only thing that seems to remotely make sense to me is perhaps a change in the browsers' internal JS processing, but I have no idea really... In any case, the immediate cause appears to be that DataTables is typing the column data as "html" rather than "string", so it is stripping out the <br> tags and creating one long string of branchcodes on which to search. This is a problem after the implementation of bug 11502 which uses the angle brackets from the <br> tags as a separator in regex to make the filtering more precise. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11502 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 27449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27449&action=edit Bug 12127 - Incorrect DataTable types in Holds to Pull list This patch explicitly sets the sType in the Holds to Pull list table for the libraries, itypes, and locations columns. It appears that the type is automatically being set to "html" when it should be set to "string". It needs to have a sType of "string", since DataTables will strip out the <br> tags when using "html", and we need them for the regexp we use to create a more precise filter search. _TEST PLAN_ Before applying: 1) Place a "next available" hold on a record with an item available from one library/branch (e.g. "Branch A") 2) Place a "next available" hold on a record with an item available from two different libraries/branches 3) Place a "next available" hold on a record with an item available from three different libraries/branches - one of which is the same as the library/branch from Step 1. 4) Go to the Holds to Pull List 5) Filter the branches by "Branch A". 6) You should only see the hold from Step 1 - not Step 3. 7) Try filtering on a branch for a hold that has multiple libraries/branches. (They shouldn't appear when filtering, except when using the "None" filter). Apply the patch. After applying: 1) Repeat Steps 4-7 from above. When filtering on "Branch A", you should be able to see all holds that are available at "Branch A", even if they are available at other branches (i.e. the holds has multiple libraries listed). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27449|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 27481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27481&action=edit [SIGNED-OFF] Bug 12127 - Incorrect DataTable types in Holds to Pull list This patch explicitly sets the sType in the Holds to Pull list table for the libraries, itypes, and locations columns. It appears that the type is automatically being set to "html" when it should be set to "string". It needs to have a sType of "string", since DataTables will strip out the <br> tags when using "html", and we need them for the regexp we use to create a more precise filter search. _TEST PLAN_ Before applying: 1) Place a "next available" hold on a record with an item available from one library/branch (e.g. "Branch A") 2) Place a "next available" hold on a record with an item available from two different libraries/branches 3) Place a "next available" hold on a record with an item available from three different libraries/branches - one of which is the same as the library/branch from Step 1. 4) Go to the Holds to Pull List 5) Filter the branches by "Branch A". 6) You should only see the hold from Step 1 - not Step 3. 7) Try filtering on a branch for a hold that has multiple libraries/branches. (They shouldn't appear when filtering, except when using the "None" filter). Apply the patch. After applying: 1) Repeat Steps 4-7 from above. When filtering on "Branch A", you should be able to see all holds that are available at "Branch A", even if they are available at other branches (i.e. the holds has multiple libraries listed). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12088 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27609&action=edit [PASSED QA] Bug 12127 - Incorrect DataTable types in Holds to Pull list This patch explicitly sets the sType in the Holds to Pull list table for the libraries, itypes, and locations columns. It appears that the type is automatically being set to "html" when it should be set to "string". It needs to have a sType of "string", since DataTables will strip out the <br> tags when using "html", and we need them for the regexp we use to create a more precise filter search. _TEST PLAN_ Before applying: 1) Place a "next available" hold on a record with an item available from one library/branch (e.g. "Branch A") 2) Place a "next available" hold on a record with an item available from two different libraries/branches 3) Place a "next available" hold on a record with an item available from three different libraries/branches - one of which is the same as the library/branch from Step 1. 4) Go to the Holds to Pull List 5) Filter the branches by "Branch A". 6) You should only see the hold from Step 1 - not Step 3. 7) Try filtering on a branch for a hold that has multiple libraries/branches. (They shouldn't appear when filtering, except when using the "None" filter). Apply the patch. After applying: 1) Repeat Steps 4-7 from above. When filtering on "Branch A", you should be able to see all holds that are available at "Branch A", even if they are available at other branches (i.e. the holds has multiple libraries listed). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27481|0 |1 is obsolete| | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- It would be nice if this patch used classes right from the start, but it's still better than having a bug! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Kyle M Hall from comment #4)
It would be nice if this patch used classes right from the start
My patch for Bug 12088 corrects this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12127 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, David! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org