[Bug 34529] New: Offline circulation should be able to accept userid as well as cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Bug ID: 34529 Summary: Offline circulation should be able to accept userid as well as cardnumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 154403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154403&action=edit Bug 34529: Offline circulation should be able to accept userid as well as cardnumber Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ). Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the test.koc file attached to this bug 4) Verify you have an item with the barcode 39999000001396 create it if needed 5) Set a patron's username to "hacevedo" 6) Upload and import the test.koc file into offline circ 7) Verify the item was checked out and the payment was made -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 154411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154411&action=edit test.koc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154403|0 |1 is obsolete| | --- Comment #3 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 155969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155969&action=edit Bug 34529: Offline circulation should be able to accept userid as well as cardnumber Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ). Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the test.koc file attached to this bug 4) Verify you have an item with the barcode 39999000001396 create it if needed 5) Set a patron's username to "hacevedo" 6) Upload and import the test.koc file into offline circ 7) Verify the item was checked out and the payment was made -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155969|0 |1 is obsolete| | --- Comment #4 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 155970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155970&action=edit Bug 34529: Offline circulation should be able to accept userid as well as cardnumber Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ). Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the test.koc file attached to this bug 4) Verify you have an item with the barcode 39999000001396 create it if needed 5) Set a patron's username to "hacevedo" 6) Upload and import the test.koc file into offline circ 7) Verify the item was checked out and the payment was made Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de --- Comment #5 from Philip Orr <philip.orr@lmscloud.de> --- oops, forgot to signoff before attaching. Sorry! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155970|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158140&action=edit Bug 34529: Offline circulation should be able to accept userid as well as cardnumber Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ). Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the test.koc file attached to this bug 4) Verify you have an item with the barcode 39999000001396 create it if needed 5) Set a patron's username to "hacevedo" 6) Upload and import the test.koc file into offline circ 7) Verify the item was checked out and the payment was made Signed-off-by: Philip Orr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158141&action=edit Bug 34529: (QA follow-up) Update column heading to "Card number or username" Updates the column heading on the table of uploaded transactions to read "Card number or username". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, this looks good so far, but we are missing unit tests for the changes in Circulation. Please also check my small follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158140|0 |1 is obsolete| | Attachment #158141|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158321&action=edit Bug 34529: Offline circulation should be able to accept userid as well as cardnumber Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ). Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the test.koc file attached to this bug 4) Verify you have an item with the barcode 39999000001396 create it if needed 5) Set a patron's username to "hacevedo" 6) Upload and import the test.koc file into offline circ 7) Verify the item was checked out and the payment was made Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158322&action=edit Bug 34529: (QA follow-up) Update column heading to "Card number or username" Updates the column heading on the table of uploaded transactions to read "Card number or username". Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158323&action=edit Bug 34529: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 158324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158324&action=edit Bug 34529: (QA follow-up) Tidy OfflineCirculation.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158321|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158380&action=edit Bug 34529: Offline circulation should be able to accept userid as well as cardnumber Like everywhere else in Koha, offline circulation should be able to use userid as well as cardnumber to look up the patron for a transaction ( checkouts and fine payments ). Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the test.koc file attached to this bug 4) Verify you have an item with the barcode 39999000001396 create it if needed 5) Set a patron's username to "hacevedo" 6) Upload and import the test.koc file into offline circ 7) Verify the item was checked out and the payment was made Signed-off-by: Philip Orr <philip.orr@lmscloud.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158322|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158381&action=edit Bug 34529: (QA follow-up) Update column heading to "Card number or username" Updates the column heading on the table of uploaded transactions to read "Card number or username". Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158323|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158382&action=edit Bug 34529: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158324|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158383&action=edit Bug 34529: (QA follow-up) Tidy OfflineCirculation.t Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34529 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Needs documenting --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org