https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35241 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158280&action=edit Bug 35241: Fix markup errors in point of sale template This patch makes several markup corrections to the Point of Sale page, fixing duplicate ids, invalid "selected" attributes*, a broken comment tag, and an invalid "href" attribute. * The "selected" attribute in this template is on a disabled <option>, so it can't be selected. The patch also changes <div class="action"> to <fieldset class="action"> for consistency and better layout. It makes some changes to the "Payment received" dialog in order to improve visual consistency. To test, apply the patch and make sure the EnablePointOfSale preference is turned on. - Go to Point of Sale. - Test the process of adding items for purchase and collecting payment. - After you submit the payment the confirmation dialog should look correct, and the "Print" and "Email" buttons should both work correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35241 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158280|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 158285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158285&action=edit Bug 35241: Fix markup errors in point of sale template This patch makes several markup corrections to the Point of Sale page, fixing duplicate ids, invalid "selected" attributes*, a broken comment tag, and an invalid "href" attribute. * The "selected" attribute in this template is on a disabled <option>, so it can't be selected. The patch also changes <div class="action"> to <fieldset class="action"> for consistency and better layout. It makes some changes to the "Payment received" dialog in order to improve visual consistency. To test, apply the patch and make sure the EnablePointOfSale preference is turned on. - Go to Point of Sale. - Test the process of adding items for purchase and collecting payment. - After you submit the payment the confirmation dialog should look correct, and the "Print" and "Email" buttons should both work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35241 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158285|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158394&action=edit Bug 35241: Fix markup errors in point of sale template This patch makes several markup corrections to the Point of Sale page, fixing duplicate ids, invalid "selected" attributes*, a broken comment tag, and an invalid "href" attribute. * The "selected" attribute in this template is on a disabled <option>, so it can't be selected. The patch also changes <div class="action"> to <fieldset class="action"> for consistency and better layout. It makes some changes to the "Payment received" dialog in order to improve visual consistency. To test, apply the patch and make sure the EnablePointOfSale preference is turned on. - Go to Point of Sale. - Test the process of adding items for purchase and collecting payment. - After you submit the payment the confirmation dialog should look correct, and the "Print" and "Email" buttons should both work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35241 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.