[Bug 33910] New: Improve translation of title tags: Authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 Bug ID: 33910 Summary: Improve translation of title tags: Authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 33906 This patch will modify authorities templates so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33906 [Bug 33906] [OMNIBUS] Improve translation of title tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152124&action=edit Bug 33910: Improve translation of title tags: Authorities This patch updates authorities templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following authorities pages have the correct title tags: - Authorities -> Authorities home page - Authority search results - Authority details - Edit authority - Merge authorities - Cataloging -> New or edit record - Trigger the authority search plugin on a field which is linked to an authority type. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152124|0 |1 is obsolete| | --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 152125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152125&action=edit Bug 33910: Improve translation of title tags: Authorities This patch updates authorities templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following authorities pages have the correct title tags: - Authorities -> Authorities home page - Authority search results - Authority details - Edit authority - Merge authorities - Cataloging -> New or edit record - Trigger the authority search plugin on a field which is linked to an authority type. Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152125|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 154812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154812&action=edit Bug 33910: Improve translation of title tags: Authorities This patch updates authorities templates so that title tags can be more easily translated. To test, apply the patch and confirm that the following authorities pages have the correct title tags: - Authorities -> Authorities home page - Authority search results - Authority details - Edit authority - Merge authorities - Cataloging -> New or edit record - Trigger the authority search plugin on a field which is linked to an authority type. Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Only one little question, why the USE raw? --- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt @@ -1,7 +1,12 @@ [% USE To %] +[% USE raw %] +[% PROCESS 'i18n.inc' %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #4)
Only one little question, why the USE raw?
+[% USE raw %] +[% PROCESS 'i18n.inc' %]
Just a copy-paste error I think -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #5)
(In reply to Katrin Fischer from comment #4)
Only one little question, why the USE raw?
+[% USE raw %] +[% PROCESS 'i18n.inc' %]
Just a copy-paste error I think
Could you provide a quick follow-up to remove that line? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 154848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154848&action=edit Bug 33910: (follow-up) Remove mistaken addition of 'USE raw' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- I choose to not backport to stable to avoid too much translation work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33910 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org