[Bug 33912] New: Improve translation of title tags: Cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 Bug ID: 33912 Summary: Improve translation of title tags: Cataloging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 33906 This patch will modify cataloging templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33906 [Bug 33906] [OMNIBUS] Improve translation of title tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152284&action=edit Bug 33912: Improve translation of title tags: Cataloging This patch updates cataloging templates, including cataloging "value builder" plugins, so that title tags can be more easily translated. To test, apply the patch and confirm that the following cataloging pages have the correct title tags: - Cataloging home page - Catalog concerns - Cataloging search results - Select two results -> - Merge selected - Basic MARC editor (Add, edit) - Replace via Z39.50 - Advanced MARC editor - Item editor - Bibliographic detail page -> - Edit -> - Attach item - Edit -> - Link to host record (with EasyAnalytics enabled) - Authorities -> New from Z39.50/SRU The patch updates 81 different cataloging plugins. It's not necessary to configure your MARC framework to use any particular plugin. The plugins can be loaded in their own tab for the purpose of testing just the title. I've made a list of direct links here: https://gitlab.com/-/snippets/2555254 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Will this affect the way they are presented to translators? I verified that the unimarc plugins still have the same title they had before, but in a great many instances that title is completely wrong. Right now, in https://git.koha-community.org/Koha-community/Koha/src/commit/88000fbccbcfe7... translators apparently deal with the thirteen bogus plugins that all use the title "Framework plugin example › Cataloguing › Koha" with one translation, but if doing this will require that they translate it thirteen separate times, then this bug ought to depend on one for fixing those titles (and another for fixing the way that we have templates for unimarc_field_123d.tt, unimarc_field_123e.tt, unimarc_field_123f.tt, and unimarc_field_123g.tt, but the plugins for all four just use the unimarc_field_123g.tt template so the strings for d/e/f are unused). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Identical strings are still "grouped" into one translation, there should be no negative effects. What it will do is breaking things into individual strings, so "Koha" "Cataloguing" and the specific page descriptions are different strings. This will actually reduce the amount of typing/work needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152284|0 |1 is obsolete| | --- Comment #4 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 152653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152653&action=edit Bug 33912: Improve translation of title tags: Cataloging This patch updates cataloging templates, including cataloging "value builder" plugins, so that title tags can be more easily translated. To test, apply the patch and confirm that the following cataloging pages have the correct title tags: - Cataloging home page - Catalog concerns - Cataloging search results - Select two results -> - Merge selected - Basic MARC editor (Add, edit) - Replace via Z39.50 - Advanced MARC editor - Item editor - Bibliographic detail page -> - Edit -> - Attach item - Edit -> - Link to host record (with EasyAnalytics enabled) - Authorities -> New from Z39.50/SRU The patch updates 81 different cataloging plugins. It's not necessary to configure your MARC framework to use any particular plugin. The plugins can be loaded in their own tab for the purpose of testing just the title. I've made a list of direct links here: https://gitlab.com/-/snippets/2555254 Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Signed Off |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- On /cataloguing/addbooks.pl there is an extra '>' at the beginning of the title. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 153173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153173&action=edit Bug 33912: (follow-up) Correct case where a search has not been submited The former cataloging home page, addbooks.pl, shows an extra ">" in the title if a search has not been submitted. This patch corrects it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- You have added [% USE raw %] when it was not needed, but not blocker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152653|0 |1 is obsolete| | Attachment #153173|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155083&action=edit Bug 33912: Improve translation of title tags: Cataloging This patch updates cataloging templates, including cataloging "value builder" plugins, so that title tags can be more easily translated. To test, apply the patch and confirm that the following cataloging pages have the correct title tags: - Cataloging home page - Catalog concerns - Cataloging search results - Select two results -> - Merge selected - Basic MARC editor (Add, edit) - Replace via Z39.50 - Advanced MARC editor - Item editor - Bibliographic detail page -> - Edit -> - Attach item - Edit -> - Link to host record (with EasyAnalytics enabled) - Authorities -> New from Z39.50/SRU The patch updates 81 different cataloging plugins. It's not necessary to configure your MARC framework to use any particular plugin. The plugins can be loaded in their own tab for the purpose of testing just the title. I've made a list of direct links here: https://gitlab.com/-/snippets/2555254 Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 155084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155084&action=edit Bug 33912: (follow-up) Correct case where a search has not been submited The former cataloging home page, addbooks.pl, shows an extra ">" in the title if a search has not been submitted. This patch corrects it. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33912 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org