[Bug 38981] New: Local cover images failing to load in OPAC search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Bug ID: 38981 Summary: Local cover images failing to load in OPAC search results Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org It looks like bug 26933 might've broke OPAC local cover images in the search results due to a possible race condition. In koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt around line 630 there is a window.load() call which runs 'wait_for_images(verify_cover_images)'. If you're only using OPACLocalCoverImages, there is no wait, so verify_cover_images() is called immediately. That function removes the .cover-image element if there are no images. In the case of OPACLocalCoverImages, there are no images yet, so the element gets removed. Now there are no images yet because 'KOHA.LocalCover.GetCoverFromBibnumber(false);', the function which populates the local cover image elements, hasn't even run yet. Note that it's called within a $(document).ready() which is written lower than the window.load() It's possible that different configurations would yield different results, if they load different resources at different times, which could affect when the handlers run. I've observed the above when using a fairly vanilla koha-testing-docker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38963 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt 555 // if( $(coverSlide).find(".cover-image").length < 1 ){ 556 // $(coverSlide).remove(); 557 // } else { 558 // This is a suboptimal workaround; we should do this via load, but 559 // the image code is scattered all over now. We come here now after 560 // window load and wait_for_images (so load completed). 561 var check_complete = 1; 562 $(coverSlide).find("img").each( function() { 563 if( !this.complete || this.naturalHeight == 0 ) check_complete = 0; 564 }); 565 if( check_complete ) $(coverSlide).removeClass('cover-slides'); 566 // } Why are those lines commented? It works (at first glance) if I bring them back. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CONFIRMED CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Petr Brož <petr.broz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |petr.broz@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 verolencinas <verolencinas@yahoo.com.ar> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |verolencinas@yahoo.com.ar -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 John Yorio <jyorio@equinoxinitiative.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jyorio@equinoxinitiative.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #1)
Why are those lines commented?
It works (at first glance) if I bring them back.
I've been curious about this as well. Wondering if Owen has any insight into this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CONFIRMED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 179170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179170&action=edit Bug 38981: Local cover images failing to load in OPAC search results This patch uncomments some code which was incorrectly left commented after debugging. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lucas@bywatersolutions.com --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- In Chrome with this patch it works good. In Firefox, it works about 1/10 times I load the results page. Is there some kind of race condition that Firefox is slower at that is causing this not to work there? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass (lukeg) from comment #4)
In Chrome with this patch it works good. In Firefox, it works about 1/10 times I load the results page.
Is there some kind of race condition that Firefox is slower at that is causing this not to work there?
That could be. My initial observations were around some weird interplay between window.load and $(document).ready() working a bit differently than I would've expected... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to David Cook from comment #5)
(In reply to Lucas Gass (lukeg) from comment #4)
In Chrome with this patch it works good. In Firefox, it works about 1/10 times I load the results page.
Is there some kind of race condition that Firefox is slower at that is causing this not to work there?
That could be. My initial observations were around some weird interplay between window.load and $(document).ready() working a bit differently than I would've expected...
Using window.load is correct here, we need to wait for the images to be loaded. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- We have fixed this problem on the staff interface long ago. The use of GetCoverFromBibnumber is problematic (and it's also why shelfbrowser is broken, see bug 31207) We should pass the image numbers to the template, the same way we do for opac-detail 60 [% IF ( OPACLocalCoverImages ) %] 61 [% IF localimages.count %] 62 [% FOREACH image IN localimages %] 63 <div class="cover-image local-coverimg"> 64 <a href="/cgi-bin/koha/opac-image.pl?imagenumber=[% image.imagenumber | uri %]" title="Local cover image"> 65 <img 66 src="/cgi-bin/koha/opac-image.pl?thumbnail=1&imagenumber=[% image.imagenumber | uri %]" 67 alt="Local cover image" 68 data-link="/cgi-bin/koha/opac-imageviewer.pl?biblionumber=[% biblionumber | uri %]&imagenumber=[% image.imagenumber | uri %]" 69 /> 70 </a> 71 <div class="hint">Local cover image</div> 72 </div> 73 [% END %] 74 [% END %] 75 [% END %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #7)
We have fixed this problem on the staff interface long ago.
Bug 25031: Improve handling of multiple covers on the biblio detail page in the staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179210&action=edit Bug 38981: Directly use the opac-image link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Why not... simply linking to the opac-image url?... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #10)
Why not... simply linking to the opac-image url?...
I've been wondering that too. Did you test it? I wonder if it has to do with the lightbox being used? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179170|0 |1 is obsolete| | --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 179431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179431&action=edit Bug 38981: Local cover images failing to load in OPAC search results This patch uncomments some code which was incorrectly left commented after debugging. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179210|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 179432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179432&action=edit Bug 38981: Directly use the opac-image link Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 --- Comment #14 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Enable the OPACLocalCoverImages and AllowMultipleCovers system preferences. 2. Add some cover images to a couple of records. 3. Add multiple cover images for one record. 4. Use two different browsers (Firefox and a Chromium-based browser) and in the OPAC run a search that returns records with the cover images. 5. Note that: - For Firefox: there are no local cover images shown in the search results, but they are displayed on the record details page - For Chromium-based browsers: things work as expected - local cover images are shown in the search results and the record details page 6. Apply the patch. 7. Repeat step 4. 8. Note that Firefox and Chromium browsers both now work as expected - local cover images are correctly shown in the OPAC search results and details pages. Note: The OPAC search results only show one local cover image, even with AllowMultipleCovers enabled. Multiple covers are viewable on the details page in the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179431|0 |1 is obsolete| | --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179560&action=edit Bug 38981: Local cover images failing to load in OPAC search results This patch uncomments some code which was incorrectly left commented after debugging. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179432|0 |1 is obsolete| | --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179561&action=edit Bug 38981: Directly use the opac-image link Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patchset fixes a release notes| |problem where local cover | |images were not properly | |loading on the OPAC results | |page. With this fix local | |covers now load correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 --- Comment #17 from David Cook <dcook@prosentient.com.au> --- Thanks a lot, Lucas! I've been meaning to come back to this, but just haven't had the time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #20 from Jesse Maseto <jesse@bywatersolutions.com> --- Merge conflicts with 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #21 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38981 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #22 from David Nind <david@davidnind.com> --- Bug fix, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org