[Bug 41364] New: Error in preservation module breadcrumb
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Bug ID: 41364 Summary: Error in preservation module breadcrumb Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Preservation Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com The breadcrumb has an empty element (where 'Processings' should show), and the browser console shows this warning: ``` [Vue Router warn]: No match found for location with path "/cgi-bin/koha/preservation/settings/processings" devtools-BLCumUwL.mjs:59:1 ``` This also fails: ```shell $ ktd --shell k$ run_cypress --spec t/cypress/integration/Preservation/Settings.ts ``` -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |ASSIGNED CC| |lucas@bywatersolutions.com, | |martin.renvoize@openfifth.c | |o.uk, tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 190122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190122&action=edit Bug 41364: Fix error in preservation module breadcrumb This patch makes the 'Processings' breadcrum element not be tied to a component but a plain string with the link disabled. This was causing errors: - Breadcrumb element empty - Error in the browser console To test: 1. Enable the Preservation module 2. Go to Home > Preservation > Settings 3. Use the 'Add a new processing' button => FAIL: The breadcrumb has 'Settings > > Add processing' (i.e. is missing 'Processings' between >) 4. Click on 'Edit this processing' => FAIL: Same error, different context 5. Check the browser console => FAIL: You see something like this: ``` [Vue Router warn]: No match found for location with path "/cgi-bin/koha/preservation/settings/processings" devtools-BLCumUwL.mjs:59:1 ``` 6. Run the cypress tests for this module: k$ run_cypress --spec t/cypress/integration/Preservation/Settings.ts => FAIL: The breadcrumb navigation is broken 7. Apply this patch 8. Rebuild things: $ ktd --shell k$ yarn build 9. Fully refresh the page (Use cmd+shift+r on macOS, ctrl+shift+r on Linux/Windows) 10. Repeat 2-6 => SUCCESS: The breadcrumb is no longer broken => SUCCESS: No errors/warnings about this in the browser console => SUCCESS: Tests pass! 11. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190122|0 |1 is obsolete| | --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 190124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190124&action=edit Bug 41364: Fix error in preservation module breadcrumb This patch makes the 'Processings' breadcrum element not be tied to a component but a plain string with the link disabled. This was causing errors: - Breadcrumb element empty - Error in the browser console To test: 1. Enable the Preservation module 2. Go to Home > Preservation > Settings 3. Use the 'Add a new processing' button => FAIL: The breadcrumb has 'Settings > > Add processing' (i.e. is missing 'Processings' between >) 4. Click on 'Edit this processing' => FAIL: Same error, different context 5. Check the browser console => FAIL: You see something like this: ``` [Vue Router warn]: No match found for location with path "/cgi-bin/koha/preservation/settings/processings" devtools-BLCumUwL.mjs:59:1 ``` 6. Run the cypress tests for this module: k$ run_cypress --spec t/cypress/integration/Preservation/Settings.ts => FAIL: The breadcrumb navigation is broken 7. Apply this patch 8. Rebuild things: $ ktd --shell k$ yarn build 9. Fully refresh the page (Use cmd+shift+r on macOS, ctrl+shift+r on Linux/Windows) 10. Repeat 2-6 => SUCCESS: The breadcrumb is no longer broken => SUCCESS: No errors/warnings about this in the browser console => SUCCESS: Tests pass! 11. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190124|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 190132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190132&action=edit Bug 41364: Fix error in preservation module breadcrumb This patch makes the 'Processings' breadcrum element not be tied to a component but a plain string with the link disabled. This was causing errors: - Breadcrumb element empty - Error in the browser console To test: 1. Enable the Preservation module 2. Go to Home > Preservation > Settings 3. Use the 'Add a new processing' button => FAIL: The breadcrumb has 'Settings > > Add processing' (i.e. is missing 'Processings' between >) 4. Click on 'Edit this processing' => FAIL: Same error, different context 5. Check the browser console => FAIL: You see something like this: ``` [Vue Router warn]: No match found for location with path "/cgi-bin/koha/preservation/settings/processings" devtools-BLCumUwL.mjs:59:1 ``` 6. Run the cypress tests for this module: k$ run_cypress --spec t/cypress/integration/Preservation/Settings.ts => FAIL: The breadcrumb navigation is broken 7. Apply this patch 8. Rebuild things: $ ktd --shell k$ yarn build 9. Fully refresh the page (Use cmd+shift+r on macOS, ctrl+shift+r on Linux/Windows) 10. Repeat 2-6 => SUCCESS: The breadcrumb is no longer broken => SUCCESS: No errors/warnings about this in the browser console => SUCCESS: Tests pass! 11. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41336 CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Added my sign-off in case it helps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to David Nind from comment #4)
Added my sign-off in case it helps.
It helps. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41372 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 41372 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 190147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190147&action=edit Bug 41364: Fix error in preservation module breadcrumb This patch makes the 'Processings' breadcrum element not be tied to a component but a plain string with the link disabled. This was causing errors: - Breadcrumb element empty - Error in the browser console To test: 1. Enable the Preservation module 2. Go to Home > Preservation > Settings 3. Use the 'Add a new processing' button => FAIL: The breadcrumb has 'Settings > > Add processing' (i.e. is missing 'Processings' between >) 4. Click on 'Edit this processing' => FAIL: Same error, different context 5. Check the browser console => FAIL: You see something like this: ``` [Vue Router warn]: No match found for location with path "/cgi-bin/koha/preservation/settings/processings" devtools-BLCumUwL.mjs:59:1 ``` 6. Run the cypress tests for this module: k$ run_cypress --spec t/cypress/integration/Preservation/Settings.ts => FAIL: The breadcrumb navigation is broken 7. Apply this patch 8. Rebuild things: $ ktd --shell k$ yarn build 9. Fully refresh the page (Use cmd+shift+r on macOS, ctrl+shift+r on Linux/Windows) 10. Repeat 2-6 => SUCCESS: The breadcrumb is no longer broken => SUCCESS: No errors/warnings about this in the browser console => SUCCESS: Tests pass! 11. Sign off :-D Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190132|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Pushed to main for 25.11.00. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Keywords|rel_25_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00, 25.05.00 released in| | Status|Pushed to main |Needs documenting --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This change has been backported to the 25.05.x branch. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00, 25.05.00 |25.11.00,25.05.07,24.11.12 released in| | Status|Needs documenting |Pushed to oldoldstable CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41364 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #12 from David Nind <david@davidnind.com> --- Bug fix, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org