https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58657&action=edit Bug 17855- In web installer step 3, automatically selected default data values are successfully being inserted into the database. These default data values are now displayed in step 3 with bulletpoints Bug 17855- Removed loop in web installer forcing users to update their database version. Changed default data values in web installer to be displayed with disabled selected checkboxes rather than bulletpoints The web installer step 3 now has disabled selected checkboxes. Bug 17855- Implemented automatic selection of all default data in web installer which are shown with non-editable bulletpoints Altered web installer Moved files from optional to mandatory. Edited MARC screen so that MARC21 is selected by default. Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt Changed mandatory in If statement to default for MARC flavours Changed the radiobuttons to bulletpoints for default settings Changed a few file name descriptions to reduce spacing in installer step 3 screen. removed = sign:wq Fixed bug in installer where a loop was created if you're database structure needed to be updated. Redirected this to the marcflavour screen instead of logging straight into Koha and skipping over the basic configuration steps. Changed the bulletpoints to disabled checkboxes which are checked by default Backup of step3.tt Successfully working insertion of the default options which are shown as bulletpoints -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58659&action=edit Bug 17855 - Implemented basic and advanced setup modes in the web installer avalable on the MARC flavour selection page of step 3. The two setup modes change how the data installation page of step 3 looks: Basic setup displays all default data values with bulletpoints, and optional data values with a checkbox. Advanced setup displays default and optional data values with a checkbox. Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58661&action=edit Bug 17855 - Create library, patron category, and item type backends working successfully inserting into the database. Dropdown boxes of create circulation rule screen are now populated with values. Patron and circulation rule not yet inserting into the database. Bug 17855 - Checking if library, patron category, and item type have already been inserted into the database and if they have then the step to create them in the onboarding tool is skipped. Create a patron onboarding page now has populated dropdown boxes. Successful insertion of library and patron category from onboarding.pl (onboarding tool). Patron, item type and circulation rule not yet inserting into the database from onboarding.pl (onboarding tool). Bug 17855 - Fixed merge conflict in onboardstep0.tt. Library and patron category are being successfully inserted into the database from onboarding.pl, same as the previous patch. Bug 17855 - Finished front end of onboarding tool. Initial two screens of onboarding tool also have successful insertion into the database. Successfully working backend of create library and patron category pages. Thus library and patron cataegory are being inserted into the database from the onboarding.pl script Working front end of the onboarding tool with the correct button names and header names. And finished web installer Increased font size in summary page Working backend of the create library. With a check to determine if the library already exists before allowing the user to create a library. With finished web installer Created backend of patron category. Moved files around from default to optional for configuration settings. Fixed merge commit with onboardstep0.tt file Working library, and patron category checks and inserts into the koha database in the koha onboarding tool Working checks on the library, patron category, and item type with working library and patron category insertion to the database Drop downs are correctly showing existing information when creating a new patron. Still working on backend to add the patron to the database. Item type backend created and working as expected. Added drop down boxes in create circulation rule. Working on creating a circulation rule. Not yet complete. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58663&action=edit Bug 17855 - Similar to the previous patch Have fixed the incorrect insertion of patron into the database Test plan: 1. Go through the web installer and onboarding tool as outlined here: https://koha-community.org/manual/installation/html/ 2. Check the database to see that the library, patron category, patron, and item type are now being inserted successfully. bug 17855 - Similar to the previous patch, except perl code to prevent card number duplication is in the process of beign added to step 3 in the onboarding.pl script. Same test plan as previous patch Bug 17855 - Similar to the previous patch. Library, patron category, patron (with superlibrarian permissions) and item type are all being inserted from the onboarding.pl script into the database. Removed the error that was being displayed after the first of the two create circulation rule screens. Test plan 1. Run through the web installer and onboarding tool as outlined in: https://koha-community.org/manual/installation/html/ 2. Notice there is no error after the first of the two create circulation rule screens. 3. Check the database and you should see the library, patron category, patron, and item type have been inserted. Bug 17855 - Refined text inputs to numerical inputs in onboarding tool. Set minimum card number allowed to 1 for creating a patron screen. In addition to displaying patron category descriptions instead of codes in the dropdown boxes of the aforementioned screen. Implemented months and date check in the create patron category screen. Bug 17855 - Similar to the previous patch except for additional perl code for step 5 (create circulation rule) in the onboarding.pl script Months or dates check implemented in the create patron category screen 1 Changed patron category codes to descriptions in create a new patron Trying to fix default_privacy error Updated text input fields to transform text to capitalize or upper case as appropriate. Changed input fields to number rather than text where appropriate, minimum set to 0 Same as previous. Changed minimum to 1 for card number Working insertion of the item types with working dropdown boxes in the circulation rules screen Changed text to number input type Error no longer showing after the first create circulation rule screen. The patron is also being inserted to the database correctly with the superlibrarian privilages. Working on preventing card number duplication fixed minor error where i was incorrectly inserted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58665&action=edit Bug 17855 - The 'All' dropdown box option is working for patron categories, item types, and libraries for the create circulation rule screen of the onboarding tool. Test plan: 1. Go through the web installer and the onboarding tool (up to the point of creating a circulation rule in the onboarding tool) as outlined here: https://koha-community.org/manual/installation/html/ 2. When creating a circulation rule using the onboarding tool apply it to all patron categories, libraries and item types by leaving the default 'All' option in the respective dropdown boxes selected. 3.Having finished the onboarding tool log into the staff interface and go to Checkouts 4. Check out 2 items (of differing item types, e.g. book and cd) to 2 different patrons (these patrons need to be of different patron types to test the circulation rule properly), in two two different libraries 5. Notice that the due date for all the checkouts is the same. This is because the 'All' dropdown option is successfully applying the circulation rule to all libraries, item types, and patron categories as intended. Bug 17855 - 'All' option is working to select for a circulation rule to apply to all patron categories. Tested where there were two circulation rules; 'All, Books' as 5 days and 'All, Computer Files' as 2 days. Checked out each to 5 different types of borrowers, due date reflects the specified loan period. Test plan: 1. Go through the web installer and the onboarding tool (up to the point of creating a circulation rule in the onboarding tool) as outlined here: https://koha-community.org/manual/installation/html/ 2. When creating a circulation rule using the onboarding tool apply it to all patron categories by leaving the default 'All' option in the Patron categories dropdown box selected. 3.Having finished the onboarding tool log into the staff interface and go to Checkouts 4. Check out an item (this item must be the same item type that you applied the aforementioned circulation rule to) to 2 different patrons (these patrons need to be of different patron types to test the circulation rule properly). 5. Notice that the due date is the same for both patrons. This is because the 'All' dropdown button for patron categories in the onboarding tool is successfully applying the circulation rule to all patron categories. Bug 17855 - Working login of the web installer and onboarding tool Test plan: 1. Go through the web installer and onboarding tool as outlined here: https://koha-community.org/manual/installation/html/ 2. Notice that the you can login after the onboarding tool in order to access the Koha main page Item type 'All' choice now working also. Tested same as previous. Library 'All' option now working for circulation rule, though more testing is needed. Cleaned up some other text and added a description to Create a Patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #11 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58667&action=edit Bug 17855 - Tidied up the blank spaces and unnecessary comments in the onboarding.pl script Test plan: 1. Go through the web installer and onboarding tool as outlined here: https://koha-community.org/manual/installation/html/ 2. After finishing the onboarding tool login using the patron credentials of the patron you just created using the onboarding tool 3. Check you can create a library, patron category, item type, patron category, and circulation rule using the patron account you are currently logged in with Bug 17855 - Same as the previous patch Test plan: 1. Go through the web installer and onboarding tool as outlined here: https://koha-community.org/manual/installation/html/ 2. Test the password and card number check and error display in the create patron screen of the onboarding tool by entering in different passwords in the two password fields and/or entering an existing password (which will only work if you installed sample patrons in the web installer). When you do this and submit the form errors should appear and you should be able to select the 'try again' button to get back to the first create patron screen. 3. After finishing the onboarding tool check the following tables of the database, they should all have records in them: branches, categories, borrowers, itemtypes and issuingrules Bug 17855 - Similar to previous patch All fields of the onboarding tool have been tested and they are all inserting correctly into the database Test plan: 1. Go through the web installer and onboarding tool as outlined here: https://koha-community.org/manual/installation/html/ 2. After finishing the onboarding tool write in the username and password of the patron you created using the onboarding tool, into the login page 3. Check your user has superlibrarian privilages by going to: 'Patron'-> click on the first letter of your logged in patron surname->'More'->'Set Permissions' You should see the patron has superlibrarian privilages. 4. Search in the database to make sure: *The library you created is in the borrowers table. *The patron category is in the categories table *The item type is in the itemtypes table *The circulation rule is in the issuingrules table Error messages working correctly and all objects being inserted correctly Start of onboarding.pl code tidied up -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #13 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58669&action=edit Finished initial web installer and onboarding tool -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58657|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58659|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58661|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #17 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Alex Buckley from comment #16)

M. Tompsett. Thank you of informing me of this.

I have now gone through and obsoleted older patches including the patch that was causing the failure.

So try seeing if it will apply for you now.

Still fails. I'm thinking you are patching an old version of master. You may need to rebase. $ git checkout master $ git pull $ git checkout -b bug_17855_retest1 origin/master $ git bz apply 17855 -- This should fail. $ git bz apply --abort $ git checkout bug_17855 -- probably discover your are out some changes, not just these. -- I'm assuming you generally name your branches bug_#####. $ git rebase origin/master $ git bz attach -e HEAD^^^^^^^^..HEAD -- there are 8 ^'s. That should get all your patches. $ git checkout bug_17855_retest1 -- probably some messages about being out of sync, doesn't matter. $ git reset --hard origin/master $ git bz apply 17855 -- hopefully this will work now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58662|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58664|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58666|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58668|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #19 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58781&action=edit Bug 17855 - Finished updated web installer (basic and advanced setup modes have not yet been implemented). Bulletpoints are now being displayed for all default data values in both the UNIMARC and MARC21 setups. Test plan: 1. Go through the web installer as outlined in this guide: https://koha-community.org/manual/installation/html/ Note: The basic and advanced setup modes on the MARC falvour selection page have not yet been implemented. Notice during your testing: The default data values for both the UNIMARC and MARC21 are displayed with bulletpoints whilst the optional data values are displayed with checkboxes. Bug 17855 - Initial updated web installer implemented with mandatory data values moved to the default folder and changed the checkbox display to bulletpoints for the default data values. Test plan: 1. Go through the web installer up to step 3, as outlined in this guide: https://koha-community.org/manual/installation/html/ Notice in web installer step that the header "mandatory" has been replaced with "default". These default data values are displayed with bulletpoints rather than checkboxes. Changed a few file name descriptions to reduce spacing in installer step 3 screen. removed = sign:wq Fixed bug in installer where a loop was created if you're database structure needed to be updated. Redirected this to the marcflavour screen instead of logging straight into Koha and skipping over the basic configuration steps. Changed the bulletpoints to disabled checkboxes which are checked by default Backup of step3.tt Successfully working insertion of the default options which are shown as bulletpoints Working insertion of default and optional options -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #21 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58783&action=edit Correctly selected default marc flavour of marc21 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #22 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58784&action=edit Bug 17855-Same as previous Test plan: 1. Go through web installer and onboarding tool as outlined in this guide: https://koha-community.org/manual/installation/html/ This is a combination of 2 commits. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #24 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Alex Buckley from comment #23)

This is a combination of 6 commits.

And it still doesn't apply. I attempted interactively to apply each of the patches individually just to master, and none of them do. I was thinking they are out of order, did you git pull AND git rebase origin/master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #26 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Alex Buckley from comment #25)

Did you get the same 'fatal: sha1 information is lacking or useless' error stopping the patch apply?

$ git checkout -b bug_17855_round2 origin/master $ git pull $ git remote update -p -- now I know this new branch is up to date. -- this is the beginning of a looping block $ git bz apply 17855 ... i -- for interactive -- There are 4 patches, comment out all but the first, the first time. -- Comment out all but the second, the second time. -- Comment out all but the third, the third time. -- Comment out all but the fourth, the fourth time. -- comments are lines beginning with # :wq -- I use vim, so whatever writes and quits is what you want -- now you will see the massive failure to apply $ git bz apply --abort $ git reset --hard origin/master -- loop 4 times from the beginning of the looping block And yes, yes it was. Attempting all four patches individually means I know that you didn't accidentally screw up the order of the patches on this bug, which is way to easy to do. Looking forward to testing something once it applies. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #28 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58792&action=edit bug 17855 - Updated web installer finished Have moved all data values from mandatory to default. Now all default data values are displayed with a bulletpoint rather than a selectable checkbox stopping users from unticking neccisary data values Test plan: 1. Go through the web installer as outlined in this guide: https://koha-community.org/manual/installation/html/ Note: The advanced setup option has not yet been implemented, so what you will see is just the basic setup. Altered web installer Moved files from optional to mandatory. Edited MARC screen so that MARC21 is selected by default. Conflicts: koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt Changed mandatory to default for MARC values Changed a few file name descriptions to reduce spacing in installer step 3 screen. Changed the radiobuttons to bulletpoints for default settings removed = sign:wq Fixed bug in installer where a loop was created if you're database structure needed to be updated. Redirected this to the marcflavour screen instead of logging straight into Koha and skipping over the basic configuration steps. Changed the bulletpoints to disabled checkboxes which are checked by default Backup of step3.tt Successfully working insertion of the default options which are shown as bulletpoints Removed test text Working insertion of default and optional options Correctly selected default marc flavour of marc21 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58784|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58781|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #30 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58794&action=edit Finished initial web installer and onboarding tool -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #32 from M. Tompsett <mtompset@hotmail.com> --- Oh wow! Okay, I didn't understand the coolness of this until I started testing. It's going to take too long to test, and I need sleep, but so far so good. Oh no! Spoke too soon. Seriously?! What is it with programmers taking away my symbols as part of passwords? Sorry, but I experienced this on another website (www.scene.ca) that I use as well, so the issue is a hot spot for me right now. https://www.owasp.org/index.php/Password_special_characters http://www.ibm.com/support/knowledgecenter/SSEQTP_8.5.5/com.ibm.websphere.ba... I can't enter a password for Koha that I have used before. :( -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #35 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to M. Tompsett from comment #32)

Oh wow! Okay, I didn't understand the coolness of this until I started testing. It's going to take too long to test, and I need sleep, but so far so good.

Oh no! Spoke too soon. Seriously?! What is it with programmers taking away my symbols as part of passwords? Sorry, but I experienced this on another website (www.scene.ca) that I use as well, so the issue is a hot spot for me right now.

https://www.owasp.org/index.php/Password_special_characters http://www.ibm.com/support/knowledgecenter/SSEQTP_8.5.5/com.ibm.websphere. base.doc/ae/csec_chars.html

I can't enter a password for Koha that I have used before. :( Mark what? Koha can't possibly know what you old password was. Do you mean you can't enter a password that is already in use? That's way outside the scope of

This must be just a JavaScript regex Alex, I'd drop that part of the check. this then. Please remember too to keep chill when you are dealing with a first time commiter. Or we will never have 2nd time commiters :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #37 from Alex Buckley <alexbuckley@catalyst.net.nz> --- I have gone through and made the changes recommended in comments 33, 34, and 35, and attached the commit (see its name below) to this bug: Bug 17855 - Removed html regex on patron password fields. Ran perltidy to indent and space code appropriately. Ran git bz configuration commands to remove whitespace. Removed unnecissary uses in the summary.pl script I have tested the bug in a clean branch and it applies successfully for me. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #39 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58860&action=edit Bug 17855 - Second update following testing feedback Made arrows in onboarding tool pages -> for consistency. Additionally removed the 'OR' Added the use CGI qw ( -utf8 ); -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #43 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58862&action=edit Bug 17855- Fourth update following testing feedback. Changed button and link names in web installer and onboarding tool -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #45 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58886&action=edit Bug 17855 -Fifth update following tester feedback. Implemented Javascript password check to determine if the values in the 'password' and 'confirm password' fields are consistent. If passwords are not consistent a message informing the user is displayed and they only have to change the password values rather than re-fill out the whole form. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #47 from Alex Buckley <alexbuckley@catalyst.net.nz> --- I removed the userid javascript validation because it is unnecessary, due to the following reasons: *There is already a html required="required" attribute on this input field *And a html regex on this field Therefore javascript validation is not needed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #49 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58892&action=edit Bug 17855 - Fixed the errors from the koha qa test -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #51 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 58894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58894&action=edit Bug 17855 - Removed use:C4/Auth from the onboarding.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58794|0 |1 is obsolete| | --- Comment #53 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 58896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58896&action=edit Finished initial web installer and onboarding tool https://bugs.koha-community.org/show_bug.cgi?id=17855 Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58860|0 |1 is obsolete| | --- Comment #55 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 58898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58898&action=edit Bug 17855 - Second update following testing feedback Made arrows in onboarding tool pages -> for consistency. Additionally removed the 'OR' Added the use CGI qw ( -utf8 ); Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58862|0 |1 is obsolete| | --- Comment #57 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 58900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58900&action=edit Bug 17855- Fourth update following testing feedback. Changed button and link names in web installer and onboarding tool Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58892|0 |1 is obsolete| | --- Comment #59 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 58902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58902&action=edit Bug 17855 - Fixed the errors from the koha qa test Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58902|0 |1 is obsolete| | --- Comment #61 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 58904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58904&action=edit Bug 17855 - Fixed the errors from the koha qa test Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58893|0 |1 is obsolete| | --- Comment #63 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 58893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58893 Bug 17855- Sixth update following testing feedback. Whitespace fixes generate empty patch from my install. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #66 from M. Tompsett <mtompset@hotmail.com> --- Squashed first two patches to solve koha qa test tool issue. Ran basic/advanced unimarc/marc combinations. Looks great. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Patch doesn't apply --- Comment #68 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #69 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ok, fixed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17897 [Bug 17897] Koha::SearchMappingManager - Simplify search mapping modifications -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #71 from Owen Leonard <oleonard@myacpl.org> --- I agree that the inconsistent style is a problem. I wonder if we shouldn't simply include the default staff client CSS in addition to the installer-specific CSS. I think if you have chosen the basic installation the "Select all options" button should be down next to the options which one can select. I don't think there needs to be a "We're just going to set up a few more things..." page. We were told on the previous page that this step was coming. I think the "Add a patron category" stage should make it clear that the category you define is going to be the one which the new administrator patron will have. I think the "Create patron" stage should say something like "Create Koha administrator patron" so that it is very clear that the patron you create will will be a superlibrarian. The "Create patron" stage wouldn't accept the card number I typed in. The validator said it wasn't a number. It would only let me increment the number that was prefilled. The "Create a new Item type" should have some text explaining what an item type is, including the important point that it is what Koha uses to apply circulation rules. Please run all the onboarding steps through an HTML validator. I use this addon in Firefox: http://users.skynet.be/mgueury/mozilla/ Capitalization is all over the place. Only the first letter of heading, label, etc. should be capitalized: https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML4:_Upper_and_lowe... I think this is going to be a really good addition to Koha. It just needs a few fixups! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #73 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Owen Leonard from comment #71)

I think if you have chosen the basic installation the "Select all options" button should be down next to the options which one can select.

How about floating near the top (or bottom) like the save/cancel on... is it the system preference pages?

I don't think there needs to be a "We're just going to set up a few more things..." page. We were told on the previous page that this step was coming.

There is system preference setting code run when that page is displayed. This ties into the notion of advanced would let you skip onboarding completely or particular steps. [SNIP Other great suggestions]

I think this is going to be a really good addition to Koha. It just needs a few fixups!

Which is why I was working really hard on this sign off. I think it is a fantastic idea. :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #75 from Owen Leonard <oleonard@myacpl.org> --- (In reply to M. Tompsett from comment #73)

(In reply to Owen Leonard from comment #71)

...

I think if you have chosen the basic installation the "Select all options" button should be down next to the options which one can select.

How about floating near the top (or bottom) like the save/cancel on... is it the system preference pages?

No, that's not necessary. It's on the page where you select data to import. The "select all" control is only relevant, in this case, to the options which can be checked or unchecked. It should be displayed at the top of that section of the page.

...

I don't think there needs to be a "We're just going to set up a few more things..." page.

There is system preference setting code run when that page is displayed. This ties into the notion of advanced would let you skip onboarding completely or particular steps.

I'm sorry, I don't understand this comment. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #78 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Jonathan Druart in comment 70 and Owen Leonard in comment 71) Today I have gone through and implemented your suggestions in comments 70 and 71. I will attach my commits to this bug tommorow. In the meantime I would like to clarify the onboarding tool a bit: 1. The reason for having the basic and advanced setups is that data values necessary for a fully-functioning Koha instance are selected and displayed with bulletpoints in the Basic setup because the basic setup is recommended for new, inexperienced users and it prevents them from unknowingly unticking an important data values. i.e. the basic setup protects new users from mistakes and lack of knowledge. Whereas the advanced setup (recommended for more experienced Koha users) gives them complete control over what is installed in their Koha database by displaying all data values with selectable checkboxes(as is available in the current web installer in Koha master). 2. I tried linking to the staff-global.css stylesheet on the onboarding tool pages today however it looked worse than the current onboarding tool styling. Therefore I propose leaving the current styling as it is, and then in the future a patch with the singular scope of improving the onboarding tool styling could be implemented. Another reason to leave the onboarding tool with the installer styling is because the onboarding tool is considered part of the installer process. This is shown by the fact the login page is after the onboarding tool rather than the web installer, and the fact both are documented together (https://koha-community.org/manual/installation/html/) separate from the staff interface documentation. Thus the web installer and onboarding tool having the same styling is logical. 3. I do not believe having a button at the end of the web installer to skip the onboarding tool is wise. The onboarding tools purpose is to help users (particularly new users) to get everything set up in their Koha database so they can log in and get straight to work. If you provide a button to skip the onboarding tool then new users may select it, then they will end up logging in as database administrator. If they havent installed optional sample data in the web installer then they will have to spend time creating sample libraries, patron types etc. and so defeating the purpose of having the onboarding tool in the first place. If experienced Koha users want to skip the onboarding tool they could always open Koha in another tab, additionally they are not stuck with what they create in the onboarding tool they can simply modify or delete the onboarding records. Cheers Alex Buckley -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #80 from Chris Cormack <chris@bigballofwax.co.nz> --- For the record, I disagree with hiding the basic/advanced step. It is a good enhancement and will help users. I also disagree with removiing the skip, if we allow users to skip they will end up logging into Koha with the DB user which as we know can cause a lot of problems. For dev companies or experienced users they can just close the tab at that point. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #82 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 59037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59037&action=edit Bug 17855 - Seventh update following testing feedback. 1. Moved the "select all options" button down to just above the selectable options in the basic setup, and positioned at the top of the page for the advanced setup. 2. Removed the "there is nothing to do because the sample data is already installed" page so if the user has install sample data in the web installer then the step to create that object in the onboarding tool is skipped altogether. 3. Removed the "We're just going to setup a few more things" page 4. Changed the title of the 'Create patron page' 5. Added clarifying information to the "Add a patron category" page 6. Added clarifying information to the "Create item type" page 7. Fixed the capitalization in the onboarding tool 8. Removed the BackupStep3.tt file which was un-used 9. Changed the redirect time displayed to user in step3.tt to 10 10. Changed the cardnumber on the create patron administrator page so that it is only populated when the user installed sample patrons. Also changed the regex so that it allows letters and number. 11. Used the HTMl validator to identify errors in the template and have corrected all possible in the onboarding templates. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #85 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Alex Buckley from comment #78)

Therefore I propose leaving the current styling as it is, and then in the future a patch with the singular scope of improving the onboarding tool styling could be implemented.

I have an installer style overhaul in progress, so I will bring it up to date and try to apply it on top of these patches. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #87 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Owen Leonard from comment #86)

I think the regex on the patron card number is creating the side-effect that the form will not accept a card number with a zero in it.

pattern="[A-Za-z1-9 ]+" -- This is a problem for description in onboarding step 4, not just cardnumber is onboarding step 3. pattern="[A-Za-z1-9][A-Za-z0-9 ]*" -- This forces the first character to not be 0 or space, and have at least one character. I think this will work for cardnumber and description. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #89 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe we could be less strict and allow any characters in the cardnumber? Removing accidentally entered whitespace at beginning and end might be enough. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #91 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (in reply to M.Topmsett in comment 90) Yes you are correct that the regex ^[^0\s].* prevents inputting of 0 or a whitespace as the first character of the cardnumber, which is good. However I have tested it on the following website: http://regexr.com/ And that regex will accept special characters as part of the cardnumber, which is obviously not what we want. Also other than this regex issue was there any other reason that my bug was given 'Failed QA'? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #93 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The idea of checking the data entered is good especially for the basic setup, but I think this might make it more complicate than it needs to be right now. I think it's a possibility that a library will try to use one of their existing cards there for testing, so we should not be too strict in order to not turn them away. Leading zeros is pretty common, also alphanumeric. We even had a library with ß in their regular cardnumbers once. I think Koha is pretty much ok with everything in there, as long as it's not too long (fits in the db field) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #95 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to Owen Leonard in comment 92 and M.Tompsett in comment 94) Apologies if it sounded dictatorial that is certainly never my intent. I was thinking that special characters should not be permitted due to the security implications of the user being able to input code into these input fields. Regarding the server-side validation of entered cardnumbers in memberentry.pl if the user entered the form with a blank cardnumber field then the cardnumber is treated as null, as the below code shows: 298 # If the cardnumber is blank, treat it as null. 299 $newdata{'cardnumber'} = undef if $newdata{'cardnumber'} =~ /^\s*$/; Then if there is an error from the checkcardnumber function the error is handed to the @errors array, which I have already implemented in my bug. In the template memberentrygen.tt the html inputs value attribute has a '| html' in it (e.g. <input name="cardnumber" value="cardnumber | html">, as I understand it this stops any special characters entered into the input field from being executed as code. Therefore I will implement this in the cardnumber field and remove the html regex so that the same level of data validation in the staff interface and onboarding tool exists. I personally do not believe we have been lax in our data validation, for the following reason: All text input fields have had html regexs on them in the onboarding tool from the start, to prevent users from inputting special characters to fields. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #97 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 59141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59141&action=edit Bug 17855 - Removed the unnecessary javascript cardnumber validation code from onboardingstep3.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #98 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Alex Buckley from comment #95)

Apologies if it sounded dictatorial that is certainly never my intent. I was thinking that special characters should not be permitted due to the security implications of the user being able to input code into these input fields.

*sigh* No, you are forcing Romanized a-zA-Z. What about accented characters?

I personally do not believe we have been lax in our data validation,

-- With respect to unusual characters like ñ. Now you are enforcing a-zA-Z. I think we had some cross talk. I get wanting to clean inputs so you don't get the equivalent of SQL Injections and the like, but I don't get forcing a specific range that excludes diacritics. The description, which I hinted at in comment #94, found in onboarding step 4 may contain diacritics, may it not? And what about the {0,10} issue I raised in comment #88 also in onboarding step 4? And please, don't think my "it's in onboarding step 4" means it isn't elsewhere. Treat it as a class of problem, and look for it elsewhere too, because I haven't. Sorry, setting to Failed QA. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #100 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not really understand why this is Failed QA, Marc could you detail? The check on the cardnumber has been removed. There was far too much discussion about the cardnumber validation check, I'd suggest now to have one *at all* and deal with it on another bug report. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #103 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 59188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59188&action=edit Bug 17855 - Added |html and added in input title attribute to input fields where it existed previously -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17942 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 [Bug 17942] Update style of the web installer with Bootstrap 3 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17944 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944 [Bug 17944] Remove the sql code from onboarding and administrative perl scripts, and remove unnecessary use pragmas from onboarding.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #107 from M. Tompsett <mtompset@hotmail.com> --- Can we push this through first, and then discuss what to fix on it in another bug? I'm almost done my sign off testing. :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59277|0 |1 is obsolete| | --- Comment #109 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59279&action=edit [SIGNED-OFF] bug 17855 - Updated web installer finished The onboarding tool has been implemented and integrated with the updated web installer. The onboarding tool has the following functionality: * After the user has finished the web installer they are automatically redirected to the onboarding tool with no authentication in between required * Ability to create library, patron category, patron (set with superlibrarian priviliages), item type and circulation rule. * If the uaser installed sample libraries, patron categories and/or item types then the step to create one in the onboarding tool will be skipped and a skipping message will be displayed. *HTML regxes on all text input fields in all forms in the onboarding tool this prevents the user from writing in special characters *Working date picker on the patron category form Have moved all data values from mandatory to default. Now all default data values are displayed with a bulletpoint rather than a selectable checkbox stopping users from unticking neccisary data values Test plan: 1. Go through the web installer and onboarding tool with the same steps as outlined in this below guide and check that the functionality outlined in the guide exists in the patch: https://koha-community.org/manual/installation/html/ This is a combination of 67 commits. Initial 3 HTML screens of the onboarding tool and the perl onboarding.pl script Note: The advanced setup option has not yet been implemented, so what you will see is just the basic setup. Altered web installer Moved files from optional to mandatory. Edited MARC screen so that MARC21 is selected by default. Changed mandatory to default for MARC values Changed a few file name descriptions to reduce spacing in installer step 3 screen. Changed the radiobuttons to bulletpoints for default settings removed = sign Fixed bug in installer where a loop was created if you're database structure needed to be updated. Redirected this to the marcflavour screen instead of logging straight into Koha and skipping over the basic configuration steps. Changed the bulletpoints to disabled checkboxes which are checked by default Backup of step3.tt Successfully working insertion of the default options which are shown as bulletpoints Removed test text Working insertion of default and optional options Correctly selected default marc flavour of marc21 NOTE: Mark Tompsett merged several commits - Removed html regex on patron password fields. Ran perltidy to indent and space code appropriately. Ran git bz configuration commands to remove whitespace. Removed unnecissary uses in the summary.pl script - Made arrows in onboarding tool pages -> for consistency. Additionally removed the 'OR' - Added the use CGI qw ( -utf8 ); - Removed the second path to creating a library, patron category, patron, item type, and circulation rule. In onboarding .tt files and summary.tt - Fixed typo in summary.tt - Made consistent single space before and after -> in all onboarding .tt and summary.tt files. - Made single <br> tag before path to create library, patron category, item type, and circulation rule in the onboarding .tt files (patron does not need this as its layout is slightly different) - Changed button and link names in web installer and onboarding tool - Implemented Javascript password check to determine if the values in the 'password' and 'confirm password' fields are consistent. If passwords are not consistent a message informing the user is displayed and they only have to change the password values rather than re-fill out the whole form. - Fixed the errors from the koha qa test - Removed use:C4/Auth from the onboarding.pl - Moved the "select all options" button down to just above the selectable options in the basic setup, and positioned at the top of the page for the advanced setup. - Removed the "there is nothing to do because the sample data is already installed" page so if the user has install sample data in the web installer then the step to create that object in the onboarding tool is skipped altogether. - Removed the "We're just going to setup a few more things" page - Changed the title of the 'Create patron page' - Added clarifying information to the "Add a patron category" page - Added clarifying information to the "Create item type" page - Fixed the capitalization in the onboarding tool - Removed the BackupStep3.tt file which was un-used - Changed the redirect time displayed to user in step3.tt to 10 - Changed the cardnumber on the create patron administrator page so that it is only populated when the user installed sample patrons. Also changed the regex so that it allows letters and number. - Used the HTMl validator to identify errors in the template and have corrected all possible in the onboarding templates. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59140|0 |1 is obsolete| | Attachment #59141|0 |1 is obsolete| | Attachment #59174|0 |1 is obsolete| | Attachment #59188|0 |1 is obsolete| | --- Comment #111 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59281&action=edit [SIGNED-OFF] Bug 17855 - Other followups - Removed the html regex from the cardnumber field in the 'Create patron administrator' page of the onboarding tool. Added '|html' into the the value attribute of the cardnumber input field to filter the inputted cardnumber. So now the same level of validation exists for validating the inputted cardnumber in the staff interface and the onboarding tool. - Removed the unnecessary javascript cardnumber validation code from onboardingstep3.tt - Removed HTML regexes from all fields on all screens of onboarding tool except branchcode, patron category code and item type code. Also ensured these three remaining regexes are all {1,10} for length as they are all required. - Added |html and added in input title attribute to input fields where it existed previously Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #112 from M. Tompsett <mtompset@hotmail.com> --- I tested this in conjunction with bug 17942. There are only a couple things on 17942 holding me back from signing off on that too. Make sure to test by selecting but all sample data and not selecting it, so as to trigger the onboarding steps or to skip them nicely. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17955 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17955 [Bug 17955] Remove the sql code and unnecessary use pragmas from the onboarding.pl script -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002 [Bug 18002] Add functionality to create a vendor and budget in the onboarding tool -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #115 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (in reply to M.Tompsett in comments 113 and 114) To fix the dateexpiry issue I can simply remove the dateexpiry altogether from the onboarding.pl script, because in the database it is set to null by default. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #117 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to M.Tompsett in comment 116) Yes I've checked and the dateexpiry is based on the patron category and so I am currently working on retrieving the selected patron category enrolement date to be used as the value for the dateexpiry variable. In the commit I am working on currently I have set the address and city to blank values- so that is that issue fixed. Regarding the onshelfholds logic, I suggest we leave that to be fixed in bug 17955 which I am also currently working on as I am removing the SQL code which forms a big portion of the onshelfholds code in the onboarding.pl script and reworking it to use DBIx. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #120 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Alex Buckley from comment #117)

Regarding the onshelfholds logic, I suggest we leave that to be fixed in bug 17955 which I am also currently working on as I am removing the SQL code which forms a big portion of the onshelfholds code in the onboarding.pl script and reworking it to use DBIx.

I'm wondering if the wrong thing is being accessed. I was reading updatedatabase.pl around 3.19.00.017's update. The drop down list you give makes me think of the variable opac items holds. I'd personally prefer the functionality clean up (does it actually generate valid values to go in the right place) here. You can do the code clean up (DBIx, making the gui pretty, etc) there. Sorry, I just got my xenial up again to retest and ran out of time. I'll aim for 12 hours from now. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #122 from M. Tompsett <mtompset@hotmail.com> --- If you want to have this signed off, I don't want to see: Software error: DBIx::Class::Storage::DBI::_dbh_execute(): Incorrect integer value: 'anyunavailable' for column 'onshelfholds' at row 1 at /home/mtompset/kohaclone/Koha/Object.pm line 120 For help, please send mail to the webmaster (webmaster@ubuntu), giving this error message and the time and date of the error. When I attempt a Xenial install. The other possibility is completely remove onshelfholds and just default it to something. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #123 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59703&action=edit Bug 17855: Follow up - Fix onshelfholds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #126 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 59707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59707&action=edit bug 17855 - Updated web installer finished The onboarding tool has been implemented and integrated with the updated web installer. The onboarding tool has the following functionality: * After the user has finished the web installer they are automatically redirected to the onboarding tool with no authentication in between required * Ability to create library, patron category, patron (set with superlibrarian priviliages), item type and circulation rule. * If the uaser installed sample libraries, patron categories and/or item types then the step to create one in the onboarding tool will be skipped and a skipping message will be displayed. *HTML regxes on all text input fields in all forms in the onboarding tool this prevents the user from writing in special characters *Working date picker on the patron category form Have moved all data values from mandatory to default. Now all default data values are displayed with a bulletpoint rather than a selectable checkbox stopping users from unticking neccisary data values Test plan: 1. Go through the web installer and onboarding tool with the same steps as outlined in this below guide and check that the functionality outlined in the guide exists in the patch: https://koha-community.org/manual/installation/html/ This is a combination of 67 commits. Initial 3 HTML screens of the onboarding tool and the perl onboarding.pl script Note: The advanced setup option has not yet been implemented, so what you will see is just the basic setup. Altered web installer Moved files from optional to mandatory. Edited MARC screen so that MARC21 is selected by default. Changed mandatory to default for MARC values Changed a few file name descriptions to reduce spacing in installer step 3 screen. Changed the radiobuttons to bulletpoints for default settings removed = sign Fixed bug in installer where a loop was created if you're database structure needed to be updated. Redirected this to the marcflavour screen instead of logging straight into Koha and skipping over the basic configuration steps. Changed the bulletpoints to disabled checkboxes which are checked by default Backup of step3.tt Successfully working insertion of the default options which are shown as bulletpoints Removed test text Working insertion of default and optional options Correctly selected default marc flavour of marc21 NOTE: Mark Tompsett merged several commits - Removed html regex on patron password fields. Ran perltidy to indent and space code appropriately. Ran git bz configuration commands to remove whitespace. Removed unnecissary uses in the summary.pl script - Made arrows in onboarding tool pages -> for consistency. Additionally removed the 'OR' - Added the use CGI qw ( -utf8 ); - Removed the second path to creating a library, patron category, patron, item type, and circulation rule. In onboarding .tt files and summary.tt - Fixed typo in summary.tt - Made consistent single space before and after -> in all onboarding .tt and summary.tt files. - Made single <br> tag before path to create library, patron category, item type, and circulation rule in the onboarding .tt files (patron does not need this as its layout is slightly different) - Changed button and link names in web installer and onboarding tool - Implemented Javascript password check to determine if the values in the 'password' and 'confirm password' fields are consistent. If passwords are not consistent a message informing the user is displayed and they only have to change the password values rather than re-fill out the whole form. - Fixed the errors from the koha qa test - Removed use:C4/Auth from the onboarding.pl - Moved the "select all options" button down to just above the selectable options in the basic setup, and positioned at the top of the page for the advanced setup. - Removed the "there is nothing to do because the sample data is already installed" page so if the user has install sample data in the web installer then the step to create that object in the onboarding tool is skipped altogether. - Removed the "We're just going to setup a few more things" page - Changed the title of the 'Create patron page' - Added clarifying information to the "Add a patron category" page - Added clarifying information to the "Create item type" page - Fixed the capitalization in the onboarding tool - Removed the BackupStep3.tt file which was un-used - Changed the redirect time displayed to user in step3.tt to 10 - Changed the cardnumber on the create patron administrator page so that it is only populated when the user installed sample patrons. Also changed the regex so that it allows letters and number. - Used the HTMl validator to identify errors in the template and have corrected all possible in the onboarding templates. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59703|0 |1 is obsolete| | --- Comment #127 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 59708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59708&action=edit Bug 17855: Follow up - Fix onshelfholds Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59628|0 |1 is obsolete| | --- Comment #129 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59710&action=edit Bug 17855 - Implemented a retrieval of patron category enrolmentdate/enrolementdateperiod to set an appropriate dateexpiry for patron accounts created with the onboarding tool. Set address and city variables to "" in onboarding.pl Fixed the creation/filling of the $firstpassword, $secondpassword and $op variables in the onboarding.pl so they don't cause uninitialised variable errors. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59708|0 |1 is obsolete| | --- Comment #131 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59712&action=edit Bug 17855: Follow up - Fix onshelfholds Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #133 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Alex, Few more remarks: 1/ There is something wrong with the sql sample files for translated languages. The mandatory and optional files for the other languages have to be moved to the default directory as well. We will have to be meticulous to avoid regressions. 2/ You should also adapt xt/sample_notices.t, tests are failing after your patches 3/ Could you double check the module you use in installer/onboarding.pl, some are uselessly used. 4/ Double check the copyright lines you have added (+# Copyright (C) YEAR YOURNAME-OR-YOUREMPLOYER) 5/ You copied some existing javascript functions to onboardingstep2.tt. Do not duplicate existing code. You should also have a look at this template, the indentation in the javascript portion is weird. 6/ Same as 5 for onboardingstep3.tt 7/ summary.tt - you should not use <br/> tag, our translation tool does not handle sentences when they are split by html tag. That make the job really hard (and sometimes impossible) for translators. 8/ Copyright of summary.pl sounds totally wrong. 9/ Is this Summary info really useful? To me it looks like it should be moved to the help part. I am not sure it worth a new entry in the "More" menu. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #135 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Owen Leonard from comment #134)

I wonder if we could add a persistent shortcut of some kind to the global help system? I suggest this feature be discussed in a separate bug.

Yes, points 7-9 are valid issues, but probably removing summary from this, and discussing perhaps a simplified basics help page on another bug might be in order. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #137 from M. Tompsett <mtompset@hotmail.com> --- (In reply to M. Tompsett from comment #136)

Created attachment 59742 [details] [review] Bug 17855: Follow-up on broken xt test

Apologies for missing that. Here is a patch for point 2 in comment #133.

Though, this will need to be modified further to address point 1 in comment #133. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #139 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (in reply to Jonathan Druart and M.Tompsett in comment 133, 136 and 137 and 17855) As I am still learning Koha can I please have a more specific explanation of the issue(s) which you addressed in points 1 and 2? And possible solutions thereof -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #141 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (in reply to M.Tompsett in comment 133 and M.Tompsett in comment 140) Yes thanks, I also asked elsewhere. I am currently working through the issues in comment 133 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18039 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18039 [Bug 18039] Move the mandatory and optional files for non-english languages into 'default' directory so bug 17855 permits use of other languages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #149 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59841&action=edit Bug 17855: Follow up on more trimming Still needed to remove some libraries to address point 3 in comment #133. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59841|0 |1 is obsolete| | --- Comment #151 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 59856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59856&action=edit Bug 17855: Follow up on more trimming Still needed to remove some libraries to address point 3 in comment #133. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59842|0 |1 is obsolete| | --- Comment #152 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 59857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59857&action=edit Bug 17855: Followup silence a warning when there are no imported patrons. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18059 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18059 [Bug 18059] Add further explanation of the steps in the onboarding tool -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #153 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am sorry but this patchset can go without bug 18039. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #154 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60092&action=edit Bug 17855: Onboarding tool -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #156 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note sure what's is going on, I get Template process failed: file error - installer-strings.inc: not found at /home/vagrant/kohaclone/C4/Templates.pm line 121. on /installer/onboarding.pl?step=2 I do not manage to know where it comes from. (With and without my changes) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #158 from Liz Rea <liz@catalyst.net.nz> --- Hi Jonathan, I haven't been able to make mine error in your way either. Here's what I did: Applied the patches, 17855, your squashed patch, and then 18039 - all went ok. Installed fr-FR in my developer install: sudo env KOHA_CONF=/etc/koha/sites/library/koha-conf.xml PERL5LIB=/home/liz/koha-src/koha/ perl translate install fr-FR (I also installed de-DE, for funsies, but I haven't run through the installer in de-DE) Dropped my koha database Created a new db in it's place Ran through the installer in fr-FR, and made it all the way through to logging in as our newly created super librarian. As a note, there were lots of "C4::Carp redefined" warnings in the intranet log, but they didn't seem to cause any noticeable problem. One thing I did note was that the fr-FR DB templates have some additional mandatory options re: UNIMARC, and the default MARC flavour is the 3rd one in the list. That might not be right but I think not a problem for this bug to fix. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #160 from Liz Rea <liz@catalyst.net.nz> --- Katrin is kindly providing a resolved-by-her patch on Owen's bug. She's awesome and stuff. Liz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #162 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- At the beginning of the onboarding tool, if I already have patron categories and libraries, the steps 1 and 2 are skipped. But it's a bit weird, we do not understand what is going on. IIRC when I tested earlier, these steps contain message like "data already exists, click on next". -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #164 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (in reply to Jonathan Druart in comment 161)

To make thing clear: I did not want to obsolete the other patches because of >the error, and I was a bit tired yesterday and the last patch does not contain >any commit message.

Now that that error has kindly been resolved by Katrin and Liz's work on bug 17942 I will continue to test these three combined bug patches (17855, 18039 and 17942) and if successful I will obsolete the 10 previous patches for this bug and amend the final commit message of this bug.

If you agree with the plan, we can go with try to get 18039 first, then this >one. But I have no idea how we can test 18039 widely and make sure it will not >introduce any regressions.

To clarify do you mean try to get 18039 through testing and QA before this bug?

At the beginning of the onboarding tool, if I already have patron categories and libraries, the steps 1 and 2 are skipped. But it's a bit weird, we do not understand what is going on. IIRC when I tested earlier, these steps contain message like "data already >exists, click on next".

Yes I changed the way the steps for creating libraries, patron categories and item types were displayed if the user had installed sample libraries, patron categories and item types in the web installer due to your request in comment 70) so now the user is redirected to the next step that they do need to complete. -- You are receiving this mail because: You are watching all bug changes.