https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 --- Comment #117 from Alex Buckley <alexbuckley@catalyst.net.nz> --- (In reply to M.Tompsett in comment 116) Yes I've checked and the dateexpiry is based on the patron category and so I am currently working on retrieving the selected patron category enrolement date to be used as the value for the dateexpiry variable. In the commit I am working on currently I have set the address and city to blank values- so that is that issue fixed. Regarding the onshelfholds logic, I suggest we leave that to be fixed in bug 17955 which I am also currently working on as I am removing the SQL code which forms a big portion of the onshelfholds code in the onboarding.pl script and reworking it to use DBIx. -- You are receiving this mail because: You are watching all bug changes.