[Bug 22680] New: OPAC language footer not positioned correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680 Bug ID: 22680 Summary: OPAC language footer not positioned correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Created attachment 87727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87727&action=edit Screenshot showing the desired layout The language footer in the OPAC is supposed to appear at the bottom of the screen if there is not enough content to require scrolling to reach the bottom. Instead the language footer is always just below the visible area. I will submit a patch to correct this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 87729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87729&action=edit Bug 22680: OPAC language footer not positioned correctly This patch modifies the OPAC CSS so that the language-selection footer is positioned correctly. To test, apply the patch and rebuild the OPAC CSS. - Enable one or more translations in the OPAC - View a page in the OPAC which can display in your browser without a vertical scrollbar (for instance, the OPAC main page with no news items or OpacMainUserBlock). - The language-selection footer should appear at the bottom of the screen. At smaller browser heights the footer should scroll offscreen. - Test with content in the opaccredits system preference, and with OpacKohaUrl enabled. The footer should still be positioned correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87729|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87730&action=edit Bug 22680: OPAC language footer not positioned correctly This patch modifies the OPAC CSS so that the language-selection footer is positioned correctly. To test, apply the patch and rebuild the OPAC CSS. - Enable one or more translations in the OPAC - View a page in the OPAC which can display in your browser without a vertical scrollbar (for instance, the OPAC main page with no news items or OpacMainUserBlock). - The language-selection footer should appear at the bottom of the screen. At smaller browser heights the footer should scroll offscreen. - Test with content in the opaccredits system preference, and with OpacKohaUrl enabled. The footer should still be positioned correctly. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87730|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 87733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87733&action=edit Bug 22680: OPAC language footer not positioned correctly This patch modifies the OPAC CSS so that the language-selection footer is positioned correctly. To test, apply the patch and rebuild the OPAC CSS. - Enable one or more translations in the OPAC - View a page in the OPAC which can display in your browser without a vertical scrollbar (for instance, the OPAC main page with no news items or OpacMainUserBlock). - The language-selection footer should appear at the bottom of the screen. At smaller browser heights the footer should scroll offscreen. - Test with content in the opaccredits system preference, and with OpacKohaUrl enabled. The footer should still be positioned correctly. Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Version(s)| |19.05.0, 18.11.05 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22680 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org