[Bug 8834] New: Call to C4::Context::preference fails to pass $self in Circulation.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8834 Priority: P5 - low Change sponsored?: --- Bug ID: 8834 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Call to C4::Context::preference fails to pass $self in Circulation.pm Severity: enhancement Classification: Unclassified OS: All Reporter: mtompset@hotmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha Currently line reads: my $circcontrol = C4::Context::preference('CircControl'); This fails to pass $self, which means the line: my $var = lc(shift); # The system preference to return which is in C4::Context.pm (sub preference) triggers the following error log entry: [Thu Sep 27 12:23:16 2012] [error] [client 192.168.100.2] [Thu Sep 27 12:23:16 2012] renewscript.pl: Use of uninitialized value in lc at /usr/share/koha/lib/C4/Context.pm line 529. This of course was particularly confusing because the problem is neither in renewscript.pl or Context.pm, but rather Circulation.pm. This error happens to be in 'sub _debar_user_on_return', which may mean it may or may not affect other user debarred on return bugs. That wasn't what I'm testing for in this bug. This does not exist in 3.6.x. This was discovered in 3.8.5. This exists in 3.8.x and master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8834 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 12542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12542&action=edit Change :: to -> to correctly call C4::Context->preference Test ------ 1) Login in to staff client. 2) In search area, click 'Search Patrons' tab. 3) In search area text box, type a library name 4) Press Enter or Click the 'Submit' button 5) On the Left click the 'Check out' tab. 6) There should now be a list of checked out items. Check one of the 'Check In' checkboxes. Hopefully you have multiple items. 7) Add a Renewal Date. 8) Click the 'Renew or Return checked items' button. 9) check the intranet error log file. There should be something like: [Thu Sep 27 12:34:22 2012] [error] [client 192.168.100.2] [Thu Sep 27 12:34:22 2012] renewscript.pl: Use of uninitialized value in lc at /usr/share/koha/lib/C4/Context.pm line 529. 10) Apply patch 11) Check another one of the 'Check In' checkboxes. 12) Add a Renewal Date. 13) Click the 'Renew or Return checked items' button. 14) check the intranet error log file. The error should not appear. See also bug 8251, as if you have applied that patch before this one, it will not likely apply. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8834 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Actually, if it bug 8251 has already been pushed, the patch should apply fine. I just did this up from the latest master, and tested applying against the latest 3.8.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8834 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Severity|enhancement |normal --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- This is not an enhancement. Changed severity to normal. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8834 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12542|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 12768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12768&action=edit [SIGNED-OFF] Bug 8834 - Call to C4::Context::preference fails to pass $self in Circulation.pm Changed: my $circcontrol = C4::Context::preference('CircControl'); To: my $circcontrol = C4::Context->preference('CircControl'); This will pass $self and 'CircControl' which will then prevent a "Use of uninitialized value" error log entry. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8834 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8834 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com QA Contact| |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: tiny and obvious patch passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8834 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8834 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x will be in 3.8.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8834 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org