[Bug 8916] New: Hide Curriculum index in advanced search for unimarc marcflavor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8916 Priority: P5 - low Change sponsored?: --- Bug ID: 8916 Assignee: gmcharlt@gmail.com Summary: Hide Curriculum index in advanced search for unimarc marcflavor Severity: minor Classification: Unclassified OS: All Reporter: mathieu.saby@univ-rennes2.fr Hardware: All Status: ASSIGNED Version: rel_3_10 Component: Searching Product: Koha That's the 1st bug I create in bugzilla, so I hope I've understood the workflow... The problem : This bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5192 as created a "curriculum" index for 658 field in zebra, and a search option in Advanced search (under More Options) for this field. Now the "curriculum" only exists in Marc21 (and maybe Normac?) but has no equivalent in Unimarc. So the "curriculum" option must be hidden in advanced search if marcflavor is set to Unimarc. M. Saby Rennes 2 university -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8916 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |mathieu.saby@univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8916 --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 12800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12800&action=edit Hide Curriculum index in advanced search if marcflavor = unimarc Here is my 1st patch. Hope it works... To test - set marcflavour to UNIMARC, this option should be hidden in the index list in opac and staff interface advanced search - set marcflavour to MARC21, this option should be visible, as before M. Saby Rennes 2 university -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8916 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8916 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12800|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 12801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12801&action=edit Bug 8916: Hide Curriculum index in advanced search if marcflavor = unimarc This patch hides curriculum option value in koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc and koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt if marcflavor = UNIMARC To test - set marcflavour to UNIMARC, this option should be hidden in the index list in opac and staff interface advanced search - set marcflavour to MARC21, this option should be visible, as before Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8916 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8916 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment * tiny patch, template only, no side-effect risk * passes koha-qa.pl * add a string... in the follow-up adding you as a contributor * just a comment = IF (x!=y) can also be written UNLESS (x=y), and we usually uses that in Koha. But it's not enforced by a coding guideline, and I don't think we should add this rule. passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8916 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master, Welcome to the contributor's list Mathieu, you're 193th ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8916 --- Comment #5 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Thanks Paul! I was looking for an idea for a tattoo. Maybe a big "193th" in the back... Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8916 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Released in 3.10.0 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org