[Bug 35374] New: Translations contain config from ERM/data providers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 Bug ID: 35374 Summary: Translations contain config from ERM/data providers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr, jonathan.druart+koha@gmail.com, matt.blenkinsop@ptfs-europe.com https://translate.koha-community.org/translate/koha/master/messages-js/de/?c... This shouldn't appear in translations: return url }, getTableColumns() { const column_options = [ { used_by: ["title", "platform", "item", "database"], column: { title: __( this.data_type.charAt(0).toUpperCase() + this.data_type.slice(1) ), data: this.data_type, searchable: true, orderable: true, }, }, { used_by: ["item", "database", "platforms"], column: { title: "Platform", data: "platform", searchable: true, orderable: true, }, }, { used_by: ["title", "item", "database"], column: { title: "Publisher", data: "publisher", searchable: true, orderable: true, }, }, { used_by: ["title", "database"], column: { title: "Publisher ID", data: "publisher_id", searchable: true, orderable: true, }, }, { used_by: ["title"], column: { title: "DOI", data: "title_doi", searchable: true, orderable: true, }, }, { used_by: ["title"], column: { title: "Print ISSN", data: "print_issn", searchable: true, orderable: true, }, }, { used_by: ["title"], column: { title: "Online ISSN", data: "online_issn", searchable: true, orderable: true, }, }, { used_by: ["title"], column: { title: "URI", data: "title_uri", searchable: true, orderable: true, }, }, ] const columns = column_options .filter(column => column.used_by.includes(this.data_type)) .map(result => result.column) return columns }, }, mounted() { if (!this.building_table) { this.building_table = true this.getData() } }, props: ["data_type"], components: { KohaTable }, name: "UsageStatisticsProviderDataList", } </script> <style scoped> #title_list { display: table; } </style> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 159155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159155&action=edit Bug 35374: Remove ES6 template literals to fix translation strings The .po files contains the whole block after this line. I don't really understand what's happening but this change fixes the problem. Test plan: 1. Run the following command before and after the patch and compare the diff % gulp po:update --lang de-DE --task messages-js 2. Confirm that the list on this vue is correctly populated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159155|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 159172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159172&action=edit Bug 35374: Remove ES6 template literals to fix translation strings The .po files contains the whole block after this line. I don't really understand what's happening but this change fixes the problem. Test plan: 1. Run the following command before and after the patch and compare the diff % gulp po:update --lang de-DE --task messages-js 2. Confirm that the list on this vue is correctly populated Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Matt, you need to change the status as you have signed it off. I would do it, but then you wouldn't get the credit on the dashboard 8-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Good spot, forgot to do the attach -e! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159172|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159194&action=edit Bug 35374: Remove ES6 template literals to fix translation strings The .po files contains the whole block after this line. I don't really understand what's happening but this change fixes the problem. Test plan: 1. Run the following command before and after the patch and compare the diff % gulp po:update --lang de-DE --task messages-js 2. Confirm that the list on this vue is correctly populated Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159194|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 159195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159195&action=edit Bug 35374: Remove ES6 template literals to fix translation strings The .po files contains the whole block after this line. I don't really understand what's happening but this change fixes the problem. Test plan: 1. Run the following command before and after the patch and compare the diff % gulp po:update --lang de-DE --task messages-js 2. Confirm that the list on this vue is correctly populated Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34587 CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsProviderDataList.vue created by Bug 34587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 [Bug 34587] Add a Usage Statistics module to ERM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Bug 34587 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 Bug 35374 depends on bug 34587, which changed state. Bug 34587 Summary: Add a Usage Statistics module to ERM https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34587 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36836 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35374 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37805 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org