https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39446 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 179684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179684&action=edit Bug 39446: Show both status and status_alias If a request has a status_alias and that status_alias does not have a lib_opac defined, it'll show as an empty status on the OPAC. Staff UI always shows the request's status and adds the status_alias only if that is defined. The same should happen on the OPAC. To test: 1) Enabled ILLModule 2) Create a new ILL request, visit: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add '42' on the cardnumber. Pick any library. Click 'Create'. 4) Add a new 'status_alias' entry, visit the authorized values page: http://localhost:8081/cgi-bin/koha/admin/authorised_values.pl 5) Search for 'ill_'. Pick 'ILL_STATUS_ALIAS'. Click 'Add a new authorized value'. 6) Enter the 'Authorized value' of 'test', and 'Description' of 'test'. Click 'Save'. 7) Visit the previously created ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 8) Click 'Edit request' from the top toolbar. 9) On the 'Status' dropdown, pick 'test'. Click 'Submit'. 10) Visit the ILL on the OPAC: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl 11) Notice the 'status' column is empty. Click the 'View', notice the 'status' entry is empty. 12) Apply patch. Repeat -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39446 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39446 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I've signed off, as it fixes this for the OPAC. However, the staff interface needs fixing as well. If the "Description" field is left blank, on the staff interface the status shows as "New request test" (test is in bold and italics). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39446 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39446 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILL request status shows |OPAC ILL request |empty in OPAC if |status_alias is not |status_alias used and |displayed |lib_opac empty | CC| |tadeusz@sosnierz.com --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Thank you David. I've revisited this and reimplemented it as depending on bug 39600. Bug 39600 implicitly fixed the issue of the status showing empty if the status_alias was defined with an empty lib_opac. I'm also updating the title here to better reflect what this is now doing, which is adding the display of the status_alias next to the status on both table and view, similar to how it happens in Staff UI. (In reply to David Nind from comment #3)

However, the staff interface needs fixing as well.

If the "Description" field is left blank, on the staff interface the status shows as "New request test" (test is in bold and italics).

I believe this is the intended behavior i.e. default to the AV code if an appropriate UI description doesn't exist. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39446 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180955|0 |1 is obsolete| | --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 180999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180999&action=edit Bug 39446: Show both status and status_alias If a request has a status_alias and that status_alias does not have a lib_opac defined, it'll show as an empty status on the OPAC. Staff UI always shows the request's status and adds the status_alias only if that is defined. The same should happen on the OPAC. To test: 1) Enabled ILLModule 2) Create a new ILL request, visit: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add '42' on the cardnumber. Pick any library. Click 'Create'. 4) Add a new 'status_alias' entry, visit the authorized values page: http://localhost:8081/cgi-bin/koha/admin/authorised_values.pl 5) Search for 'ill_'. Pick 'ILL_STATUS_ALIAS'. Click 'Add a new authorized value'. 6) Enter the 'Authorized value' of 'test', and 'Description' of 'test'. Click 'Save'. 7) Visit the previously created ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 8) Click 'Edit request' from the top toolbar. 9) On the 'Status' dropdown, pick 'test'. Click 'Submit'. 10) Visit the ILL on the OPAC: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl 11) Notice the 'status' column does not display the status_alias. Click the 'View', notice the 'status' entry does not display the status_alias. 12) Apply patch. Repeat. Notice it defaults to displaying the authorised value code if lib_opac is empty. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39446 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180999|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 181146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181146&action=edit Bug 39446: Show both status and status_alias If a request has a status_alias and that status_alias does not have a lib_opac defined, it'll show as an empty status on the OPAC. Staff UI always shows the request's status and adds the status_alias only if that is defined. The same should happen on the OPAC. To test: 1) Enabled ILLModule 2) Create a new ILL request, visit: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add '42' on the cardnumber. Pick any library. Click 'Create'. 4) Add a new 'status_alias' entry, visit the authorized values page: http://localhost:8081/cgi-bin/koha/admin/authorised_values.pl 5) Search for 'ill_'. Pick 'ILL_STATUS_ALIAS'. Click 'Add a new authorized value'. 6) Enter the 'Authorized value' of 'test', and 'Description' of 'test'. Click 'Save'. 7) Visit the previously created ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 8) Click 'Edit request' from the top toolbar. 9) On the 'Status' dropdown, pick 'test'. Click 'Submit'. 10) Visit the ILL on the OPAC: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl 11) Notice the 'status' column does not display the status_alias. Click the 'View', notice the 'status' entry does not display the status_alias. 12) Apply patch. Repeat. Notice it defaults to displaying the authorised value code if lib_opac is empty. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39446 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39446 --- Comment #9 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 182591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182591&action=edit [24.11.x] Bug 39446: Show both status and status_alias If a request has a status_alias and that status_alias does not have a lib_opac defined, it'll show as an empty status on the OPAC. Staff UI always shows the request's status and adds the status_alias only if that is defined. The same should happen on the OPAC. To test: 1) Enabled ILLModule 2) Create a new ILL request, visit: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Add '42' on the cardnumber. Pick any library. Click 'Create'. 4) Add a new 'status_alias' entry, visit the authorized values page: http://localhost:8081/cgi-bin/koha/admin/authorised_values.pl 5) Search for 'ill_'. Pick 'ILL_STATUS_ALIAS'. Click 'Add a new authorized value'. 6) Enter the 'Authorized value' of 'test', and 'Description' of 'test'. Click 'Save'. 7) Visit the previously created ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=1 8) Click 'Edit request' from the top toolbar. 9) On the 'Status' dropdown, pick 'test'. Click 'Submit'. 10) Visit the ILL on the OPAC: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl 11) Notice the 'status' column is empty. Click the 'View', notice the 'status' entry is empty. 12) Apply patch. Repeat -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39446 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 Great thanks for the dedicated patch :D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39446 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |aude.charillon@openfifth.co | |.uk Status|Needs documenting |RESOLVED --- Comment #13 from Aude Charillon <aude.charillon@openfifth.co.uk> --- No updates to the Manual needed. -- You are receiving this mail because: You are watching all bug changes.