[Bug 39175] New: Send request to partners explodes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Bug ID: 39175 Summary: Send request to partners explodes Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: pedro.amorim@ptfs-europe.com Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: jeremy.evans@ukhsa.gov.uk, katrin.fischer@bsz-bw.de, martin.renvoize@ptfs-europe.com, pedro.amorim@ptfs-europe.com, tomascohen@gmail.com Depends on: 35570 Bug introduced in FreeForm prior to adding it to core in this commit: https://github.com/PTFS-Europe/koha-ill-freeform/commit/369dffb159f1e70162b6... It should've been Koha::Illrequestattribute into Koha::ILL::Request::Attribute not Koha::ILL::Request::Attributes Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 [Bug 35570] Add a generic master form in ILL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 178386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178386&action=edit Bug 39175: Fix Attributes->Attribute Bug introduced in FreeForm prior to adding it to core in this commit: https://github.com/PTFS-Europe/koha-ill-freeform/commit/369dffb159f1e70162b6... It should've been Koha::Illrequestattribute into Koha::ILL::Request::Attribute not Koha::ILL::Request::Attributes To test, k-t-d: 1) Enable ILLModule syspref 2) Edit the only patron in k-t-d with the 'Interlibrary loan' category: <staff_url>/cgi-bin/koha/members/memberentry.pl?op=edit_form&destination=circ&borrowernumber=16 3) Add a valid e-mail address to 'Primary email:' 4) Create a new ILL request: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 5) Add any type, any valid patron cardnumber, any library. Click 'Create'. 6) Click 'Place request with partners' 7) Pick the only available partner library 'FRL-Walker' 8) Click 'Send email'. 9) Notice you get an error. Apply patch & restart plack. Repeat. 10) Confirm the there's no error and message was queue as expected: $ select * from message_queue; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32630 [Bug 32630] Don't delete ILL requests when patron is deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178386|0 |1 is obsolete| | --- Comment #2 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 178423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178423&action=edit Bug 39175: Fix Attributes->Attribute Bug introduced in FreeForm prior to adding it to core in this commit: https://github.com/PTFS-Europe/koha-ill-freeform/commit/369dffb159f1e70162b6... It should've been Koha::Illrequestattribute into Koha::ILL::Request::Attribute not Koha::ILL::Request::Attributes To test, k-t-d: 1) Enable ILLModule syspref 2) Edit the only patron in k-t-d with the 'Interlibrary loan' category: <staff_url>/cgi-bin/koha/members/memberentry.pl?op=edit_form&destination=circ&borrowernumber=16 3) Add a valid e-mail address to 'Primary email:' 4) Create a new ILL request: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 5) Add any type, any valid patron cardnumber, any library. Click 'Create'. 6) Click 'Place request with partners' 7) Pick the only available partner library 'FRL-Walker' 8) Click 'Send email'. 9) Notice you get an error. Apply patch & restart plack. Repeat. 10) Confirm the there's no error and message was queue as expected: $ select * from message_queue; Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #3 from Brendan Lawlor <blawlor@clamsnet.org> --- Test notes: The error is almost silent, but when you try to place request with partner libraries and click send email the page just reloads with &error=unknown_error added to the url. The email still gets added to the message_queue, so after confirming the error before testing the patch it's helpful to ktd --dbshell > delete from message_queue; so the last step is easy to confirm. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178423|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178454&action=edit Bug 39175: Fix Attributes->Attribute Bug introduced in FreeForm prior to adding it to core in this commit: https://github.com/PTFS-Europe/koha-ill-freeform/commit/369dffb159f1e70162b6... It should've been Koha::Illrequestattribute into Koha::ILL::Request::Attribute not Koha::ILL::Request::Attributes To test, k-t-d: 1) Enable ILLModule syspref 2) Edit the only patron in k-t-d with the 'Interlibrary loan' category: <staff_url>/cgi-bin/koha/members/memberentry.pl?op=edit_form&destination=circ&borrowernumber=16 3) Add a valid e-mail address to 'Primary email:' 4) Create a new ILL request: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 5) Add any type, any valid patron cardnumber, any library. Click 'Create'. 6) Click 'Place request with partners' 7) Pick the only available partner library 'FRL-Walker' 8) Click 'Send email'. 9) Notice you get an error. Apply patch & restart plack. Repeat. 10) Confirm the there's no error and message was queue as expected: $ select * from message_queue; Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.11 |Main Keywords| |additional_work_needed --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is clearly fixing a bad bug and as such I am pushing it, but it feels like a unit test to prevent future regression would be nice here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00, 24.11.03 released in| | Status|Pushed to main |Pushed to stable CC| |paul.derscheid@lmscloud.de --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk --- Comment #8 from Aude Charillon <aude.charillon@openfifth.co.uk> --- *** Bug 39629 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #5)
This is clearly fixing a bad bug and as such I am pushing it, but it feels like a unit test to prevent future regression would be nice here.
Would still be nice,... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #11 from Aude Charillon <aude.charillon@openfifth.co.uk> --- No update to the Manual needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39175 Bug 39175 depends on bug 35570, which changed state. Bug 35570 Summary: Add a generic master form in ILL https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35570 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org