[Bug 11317] New: Add a way to access log files from the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Bug ID: 11317 Summary: Add a way to access log files from the intranet. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: fcapovilla@live.ca QA Contact: testopia@bugs.koha-community.org Created attachment 23203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23203&action=edit Adds a page to access log files on the server from the intranet. This patch adds a new report section (Report/log files) that lets you access log files in a specific directory on the server. The directory to use can be specified by the "publiclogdir" config in koha-conf.xml : <config> ... <publiclogdir>/var/log/koha-public</publiclogdir> ... </config> With this feature, you can configure cron scripts so they create files in the publiclogdir directory, and these files will then be accessible in the intranet. This is useful when using the html export of overdue_notices.pl or the invalid_856u.sh script as a cron. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Frédérick, Could you provide a test plan and replace tablesorter with datatables please? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23203|0 |1 is obsolete| | --- Comment #2 from Frédérick Capovilla <fcapovilla@live.ca> --- Created attachment 25387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25387&action=edit New version of the patch, now using datatables Test case : Preparation : * Add the "publiclogdir" preference to your "koha-conf.xml" file. This preference should be in the "config" section. For this test cas, we will use the "/tmp/koha-public" directory : <config> ... <publiclogdir>/tmp/koha-public</publiclogdir> ... </config> * Create the log directory on your server. Make sure this directory is readable by your web server : $ mkdir /tmp/koha-public * Add a test file in the log directory : $ cd /tmp/koha-public $ echo "Hello world!" > test.txt Test : * Go in the "Reports" section in the intranet and select "Report/log files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. Download the file and verify its content. It should contain the text "Hello world!". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Add a way to access log |Add a way to access files |files from the intranet. |from the intranet. --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Removing the "log" as I think the use case is a bit wider - it could be an interesting feature to use with printed notices (overdues, holds, etc.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |fcapovilla@live.ca -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I like this patch... but, I'de like to see it implemented such that the files in question have perma-links as opposed to the current dynamically created ones which could change. I'de also love to see a followup that allowed files to require authentication or not. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I like the idea of this being 'required authentication' only and having another mostly separate feature for publicly available files. We have been thinking about how the library could get to printed holds and overdue notices. Moving them to an SFTP server or similar would be an option, but having a secure way in Koha to access and download the files would be better. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 27492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27492&action=edit Bug 11317: Follow up - Update ID to allow for permalinking This follow up modifies the id parameter to use a digest of the filename to enable permalinking to files even if the array order changes due to new files being created. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Added a follow-up to create permalinks to files based upon filename only (We may want to link to a changing file in the case of logs). I'de still like to see this changed to reflect different permissions more specifically, to enable a more general approach, as opposed to being a reports only feature. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- The second patch does not apply Applying: Bug 11317: Follow up - Update ID to allow for permalinking fatal: sha1 information is lacking or useless (reports/report_files.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27492|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 27579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27579&action=edit Bug 11317: Follow up - Update ID to allow for permalinking This follow up modifies the id parameter to use a digest of the filename to enable permalinking to files even if the array order changes due to new files being created. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, I found a minor bug in my code anyways, so I've uploaded a new patch.. However, I couldn't replicate your issue anyway Chris, are you still having issues? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27579|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 27604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27604&action=edit Bug 11317: Follow up - Update ID to allow for permalinking This follow up modifies the id parameter to use a digest of the filename to enable permalinking to files even if the array order changes due to new files being created. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks Joubu.. no idea why it wasn't applying.. but your new one applies fine for me still and hopefully also for everyone else too.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5771 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 simith.doliveira@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com, | |marjorie.barry-vila@ccsr.qc | |.ca, | |philippe.blouin@inlibro.com | |, | |simith.doliveira@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6874 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25387|0 |1 is obsolete| | Attachment #27604|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35938&action=edit Bug 11317: Adds a page to access log files on the server from the intranet. The directory used is defined by the "publiclogdir" preference in koha-conf.xml. Test case : Preparation : * Add the "publiclogdir" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/koha-public" directory : <config> ... <publiclogdir>/tmp/koha-public</publiclogdir> ... </config> * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/koha-public * Add a test file in the log directory : $ cd /tmp/koha-public $ echo "Hello world!" > test.txt Test : * Go in the "Reports" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35939&action=edit Bug 11317: Follow up - Update ID to allow for permalinking This follow up modifies the id parameter to use a digest of the filename to enable permalinking to files even if the array order changes due to new files being created. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35940&action=edit Bug 11317: Rename publiclogdir with publicdir Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- I suggest to rename publiclogdir with publicdir. Feel free so obsolete the patch if you disagree. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- FAIL reports/report_files.pl FAIL critic I/O layer ":utf8" used at line 78, column 9. Use ":encoding(UTF-8)" to get strict validation. Bareword file handle opened at line 78, column 9. See pages 202,204 of PBP. FAIL forbidden patterns forbidden pattern: trailing space char (line 61) forbidden pattern: trailing space char (line 8) forbidden pattern: tab char (line 45) forbidden pattern: trailing space char (line 60) forbidden pattern: tab char (line 52) forbidden pattern: tab char (line 41) forbidden pattern: tab char (line 42) forbidden pattern: Koha is now under the GPLv3 license (line 13) forbidden pattern: tab char (line 43) forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 55) forbidden pattern: tab char (line 44) forbidden pattern: tab char (line 40) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/report_files.tt FAIL forbidden patterns forbidden pattern: tab char (line 10) forbidden pattern: To include datatables files, please use the include file (see bug 10868) (line 5) forbidden pattern: tab char (line 31) forbidden pattern: tab char (line 33) forbidden pattern: tab char (line 19) forbidden pattern: tab char (line 30) forbidden pattern: tab char (line 18) forbidden pattern: tab char (line 9) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Charles Farmer <charles.farmer@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #18 from Charles Farmer <charles.farmer@inlibro.com> --- Created attachment 36844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36844&action=edit Bug 11317: Correct critic, forbidden patterns issues when tested with koha-test-tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #19 from M. Tompsett <mtompset@hotmail.com> --- How does this relate to something like bug 6874? :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35938|0 |1 is obsolete| | --- Comment #20 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39783&action=edit [SIGNED-OFF] Bug 11317: Adds a page to access log files on the server from the intranet. The directory used is defined by the "publiclogdir" preference in koha-conf.xml. Test case : Preparation : * Add the "publiclogdir" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/koha-public" directory : <config> ... <publiclogdir>/tmp/koha-public</publiclogdir> ... </config> * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/koha-public * Add a test file in the log directory : $ cd /tmp/koha-public $ echo "Hello world!" > test.txt Test : * Go in the "Reports" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35939|0 |1 is obsolete| | --- Comment #21 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39784&action=edit [SIGNED-OFF] Bug 11317: Follow up - Update ID to allow for permalinking This follow up modifies the id parameter to use a digest of the filename to enable permalinking to files even if the array order changes due to new files being created. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35940|0 |1 is obsolete| | --- Comment #22 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39785&action=edit [SIGNED-OFF] Bug 11317: Rename publiclogdir with publicdir Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36844|0 |1 is obsolete| | --- Comment #23 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39786&action=edit [SIGNED-OFF] Bug 11317: Correct critic, forbidden patterns issues when tested with koha-test-tools Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, nice addition. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Please provide a test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #25 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Kyle M Hall from comment #24)
Please provide a test plan.
I'm assuming they followed comment #2, comment #13, and/or comment #20. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxime.beaulieu@inlibro.com Status|Failed QA |Signed Off --- Comment #26 from Maxime Beaulieu <maxime.beaulieu@inlibro.com> --- (In reply to Kyle M Hall from comment #24)
Please provide a test plan.
Test case : Preparation : * Add the "publiclogdir" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/koha-public" directory : <config> ... <publiclogdir>/tmp/koha-public</publiclogdir> ... </config> * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/koha-public * Add a test file in the log directory : $ cd /tmp/koha-public $ echo "Hello world!" > test.txt Test : * Go in the "Reports" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Maxime Beaulieu <maxime.beaulieu@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fcapovilla@live.ca |maxime.beaulieu@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Who signed the| |Jonathan Druart patch off| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Could we have some documentation on what a sensible directory location would look like, and what permissions the files within it may require to be accessible by this route (and only this route)? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am really keen on this feature, as Koha lacks a good way to access files like the ones generated for print notices. I have a few concerns tho: - The files should be stored in a directory on the server that is safe and cannot be accessed from outside as these files can and will most likely contain patron information in some way. How can we make this happen? I think the least we need to do is add a documentation saying that clearly. - Related to the first thing... can we please rename publicdir again to indicate something that should not be public/open? internal_files? privatefiledir? Not really a good idea here, but someone else might have. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- A further enhancement I'd love to see is multiple directories. The was initially designed as a way to expose log files, and it shows. It's fast turning into a more generic solution for exposing notices, logs, whatever... but putting notices under a tool called 'reports' and combining files with different purposes into one directory both make little sense.. I'm thinking along the lines of a config block of the form: <staffdirs> <reports> <dir></dir> <permission></permission> </reports> <notices> <dir></dir> <permission></permission> </notices> </staffdirs> This would yield a much more comprehensive and viable feature -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some more notes: - +use strict; +use warnings; > Please use Modern::Perl; instead - The table should use a standard display format of Koha for the date and time information. The information form the patch doesn't translate and can't be configured with the dateformat/timeformat preferences: Thu Aug 2 16:41:30 2012 - I feel this would be better as a tool than as a link on the reports page - I don't really see a connection to reports so much, as it's a very general tool. - I am still in favor of renaming the directory to something less 'public' and we should have some information on how to use this feature safely without exposing data accidentally via your web server that should be kept safe. Possible enhancements: - As the kind of files presented can be quite different, it would be nice if this had its own permission. - Allow multiple directories - @Martin, maybe this could be added later? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|maxime.beaulieu@inlibro.com |bouzid.fergani@inlibro.com CC| |bouzid.fergani@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #31 from Blou <philippe.blouin@inlibro.com> --- We have a hard time figuring a good name for publicdir. Bouzid will do all the fixes you asked, but I expect someone will come with another patch just to change the config name, eventually. Regarding the multidir suggestion, we like it. But that's outside of the sponsored work, and I must say would be really easy to add once this is accepted. Making this harder to accept from the start is probably not where we want to be. Further hint as to what is looked for as for documentation would be a great help. Not sure where to start. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #32 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 44859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44859&action=edit Test case : Preparation : * Add the "filesaccess" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/files-access" directory : <config> ... <filesaccess>/tmp/files-access</filesaccess> ... </config> * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/files-access * Add a test file in the log directory : $ cd /tmp/files-access $ echo "Hello world!" > test.txt Test : * Go in the "tools/Additional tools" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44859|0 |1 is obsolete| | --- Comment #33 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 44860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44860&action=edit Bug 11317: translate date with datetime format preference,replace in tools and rename preference in Koha-config.xml. Test case : Preparation : * Add the "filesaccess" preference to your "koha-conf.xml" file. This * preference should be in the "config" section. For this test cas, we * will use the "/tmp/files-access" directory : <config> ... <filesaccess>/tmp/files-access</filesaccess> ... </config> * Create the log directory on your server. Make sure this directory * is readable by your web server : $ mkdir /tmp/files-access * Add a test file in the log directory : $ cd /tmp/files-access $ echo "Hello world!" > test.txt Test : * Go in the "tools/Additional tools" section in the intranet and select "Report/log * files" * The "test.txt" should appear in the files list. * Click on the "test.txt" file, a download dialog should appear. * Download the file and verify its content. It should contain the * text "Hello world!". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Bouzid, thx for the new patches! For documentation I have following ideas: - Add a help page to the new page containing information on how to set this up. - Show a message on the About page of Koha and/or on the page itself, if the directory is not set up correctly - Show some kind of warning that people should set this up carefully because the files can include patron/sensitive information and what to look out for? Could we set up a safe (not accessible by URL) default directory for people to use? (normal installation... packages?) I am not sure how this could best be done technically, but someone else might be able to help. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org