[Bug 9067] New: Staging an authority file gives conflicting messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Priority: P5 - low Change sponsored?: --- Bug ID: 9067 Assignee: gmcharlt@gmail.com Summary: Staging an authority file gives conflicting messages Severity: normal Classification: Unclassified OS: All Reporter: magnus@enger.priv.no Hardware: All Status: NEW Version: master Component: MARC Authority data support Product: Koha Created attachment 13417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13417&action=edit Managing a staged authority file After uploading a MARC file on "Home › Tools › Stage MARC records for import" it is possible to choose "Authority" as the "Record type". Doing this hides the "Check for embedded item record data?" question correctly. However, after clicking on "Stage for import", the list of feedback includes "0 item records found and staged". After clicking on the "Manage staged records" link on that same screen, the new screen that appears includes an option for "Item processing" as well as the text "Add new bibliographic records into this framework:" followed by a dropdown containing the bibliographic frameworks. See attached screenshot. I tried staging/importing an example file from another bug, and it did get imported OK, so this problem might be mostly cosmetic. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is still true for managing staged imports on current master: item options are offered and displayed in the summary. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37416&action=edit Bug 9067: Hide item related strings when importing staged authority records On importing authority records, the items related string should not be displayed. Test plan: 1/ Import an authority record 2/ Confirm the item related string are not displayed. 3/ Before this script, the record_type param was lost just after importing the records. Now you should see "Processing authority records" of "Processing bibliographic records" in the "MARC staging results" No behavior should exist on importing bibliographic records. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10097 Patch complexity|--- |Small patch --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Magnus Enger from comment #0)
the text "Add new bibliographic records into this framework:" followed by a dropdown containing the bibliographic frameworks. See attached screenshot.
This has been done by bug 10097. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 37416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37416 Bug 9067: Hide item related strings when importing staged authority records Review of attachment 37416: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9067&attachment=37416) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt @@ +306,5 @@
[% END %] [% END %] </li> + + [% IF ( record_type == 'biblio' ) %]
You missed the section around line 378: Number of items added 0 Number of items replaced 0 Number of items ignored because of duplicate barcode 0 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Failed QA --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- Changing to Failed QA, simply because of the block of item counts was displayed: Number of items added 0 Number of items replaced 0 Number of items ignored because of duplicate barcode 0 while viewing .../cgi-bin/koha/tools/manage-marc-import.pl Everything else looked great. Just fix that tiny piece. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37674&action=edit Sample 1 record authority MRC file. Attaching sample authority record that I used for testing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37416|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37713&action=edit Bug 9067: Hide item related strings when importing staged authority records On importing authority records, the items related string should not be displayed. Test plan: 1/ Import an authority record 2/ Confirm the item related string are not displayed. 3/ Before this script, the record_type param was lost just after importing the records. Now you should see "Processing authority records" of "Processing bibliographic records" in the "MARC staging results" 4/ Revert the import and check there is not item related strings. No behavior should exist on importing bibliographic records. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 37713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37713 Bug 9067: Hide item related strings when importing staged authority records Review of attachment 37713: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9067&attachment=37713) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt @@ +378,5 @@
+ [% IF ( record_type == 'biblio' ) %] + <tr><td>Number of items added</td><td>[% num_items_added %]</td></tr> + <tr><td>Number of items replaced</td><td>[% num_items_replaced %]</td></tr> + <tr><td>Number of items ignored because of duplicate barcode</td><td>[% num_items_errored %]</td></tr> + [ % END %]
Tiny spacing issue. Fixing and signing off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38510&action=edit Bug 9067 - Fix space There was a [ % END %] which triggered template parsing errors. Follow the test plan in comment #7 with both patches applied. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37713|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38511&action=edit Bug 9067: Hide item related strings when importing staged authority records On importing authority records, the items related string should not be displayed. Test plan: 1/ Import an authority record 2/ Confirm the item related string are not displayed. 3/ Before this script, the record_type param was lost just after importing the records. Now you should see "Processing authority records" of "Processing bibliographic records" in the "MARC staging results" 4/ Revert the import and check there is not item related strings. No behavior should exist on importing bibliographic records. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38510|0 |1 is obsolete| | --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38512&action=edit Bug 9067 - Fix space There was a [ % END %] which triggered template parsing errors. Follow the test plan in comment #7 with both patches applied. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38511|0 |1 is obsolete| | Attachment #38512|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38630&action=edit [PASSED QA] Bug 9067: Hide item related strings when importing staged authority records On importing authority records, the items related string should not be displayed. Test plan: 1/ Import an authority record 2/ Confirm the item related string are not displayed. 3/ Before this script, the record_type param was lost just after importing the records. Now you should see "Processing authority records" of "Processing bibliographic records" in the "MARC staging results" 4/ Revert the import and check there is not item related strings. No behavior should exist on importing bibliographic records. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38631&action=edit [PASSED QA] Bug 9067 - Fix space There was a [ % END %] which triggered template parsing errors. Follow the test plan in comment #7 with both patches applied. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Patch doesn't apply --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please rebase for inclusion ASAP. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 --- Comment #15 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39188&action=edit Bug 9067: Hide item related strings when importing staged authority records On importing authority records, the items related string should not be displayed. Test plan: 1/ Import an authority record 2/ Confirm the item related string are not displayed. 3/ Before this script, the record_type param was lost just after importing the records. Now you should see "Processing authority records" of "Processing bibliographic records" in the "MARC staging results" 4/ Revert the import and check there is not item related strings. No behavior should exist on importing bibliographic records. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 --- Comment #16 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39189&action=edit Bug 9067 - Fix space There was a [ % END %] which triggered template parsing errors. Follow the test plan in comment #7 with both patches applied. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38630|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38631|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #17 from M. Tompsett <mtompset@hotmail.com> --- Fixed conflict, retested, reset back to Passed QA. (*grumbles about commas and white space making things conflict so easily*) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9067 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan and Mark! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org