[Bug 40958] New: Move patron_to_html (from js-patron-format.inc) to a standalone JS file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Bug ID: 40958 Summary: Move patron_to_html (from js-patron-format.inc) to a standalone JS file Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org We have to explicitly include the TT js-patron-format.inc in all the .tt files we are going to format a patron. It's also hard to use from JS files, which is a bit ridiculous. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32176 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32176 [Bug 32176] js/patron-autocomplete.js need another option -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187476&action=edit Bug 40958: Move patron_to_html to a standalone JS file It will be easier to reuse patron_to_html Test plan: Search for patron and confirm that that patron are formatted correctly. Global patron search and a couple of other places should be enough. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187476|0 |1 is obsolete| | --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187533&action=edit Bug 40958: Move patron_to_html to a standalone JS file It will be easier to reuse patron_to_html Test plan: Search for patron and confirm that that patron are formatted correctly. Global patron search and a couple of other places should be enough. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40699 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40699 [Bug 40699] Preferred name not displayed for instructors in course reserves in staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187646&action=edit Bug 40958: Remove remaining occurrence in course_reserves/course.tt
From bug 40699
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40995 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 [Bug 40995] Patron search autocomplete adds extraneous spacing and punctuation when patron lacks surname -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cj.lynce@westlakelibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 [Bug 41003] Missing Cypress tests for patron display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|40995 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40995 [Bug 40995] Patron search autocomplete adds extraneous spacing and punctuation when patron lacks surname -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187533|0 |1 is obsolete| | Attachment #187646|0 |1 is obsolete| | --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188800&action=edit Bug 40958: Move patron_to_html to a standalone JS file It will be easier to reuse patron_to_html Test plan: Search for patron and confirm that that patron are formatted correctly. Global patron search and a couple of other places should be enough. Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188801&action=edit Bug 40958: Remove remaining occurrence in course_reserves/course.tt
From bug 40699
Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Ignoring this: [FAIL] koha-tmpl/intranet-tmpl/prog/js/patron-format.js FAIL forbidden_patterns forbidden pattern: Use __("") instead of _("") (line 43) forbidden pattern: Use __("") instead of _("") (line 45) Processing additional checks PASS! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188866&action=edit Bug 40958: (follow-up) Fix QA complaint about forbidden pattern -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED CC| |Laura.escamilla@bywatersolu | |tions.com Resolution|--- |FIXED --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Bug 32176 was not backported to 25.05.x so this will not be backported either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 Bug 40958 depends on bug 41003, which changed state. Bug 41003 Summary: Missing Cypress tests for patron display https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org