[Bug 41003] New: Missing Cypress tests for patron display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 Bug ID: 41003 Summary: Missing Cypress tests for patron display Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Several enhancements in the queue related to the patron display. We should first have Cypress test for main before starting adding more changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187837&action=edit Bug 41003: Remove extra spaces -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187838&action=edit Bug 41003: Add Cypress tests to cover patron formatting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40958 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40958 [Bug 40958] Move patron_to_html (from js-patron-format.inc) to a standalone JS file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187838|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187840&action=edit Bug 41003: Add Cypress tests to cover patron formatting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- No one tested this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #4)
No one tested this?
I didn't think it was needed for several reasons: * This patch adds tests for "main", nothing else (the "Remove extra spaces" change is not something visible on the interface, only to make the tests pass) * It has been added as blocker of other bugs and I didn't want to block them because of tests (especially bug 40245 that is not from me) * Follow-up bugs will extend those tests, and so testers and QAers will confirm they work anyway But feel free to ask for a QA stamp if you are not comfortable with the patches! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187837|0 |1 is obsolete| | Attachment #187840|0 |1 is obsolete| | --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188802&action=edit Bug 41003: Add Cypress tests to cover patron formatting Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Conflicts from bug 30568 - I don't believe first patch was needed any longer - dropped -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41003 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED CC| |Laura.escamilla@bywatersolu | |tions.com Resolution|--- |FIXED --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Bug 32176 nor 40958 was not backported to 25.05.x so this will not be backported either. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org