[Bug 23214] New: OPAC add ability to pay guarantees fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Bug ID: 23214 Summary: OPAC add ability to pay guarantees fines Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: agustinmoyano@theke.io QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com Depends on: 20691 Blocks: 20211, 23213 Target Milestone: --- Add ability in OPAC to pay guarantees fines Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20211 [Bug 20211] Guarantor/Guarantee and payments ideas [OMNIBUS] https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 [Bug 20691] Add ability for guarantors to view guarantee's fines in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213 [Bug 23213] OPAC check mimimum payment threshold from payment plugin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |agustinmoyano@theke.io |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 --- Comment #1 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 91007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91007&action=edit Bug 23214: Modify account-table.inc to enable payment of guarantees fines This patch enables a guarantor to pay guarantees fines in OPAC To test: 1. Apply dependencies 2. On intranet, search for AllowStaffToSetFinesVisibilityForGuarantor preference and set to "Allow" 3. Enable some payment method 4. Find a patron with guarantor and edit 5. Change "Show fines to guarantor" select to "Yes" and save 6. Create a manual invoice for the patron (guarantee) 7. Enter OPAC with guarantor user 8. Go to "your fines" tab SUCCESS => Guarantees fines appear, and is selectable to pay 9. Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Arthur Bousquet <arthur.bousquet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.bousquet@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Arthur Bousquet <arthur.bousquet@inlibro.com> --- I got these errors when trying to apply the patch fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc). error: could not build fake ancestor Patch failed at 0001 Bug 23214: Modify account-table.inc to enable payment of guarantees fines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Maybe because of bug 23115 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Arthur Bousquet from comment #2)
I got these errors when trying to apply the patch
fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc). error: could not build fake ancestor Patch failed at 0001 Bug 23214: Modify account-table.inc to enable payment of guarantees fines
Weird, patch applies for me with merge.. 91007 - Bug 23214: Modify account-table.inc to enable payment of guarantees fines Apply? [(y)es, (n)o, (i)nteractive] y Aplicando: Bug 23214: Modify account-table.inc to enable payment of guarantees fines Usando la información del índice para reconstruir un árbol base... M koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc Retrocediendo para parchar base y fusión de 3-vías... Auto-fusionando koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc Maybe it's because I rebased 14570, and now applies nicely. Please try again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Maryse Simard <maryse.simard@inlibro.com> --- I can't apply the patch : Applying: Bug 23214: Modify account-table.inc to enable payment of guarantees fines fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc). error: could not build fake ancestor Patch failed at 0001 Bug 23214: Modify account-table.inc to enable payment of guarantees fines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 --- Comment #6 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Maryse Simard from comment #5)
I can't apply the patch :
Applying: Bug 23214: Modify account-table.inc to enable payment of guarantees fines fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc). error: could not build fake ancestor Patch failed at 0001 Bug 23214: Modify account-table.inc to enable payment of guarantees fines
Hi Maryse, that's weird.. I just applied patches root@48ecf79b6b40:koha(bug-23214)$ git bz apply 23214 Bug 23214 Depends on bug 20691 Follow? [(y)es, (n)o] y Bug 20691 Depends on bug 14570 Follow? [(y)es, (n)o] y Bug 14570 - Make it possible to add multiple guarantors to a record 91694 - Bug 14570: Make it possible to add multiple guarantors to a record 91695 - Bug 14570: (follow-up) fix table name in j2a.pl 91696 - Bug 14570: (follow-up) fix qa FAIL tests 91697 - Bug 14570: (follow-up) Fix tests 91698 - Bug 14570: (QA follow-up) fix sample borrowers, remove guarantorid) 91699 - Bug 14570: (follow-up) Fix patron type when "add child" button is pressed 91700 - Bug 14570: Update schema files [Do Not Push] Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 14570: Make it possible to add multiple guarantors to a record Applying: Bug 14570: (follow-up) fix table name in j2a.pl Applying: Bug 14570: (follow-up) fix qa FAIL tests Applying: Bug 14570: (follow-up) Fix tests Applying: Bug 14570: (QA follow-up) fix sample borrowers, remove guarantorid) Applying: Bug 14570: (follow-up) Fix patron type when "add child" button is pressed Applying: Bug 14570: Update schema files [Do Not Push] Bug 20691 - Add ability for guarantors to view guarantee's fines in OPAC 91159 - Bug 20691: Database update 91160 - Bug 20691: Add ability to turn feature on and off 91161 - Bug 20691: Implement fines view 91162 - Bug 20691: (follow-up) Fix qa fails Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20691: Database update Applying: Bug 20691: Add ability to turn feature on and off Applying: Bug 20691: Implement fines view Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt M opac/opac-user.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-user.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc Applying: Bug 20691: (follow-up) Fix qa fails Bug 23214 - OPAC add ability to pay guarantees fines 91007 - Bug 23214: Modify account-table.inc to enable payment of guarantees fines Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23214: Modify account-table.inc to enable payment of guarantees fines Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/account-table.inc Did you do it in a fresh koha/master copy? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91007|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 92844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92844&action=edit Bug 23214: Modify account-table.inc to enable payment of guarantees fines This patch enables a guarantor to pay guarantees fines in OPAC To test: 1. Apply dependencies 2. On intranet, search for AllowStaffToSetFinesVisibilityForGuarantor preference and set to "Allow" 3. Enable some payment method 4. Find a patron with guarantor and edit 5. Change "Show fines to guarantor" select to "Yes" and save 6. Create a manual invoice for the patron (guarantee) 7. Enter OPAC with guarantor user 8. Go to "your fines" tab SUCCESS => Guarantees fines appear, and is selectable to pay 9. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> https://bugs.koha-community.org/show_bug.cgi?id=23584 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi, all dependencies are now on master. I applied it cleanly and then tested using the KitchenSink plugin [1] which implements the payment methods (it won't do anything, but simulate an interaction with an external payments system). It works! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92844|0 |1 is obsolete| | --- Comment #9 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 92862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92862&action=edit Bug 23214: Modify account-table.inc to enable payment of guarantees fines This patch enables a guarantor to pay guarantees fines in OPAC To test: 1. Apply dependencies 2. On intranet, search for AllowStaffToSetFinesVisibilityForGuarantor preference and set to "Allow" 3. Enable some payment method 4. Find a patron with guarantor and edit 5. Change "Show fines to guarantor" select to "Yes" and save 6. Create a manual invoice for the patron (guarantee) 7. Enter OPAC with guarantor user 8. Go to "your fines" tab SUCCESS => Guarantees fines appear, and is selectable to pay 9. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> https://bugs.koha-community.org/show_bug.cgi?id=23584 Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92862|0 |1 is obsolete| | --- Comment #10 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 92985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92985&action=edit Bug 23214: Modify account-table.inc to enable payment of guarantees fines This patch enables a guarantor to pay guarantees fines in OPAC To test: 1. Apply dependencies 2. On intranet, search for AllowStaffToSetFinesVisibilityForGuarantor preference and set to "Allow" 3. Enable some payment method 4. Find a patron with guarantor and edit 5. Change "Show fines to guarantor" select to "Yes" and save 6. Create a manual invoice for the patron (guarantee) 7. Enter OPAC with guarantor user 8. Go to "your fines" tab SUCCESS => Guarantees fines appear, and is selectable to pay 9. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> https://bugs.koha-community.org/show_bug.cgi?id=23584 Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92985|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93139&action=edit Bug 23214: Modify account-table.inc to enable payment of guarantees fines This patch enables a guarantor to pay guarantees fines in OPAC To test: 1. Apply dependencies 2. On intranet, search for AllowStaffToSetFinesVisibilityForGuarantor preference and set to "Allow" 3. Enable some payment method 4. Find a patron with guarantor and edit 5. Change "Show fines to guarantor" select to "Yes" and save 6. Create a manual invoice for the patron (guarantee) 7. Enter OPAC with guarantor user 8. Go to "your fines" tab SUCCESS => Guarantees fines appear, and is selectable to pay 9. Sign off Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works well for me, no regressions found. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |RESOLVED --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 23214 not in 19.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Fines and fees |OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC add ability to pay |Add ability to pay |guarantees fines |guarantees fines -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature gives release notes| |guarantors the option to | |pay off their guarantees | |charges using online | |payments via the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Bug 23214 depends on bug 20691, which changed state. Bug 20691 Summary: Add ability for guarantors to view guarantee's fines in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20691 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org