[Bug 25320] New: Move translatable strings out of merge-record-strings.inc into merge-record.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 Bug ID: 25320 Summary: Move translatable strings out of merge-record-strings.inc into merge-record.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 21156 Strings which were put in merge-record-strings.inc for translation purposes can now be wrapped in the new translation function and put in merge-record.js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21156 [Bug 21156] Internationalization: plural forms, context, and more for JS files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106025&action=edit Bug 25320: Move translatable strings out of merge-record-strings.inc into merge-record.js This patch eliminates the use of a separate include file containing translatable strings in favor of embedding translatable strings in the JavaScript itself. To test, apply the patch and clear your browser cache if necessary. - Perform a catalog search in the staff interface. - Select two results to merge. Click Edit -> Merge records. - Click "Next" on the "Merging records" page. - On the "Source records" page click the second tab where all the checkboxes are unchecked. - Check the box for a tag which is non-repeatable, e.g. 245. - You should see a message, "The field is non-repeatable and already exists in the destination record. Therefore, you cannot add it." - Check the box for a subfield which is non-repeatable, e.g. 245$a. - You should see a message, "The subfield is non-repeatable and already exists in the destination record. Therefore, you cannot add it." TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from prog/js/merge-record.js for translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/js/merge-record.js:72 msgctxt "Bibliographic record" msgid "" "The field is non-repeatable and already exists in the destination record. " "Therefore, you cannot add it." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation:
perl translate install fr-FR
- Switch to your newly translated language in the staff client and repeat the test plan above. The translated string should appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106025|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 110575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110575&action=edit Bug 25320: Move translatable strings out of merge-record-strings.inc into merge-record.js This patch eliminates the use of a separate include file containing translatable strings in favor of embedding translatable strings in the JavaScript itself. To test, apply the patch and clear your browser cache if necessary. - Perform a catalog search in the staff interface. - Select two results to merge. Click Edit -> Merge records. - Click "Next" on the "Merging records" page. - On the "Source records" page click the second tab where all the checkboxes are unchecked. - Check the box for a tag which is non-repeatable, e.g. 245. - You should see a message, "The field is non-repeatable and already exists in the destination record. Therefore, you cannot add it." - Check the box for a subfield which is non-repeatable, e.g. 245$a. - You should see a message, "The subfield is non-repeatable and already exists in the destination record. Therefore, you cannot add it." TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from prog/js/merge-record.js for translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/js/merge-record.js:72 msgctxt "Bibliographic record" msgid "" "The field is non-repeatable and already exists in the destination record. " "Therefore, you cannot add it." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation:
perl translate install fr-FR
- Switch to your newly translated language in the staff client and repeat the test plan above. The translated string should appear. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110575|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110627&action=edit Bug 25320: Move translatable strings out of merge-record-strings.inc into merge-record.js This patch eliminates the use of a separate include file containing translatable strings in favor of embedding translatable strings in the JavaScript itself. To test, apply the patch and clear your browser cache if necessary. - Perform a catalog search in the staff interface. - Select two results to merge. Click Edit -> Merge records. - Click "Next" on the "Merging records" page. - On the "Source records" page click the second tab where all the checkboxes are unchecked. - Check the box for a tag which is non-repeatable, e.g. 245. - You should see a message, "The field is non-repeatable and already exists in the destination record. Therefore, you cannot add it." - Check the box for a subfield which is non-repeatable, e.g. 245$a. - You should see a message, "The subfield is non-repeatable and already exists in the destination record. Therefore, you cannot add it." TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from prog/js/merge-record.js for translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/js/merge-record.js:72 msgctxt "Bibliographic record" msgid "" "The field is non-repeatable and already exists in the destination record. " "Therefore, you cannot add it." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation:
perl translate install fr-FR
- Switch to your newly translated language in the staff client and repeat the test plan above. The translated string should appear. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Include file still used in authorities/merge.tt koha-tmpl/intranet-tmpl/prog/en/modules/authorities/merge.tt: [% INCLUDE 'merge-record-strings.inc' %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 110901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110901&action=edit Bug 25320: (follow-up) Remove obsolete include file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.05 released in| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Component|Templates |I18N/L10N Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org