https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25320 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106025&action=edit Bug 25320: Move translatable strings out of merge-record-strings.inc into merge-record.js This patch eliminates the use of a separate include file containing translatable strings in favor of embedding translatable strings in the JavaScript itself. To test, apply the patch and clear your browser cache if necessary. - Perform a catalog search in the staff interface. - Select two results to merge. Click Edit -> Merge records. - Click "Next" on the "Merging records" page. - On the "Source records" page click the second tab where all the checkboxes are unchecked. - Check the box for a tag which is non-repeatable, e.g. 245. - You should see a message, "The field is non-repeatable and already exists in the destination record. Therefore, you cannot add it." - Check the box for a subfield which is non-repeatable, e.g. 245$a. - You should see a message, "The subfield is non-repeatable and already exists in the destination record. Therefore, you cannot add it." TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR:
cd misc/translator perl translate update fr-FR
- Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from prog/js/merge-record.js for translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/js/merge-record.js:72 msgctxt "Bibliographic record" msgid "" "The field is non-repeatable and already exists in the destination record. " "Therefore, you cannot add it." msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation:
perl translate install fr-FR
- Switch to your newly translated language in the staff client and repeat the test plan above. The translated string should appear. -- You are receiving this mail because: You are watching all bug changes.