[Bug 43308] New: Migrate circ/article-requests.tt and request-article.tt to use api-client.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43308 Bug ID: 43308 Summary: Migrate circ/article-requests.tt and request-article.tt to use api-client.js Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Depends on: 34451 Target Milestone: --- circ/article-requests.tt and circ/request-article.tt use raw jQuery.ajax() for DELETE calls to /api/v1/article_requests/.... These need to be migrated to api-client.js for proper CSRF token handling (bug 34451). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43308 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34451 Depends on|34451 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43308 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43308 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 203677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203677&action=edit Bug 43308: Migrate article request cancellation to api-client.js This patch replaces raw jQuery.ajax() DELETE calls for cancelling article requests with the api-client.js pattern. Changes: - Rename existing article-request-api-client.js to article-request-svc-client.js (it uses the svc endpoint) - Create new article-request-api-client.js with REST API base and articleRequests.cancel method - Register article_request_svc in api-client.js for existing svc callers (process, complete, pending, update_urls) - Update existing svc callers to use APIClient.article_request_svc - Replace $.ajax DELETE in article-requests.tt and request-article.tt with APIClient.article_request.articleRequests.cancel Test plan: 1. Apply patch 2. Go to Circulation > Article requests 3. Cancel an article request => SUCCESS: Request removed from table 4. Go to a record > Request article > cancel => SUCCESS: Request row hidden 5. Verify process/complete/pending still work (svc client) => SUCCESS: All actions functional 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org