https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43308 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34451 Depends on|34451 | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43308 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 203677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203677&action=edit Bug 43308: Migrate article request cancellation to api-client.js This patch replaces raw jQuery.ajax() DELETE calls for cancelling article requests with the api-client.js pattern. Changes: - Rename existing article-request-api-client.js to article-request-svc-client.js (it uses the svc endpoint) - Create new article-request-api-client.js with REST API base and articleRequests.cancel method - Register article_request_svc in api-client.js for existing svc callers (process, complete, pending, update_urls) - Update existing svc callers to use APIClient.article_request_svc - Replace $.ajax DELETE in article-requests.tt and request-article.tt with APIClient.article_request.articleRequests.cancel Test plan: 1. Apply patch 2. Go to Circulation > Article requests 3. Cancel an article request => SUCCESS: Request removed from table 4. Go to a record > Request article > cancel => SUCCESS: Request row hidden 5. Verify process/complete/pending still work (svc client) => SUCCESS: All actions functional 6. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43308 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203677|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43308 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I've signed off, but I'm not sure about step 5 in the test plan - svc client. I only used the staff interface for testing. If additional testing is required, such as by using API requests or something else (I'm not sure what an svc client is), please provide instructions. Testing notes (using KTD): 1. Enable the ArticleRequests system preference. 2. Create some article requests (I created 5). -- You are receiving this mail because: You are watching all bug changes.