https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Status|NEW |ASSIGNED Depends on| |23376 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 [Bug 23376] Cleanup order receive page code -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 123969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123969&action=edit Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page On bug 23376 we replaced $order, from hashref Koha::Acq::Order, but 2 occurrences have not been corrected. It causes a bug on the order receive page when the bib is linked with a suggestion. Test plan: Create an order from bib A, create a suggestion for purchase on bib A (OPAC) Receive the order. Without the patch: Notice the "Suggested by: (suggestion #)" With the patch you see the info of the suggester -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28844 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123969|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 123979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123979&action=edit Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page On bug 23376 we replaced $order, from hashref Koha::Acq::Order, but 2 occurrences have not been corrected. It causes a bug on the order receive page when the bib is linked with a suggestion. Test plan: Create an order from bib A, create a suggestion for purchase on bib A (OPAC) Receive the order. Without the patch: Notice the "Suggested by: (suggestion #)" With the patch you see the info of the suggester Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123979|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 124130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124130&action=edit Bug 28881: (bug 23376 follow-up) Fix suggestion display on order receive page On bug 23376 we replaced $order, from hashref Koha::Acq::Order, but 2 occurrences have not been corrected. It causes a bug on the order receive page when the bib is linked with a suggestion. Test plan: Create an order from bib A, create a suggestion for purchase on bib A (OPAC) Receive the order. Without the patch: Notice the "Suggested by: (suggestion #)" With the patch you see the info of the suggester Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.04 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.04 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 20.05.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28881 Bug 28881 depends on bug 23376, which changed state. Bug 23376 Summary: Cleanup order receive page code https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.