[Bug 23670] New: Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 Bug ID: 23670 Summary: Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: nicolas.legrand@bulac.fr When your mapping includes an Invalid MARC field expression, it tries to throw an exception with Koha::Exceptions::Elasticsearch::MARCFieldExprParseError. But since Koha::Exceptions::Elasticsearch isn't loaded in Koha::SearchEngine::Elasticsearch, it dies like this: Can't locate Koha/Exceptions/Elasticsearch/MARCFieldExprParseError.pm in @INC (you may need to install the Koha::Exceptions::Elasticsearch::MARCFieldExprParseError module) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 --- Comment #1 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 93132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93132&action=edit Bug 23670 Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch Prevent Koha::SearchEngine::Elasticsearch from dying when trying to run Koha::Exceptions::Elasticsearch::MARCFieldExprParseError->throw() Plan test: 1. Go to Administration -> Searchengine configuration, and add a mapping for 995Z, whatever the search field (I did it with local-classification), save 2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 3. see it die asking for Koha::Exceptions::Elasticsearch 4. apply patch 5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 6. see it throw: Invalid MARC field expression: 995Z -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23671 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 [Bug 23671] Elasticsearch shouldn't throw exception on an uppercase subfield identifier -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93132|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 93361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93361&action=edit Bug 23670 Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch Prevent Koha::SearchEngine::Elasticsearch from dying when trying to run Koha::Exceptions::Elasticsearch::MARCFieldExprParseError->throw() Plan test: 1. Go to Administration -> Searchengine configuration, and add a mapping for 995Z, whatever the search field (I did it with local-classification), save 2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 3. see it die asking for Koha::Exceptions::Elasticsearch 4. apply patch 5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 6. see it throw: Invalid MARC field expression: 995Z Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |nicolas.legrand@bulac.fr |ity.org | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nicolas, please remember to add youself as Assignee on your bugs :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |nick@bywatersolutions.com CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93361|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93727&action=edit Bug 23670 Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch Prevent Koha::SearchEngine::Elasticsearch from dying when trying to run Koha::Exceptions::Elasticsearch::MARCFieldExprParseError->throw() Plan test: 1. Go to Administration -> Searchengine configuration, and add a mapping for 995Z, whatever the search field (I did it with local-classification), save 2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 3. see it die asking for Koha::Exceptions::Elasticsearch 4. apply patch 5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 6. see it throw: Invalid MARC field expression: 995Z Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org