[Bug 23671] New: Elasticsearch shouldn't throw exception on an uppercase subfield identifier
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 Bug ID: 23671 Summary: Elasticsearch shouldn't throw exception on an uppercase subfield identifier Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: nicolas.legrand@bulac.fr Depends on: 23670 MARC 21 specifies a subfield identifier “may be any any lowercase alphabetic or numeric character” (https://www.loc.gov/marc/96principl.html section 8.4.2). It is not that clear for Unimarc or even for ISO 2709 itself. Our catalogue in Unimarc use uppercase alphabetic subfield identifier for items. When we try to index it with Elasticsearch, it throws an exception (well, it tries to, this is fixed by Bug 23670). We think Elasticsearch shouldn't be picky about uppercase alphabetic subfield identifier, especially when Koha permits their creation in the MARC Framework or in the Elasticsearch mapping. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23670 [Bug 23670] Load Koha::Exceptions::ElasticSearch module in Koha::SearchEngine::Elasticsearch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 --- Comment #1 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 93133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93133&action=edit Bug 23671: Elasticsearch shouldn't throw exception on an uppercase subfield identifier Prevent Elasticsearch from throwing an exception when the mappings include uppercase subfield identifier. Though forbidden in MARC21, It doesn't seem to be the case for Unimarc or ISO 2709 as a whole. It is also possible to define such a subfield identifier in the Koha MARC Framework and in the Elasticsearch mappings. Test plan: 1. add a 995Z subfield identifier in Elasticsearch mappings (Administration -> Search engine configuration) 2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 3. see it throw: “Invalid MARC field expression: 995Z” 4. apply patch 5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 6. sababa -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93133|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 93365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93365&action=edit Bug 23671: Elasticsearch shouldn't throw exception on an uppercase subfield identifier Prevent Elasticsearch from throwing an exception when the mappings include uppercase subfield identifier. Though forbidden in MARC21, It doesn't seem to be the case for Unimarc or ISO 2709 as a whole. It is also possible to define such a subfield identifier in the Koha MARC Framework and in the Elasticsearch mappings. Test plan: 1. add a 995Z subfield identifier in Elasticsearch mappings (Administration -> Search engine configuration) 2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 3. see it throw: “Invalid MARC field expression: 995Z” 4. apply patch 5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 6. sababa Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nicolas.legrand@bulac.fr |ity.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |nick@bywatersolutions.com CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93365|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 93730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93730&action=edit Bug 23671: Elasticsearch shouldn't throw exception on an uppercase subfield identifier Prevent Elasticsearch from throwing an exception when the mappings include uppercase subfield identifier. Though forbidden in MARC21, It doesn't seem to be the case for Unimarc or ISO 2709 as a whole. It is also possible to define such a subfield identifier in the Koha MARC Framework and in the Elasticsearch mappings. Test plan: 1. add a 995Z subfield identifier in Elasticsearch mappings (Administration -> Search engine configuration) 2. run $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 3. see it throw: “Invalid MARC field expression: 995Z” 4. apply patch 5. rerun $KOHA_PATH/misc/search_tools/rebuild_elasticsearch.pl -v -d -b 6. sababa Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23671 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org