[Bug 25086] New: OPAC Self Registration - Field 'changed_fields' doesn't have a default value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Bug ID: 25086 Summary: OPAC Self Registration - Field 'changed_fields' doesn't have a default value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: OPAC Assignee: agustinmoyano@theke.io Reporter: agustinmoyano@theke.io QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@bugs.koha-community.org, tomascohen@gmail.com Depends on: 23579 In OPAC's self registration, if PatronSelfRegistrationVerifyByEmail is set to Require, OPAC dies with the following error DBD::mysql::st execute failed: Field 'changed_fields' doesn't have a default value [for Statement "INSERT INTO `borrower_modifications` ( `branchcode`, `categorycode`, `date_renewed`, `dateenrolled`, `dateexpiry`, `dateofbirth`, `debarred`, `email`, `firstname`, `gdpr_proc_consent`, `password`, `surname`, `timestamp`, `verification_token`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, current_timestamp, ? )" with ParamValues: 0="CPL", 1="S", 2=undef, 3=undef, 4=undef, 5=undef, 6=undef, 7="prueba2@algo.com", 8="algo", 9=undef, 10='E<rcyc6h<p', 11="prueba2", 12='aa165f462c22f414a2cd1081bace0921'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. Seems it's because changed_fields doesn't have a default value, and cannot be null. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23579 [Bug 23579] error during web install: 'changed_fields' can't have a default value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 --- Comment #1 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 102600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102600&action=edit Bug 25086: set changed_fields column if not defined This patch sets changed_fields column to '' if not defined To test: 1. Do not apply this patch 2. Set PatronSelfRegistrationVerifyByEmail preference to require 3. Fill self registration form in opac and submit CHECK => OPAC dies with a nasty message, that says Field 'changed_fields' doesn't have a default value 4. Apply this patch and restart_all 5. Repeat step 3 SUCCESS => Registry process continues as expected 6. Sign off Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Agustin, at first glance I'd say that the correct fix is to make the column nullable at DB level. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102600|0 |1 is obsolete| | --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 102893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102893&action=edit Bug 25086: set changed_fields column if not defined This patch sets changed_fields column to '' if not defined To test: 1. Do not apply this patch 2. Set PatronSelfRegistrationVerifyByEmail preference to require 3. Fill self registration form in opac and submit CHECK => OPAC dies with a nasty message, that says Field 'changed_fields' doesn't have a default value 4. Apply this patch and restart_all 5. Repeat step 3 SUCCESS => Registry process continues as expected 6. Sign off Sponsored-by: Orex Digital Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Needs Signoff |Signed Off --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Patch signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- However, the message of Joubu seems to mean that it doesn't pass QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102893|0 |1 is obsolete| | --- Comment #6 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 103024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103024&action=edit Bug 25086: set changed_fields column if not defined This patch sets changed_fields column to '' if not defined To test: 1. Do not apply this patch 2. Set PatronSelfRegistrationVerifyByEmail preference to require 3. Fill self registration form in opac and submit CHECK => OPAC dies with a nasty message, that says Field 'changed_fields' doesn't have a default value 4. Apply this patch and restart_all 5. Repeat step 3 SUCCESS => Registry process continues as expected 6. Sign off Sponsored-by: Orex Digital Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 --- Comment #7 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 103025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103025&action=edit Bug 25086: (follow-up) Set changed_fields column as nullable This patch reverts previous patch (left there because it was signed off), and sets changed_fields column as nullable. Attend only this test plan and not previous patch. To test: 1. Do not apply any patch 2. Set PatronSelfRegistrationVerifyByEmail preference to require 3. Fill self registration form in opac and submit CHECK => OPAC dies with a nasty message, that says Field 'changed_fields' doesn't have a default value 4. Apply this patch and updatedatabase 5. Repeat step 3 SUCCESS => Registry process continues as expected 6. Sign off Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103025|0 |1 is obsolete| | --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 103038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103038&action=edit Bug 25086: (follow-up) Set changed_fields column as nullable This patch reverts previous patch (left there because it was signed off), and sets changed_fields column as nullable. Attend only this test plan and not previous patch. To test: 1. Do not apply any patch 2. Set PatronSelfRegistrationVerifyByEmail preference to require 3. Fill self registration form in opac and submit CHECK => OPAC dies with a nasty message, that says Field 'changed_fields' doesn't have a default value 4. Apply this patch and updatedatabase 5. Repeat step 3 SUCCESS => Registry process continues as expected 6. Sign off Sponsored-by: Orex Digital Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works! 👌 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Something is wrong here error: sha1 information is lacking or useless (installer/data/mysql/atomicupdate/bug_25086.perl). error: could not build fake ancestor Patch failed at 0001 Bug 25086: (follow-up) Set changed_fields column as nullable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103024|0 |1 is obsolete| | --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 103093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103093&action=edit Bug 25086: set changed_fields column if not defined This patch sets changed_fields column to '' if not defined To test: 1. Do not apply this patch 2. Set PatronSelfRegistrationVerifyByEmail preference to require 3. Fill self registration form in opac and submit CHECK => OPAC dies with a nasty message, that says Field 'changed_fields' doesn't have a default value 4. Apply this patch and restart_all 5. Repeat step 3 SUCCESS => Registry process continues as expected 6. Sign off Sponsored-by: Orex Digital Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103038|0 |1 is obsolete| | --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 103094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103094&action=edit Bug 25086: (follow-up) Set changed_fields column as nullable This patch reverts previous patch (left there because it was signed off), and sets changed_fields column as nullable. Attend only this test plan and not previous patch. To test: 1. Do not apply any patch 2. Set PatronSelfRegistrationVerifyByEmail preference to require 3. Fill self registration form in opac and submit CHECK => OPAC dies with a nasty message, that says Field 'changed_fields' doesn't have a default value 4. Apply this patch and updatedatabase 5. Repeat step 3 SUCCESS => Registry process continues as expected 6. Sign off Sponsored-by: Orex Digital Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- /me forgot to attach the second patch. Fixed, sorry for hassle. SelfRegistration retested again just in case. Nothing suspicious found. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103093|0 |1 is obsolete| | Attachment #103094|0 |1 is obsolete| | --- Comment #14 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 103095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103095&action=edit Bug 25086: set changed_fields column if not defined This patch sets changed_fields column to '' if not defined To test: 1. Do not apply this patch 2. Set PatronSelfRegistrationVerifyByEmail preference to require 3. Fill self registration form in opac and submit CHECK => OPAC dies with a nasty message, that says Field 'changed_fields' doesn't have a default value 4. Apply this patch and restart_all 5. Repeat step 3 SUCCESS => Registry process continues as expected 6. Sign off Sponsored-by: Orex Digital Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 --- Comment #15 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 103096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103096&action=edit Bug 25086: (follow-up) Set changed_fields column as nullable This patch reverts previous patch (left there because it was signed off), and sets changed_fields column as nullable. Attend only this test plan and not previous patch. To test: 1. Do not apply any patch 2. Set PatronSelfRegistrationVerifyByEmail preference to require 3. Fill self registration form in opac and submit CHECK => OPAC dies with a nasty message, that says Field 'changed_fields' doesn't have a default value 4. Apply this patch and updatedatabase 5. Repeat step 3 SUCCESS => Registry process continues as expected 6. Sign off Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 --- Comment #16 from Agustín Moyano <agustinmoyano@theke.io> --- (In reply to Jonathan Druart from comment #10)
Something is wrong here
error: sha1 information is lacking or useless (installer/data/mysql/atomicupdate/bug_25086.perl). error: could not build fake ancestor Patch failed at 0001 Bug 25086: (follow-up) Set changed_fields column as nullable
You were right.. somehow I messed up my rebase and replaced original signed off commit with another. I just put things in order. Please try again. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23816 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23816 [Bug 23816] Allow to have different password strength and length settings for different patron categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Wait I'm sure I was the one who messed up. Because my command history shows that I only attached the last patch when we must reattach all patches each time. (IIUC) And because to do the signoff I was able to apply the 2 patches without issue. It was only after my signoff that Joubu wasn't able to apply the 2 patches. I'm rechecking what you just submitted Agustín. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103095|0 |1 is obsolete| | --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 103097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103097&action=edit Bug 25086: set changed_fields column if not defined This patch sets changed_fields column to '' if not defined To test: 1. Do not apply this patch 2. Set PatronSelfRegistrationVerifyByEmail preference to require 3. Fill self registration form in opac and submit CHECK => OPAC dies with a nasty message, that says Field 'changed_fields' doesn't have a default value 4. Apply this patch and restart_all 5. Repeat step 3 SUCCESS => Registry process continues as expected 6. Sign off Sponsored-by: Orex Digital Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103096|0 |1 is obsolete| | --- Comment #19 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 103098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103098&action=edit Bug 25086: (follow-up) Set changed_fields column as nullable This patch reverts previous patch (left there because it was signed off), and sets changed_fields column as nullable. Attend only this test plan and not previous patch. To test: 1. Do not apply any patch 2. Set PatronSelfRegistrationVerifyByEmail preference to require 3. Fill self registration form in opac and submit CHECK => OPAC dies with a nasty message, that says Field 'changed_fields' doesn't have a default value 4. Apply this patch and updatedatabase 5. Repeat step 3 SUCCESS => Registry process continues as expected 6. Sign off Sponsored-by: Orex Digital Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Working as expected. Agustín: I don't think that two patches are needed. From what I understand, if you change your strategy, you don't need a commit revert the V1. Nothing is released. So just discard or amend your commit and reattach it to the ticket. In the current state, I think you can just squash the two commits. And keep the commit message of the 2nd commit, without the part saying that it reverts the 1st one. That's my current understanding. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103097|0 |1 is obsolete| | Attachment #103098|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 103115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103115&action=edit Bug 25086: Set changed_fields column as nullable This patch changed_fields column as nullable. To test: 1. Do not apply any patch 2. Set PatronSelfRegistrationVerifyByEmail preference to require 3. Fill self registration form in opac and submit CHECK => OPAC dies with a nasty message, that says Field 'changed_fields' doesn't have a default value 4. Apply this patch and updatedatabase 5. Repeat step 3 SUCCESS => Registry process continues as expected 6. Sign off Sponsored-by: Orex Digital Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Victor Grousset/tuxayo from comment #20)
Working as expected.
Agustín: I don't think that two patches are needed. From what I understand, if you change your strategy, you don't need a commit revert the V1. Nothing is released. So just discard or amend your commit and reattach it to the ticket.
In the current state, I think you can just squash the two commits. And keep the commit message of the 2nd commit, without the part saying that it reverts the 1st one.
That's my current understanding.
Agreed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25086 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com Version(s)|20.05.00 |20.05.00, 19.11.06 released in| | Status|Pushed to master |Pushed to stable --- Comment #24 from Joy Nelson <joy@bywatersolutions.com> --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org