[Bug 25011] New: Add display of Production credits (MARC21 508) to staff detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 Bug ID: 25011 Summary: Add display of Production credits (MARC21 508) to staff detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 13385 Bug 13385 added 508 to the OPAC XSLT detail page, but missed staff. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13385 [Bug 13385] RDA: 508 display in XSLT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102022&action=edit Bug 25011: Add MARC21 508 - Production credits to staff detail page Bug 13385 added 508 to the OPAC detail page, but missed the staff side. This patch makes the display consistent again between staff and OPAC. Additional changes: - Capitalization fix: Production Credits - Production credits - Changes div to span avoiding display issues To test: - Catalog one or more records with none, one and multiple 508 $a - Check and compare the staff and OPAC detail pages, both should display the production credits information now correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add display of Production |Improve display of |credits (MARC21 508) to |Production credits (MARC21 |staff detail page |508) in OPAC and staff --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Someone must have already fixed staff side since I put this on my todo list (ages ago). Fixing my patch :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102024&action=edit Bug 25011: Improve display of MARC21 508 - Production credits in staff and OPAC Makes some tiny changes to improve display and consistency between OPAC and staff: - Capitalization fix: Production Credits - Production credits - Changes div to span avoiding display issues - Make sequence of fields in display match (505, 508, 586) To test: - Catalog one or more records with none, one and multiple 508 $a - Check and compare the staff and OPAC detail pages, both should display the production credits information correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Hi Katrin. In the staff interface 508 is already included, so when the patch is applied it displays twice (around line 1026 in the patch file, after the 586 field). The patch does fix the display of 508 in the OPAC. One thing I noticed is that the 'Contents' heading for 505 displays in the OPAC, but doesn't in the staff interface (this is the case before and after the patch is applied). David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102022|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, sorry, I had realized my mistake but missed to obsolete the first patch. The patch attached now should be ok. Please file a bug for 505 - happy to have a look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102024|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 102059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102059&action=edit Bug 25011: Improve display of MARC21 508 - Production credits in staff and OPAC Makes some tiny changes to improve display and consistency between OPAC and staff: - Capitalization fix: Production Credits - Production credits - Changes div to span avoiding display issues - Make sequence of fields in display match (505, 508, 586) To test: - Catalog one or more records with none, one and multiple 508 $a - Check and compare the staff and OPAC detail pages, both should display the production credits information correctly Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #5)
Hi David, sorry, I had realized my mistake but missed to obsolete the first patch. The patch attached now should be ok. Please file a bug for 505 - happy to have a look.
No problem! The contents is now displaying correctly in the staff interface, so I'll pu that down to me! David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102059|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 103119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103119&action=edit Bug 25011: Improve display of MARC21 508 - Production credits in staff and OPAC Makes some tiny changes to improve display and consistency between OPAC and staff: - Capitalization fix: Production Credits - Production credits - Changes div to span avoiding display issues - Make sequence of fields in display match (505, 508, 586) To test: - Catalog one or more records with none, one and multiple 508 $a - Check and compare the staff and OPAC detail pages, both should display the production credits information correctly Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This change makes some tiny release notes| |changes to improve the | |display and consistency | |between the OPAC and staff | |interface: | |- | |Capitalization: Production | |Credits --> Production | |credits. | |- Change div to | |span to avoid display | |issues. | |- Make sequence of | |fields in display match | |(505, 508, 586). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25011 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #10 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org