[Bug 39997] New: List of closed serials: reopening requires the syspref "RoutingSerials"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39997 Bug ID: 39997 Summary: List of closed serials: reopening requires the syspref "RoutingSerials" Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org On the list of closed serials, the action "reopen" is not displayed unless you have the syspref "RoutingSerials" active.
From koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt
139 [% IF ( routing && CAN_user_serials_routing ) %] 140 [% UNLESS ( subscription.cannotedit ) %] 141 142 <a 143 class="dropdown-item" 144 href="/cgi-bin/koha/serials/serials-search.pl?subscriptionid=[% subscription.subscriptionid | uri %]& ;op=reopen&routing=[% subscription.routing | uri %]&searched=1&title_filter=[% title_filter | uri %]&ISSN_filter=[% ISSN_filter | uri %]&EAN_fil ter=[% EAN_filter | uri %]&published_filter=[% publisher_filter | uri %]&bookseller_filter=[% bookseller_filter | uri %]&branch_filter=[% branch_filter | uri %]" 145 id="reopensub" 146 > 147 <i class="fa-solid fa-arrow-rotate-right"> Reopen</a 148 > 149 150 [% END %] 151 [% END # IF ( routing && CAN_user_serials_routing ) %] I have no clue why there is a restriction on routing and CAN_user_serials_routing. It breaks the ability to reopen serial from the list of closed serials if routing is not activated. To reproduce: 1 - Create a closed serial 2 - Disable the syspref "RoutingSerials" 3 - Go to cgi-bin/koha/serials/serials-search.pl and search for the closed serial ; click on the "closed" panel of the result -> on the actions button, there is no option to reopen 4 - Apply patch 5 - Repeat 3, there is now an option to reopen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39997 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39997 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39997 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 182783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182783&action=edit Bug 39997: List of closed serials: reopening shouldn't require the syspref RoutingSerials Test plan: 1 - Create a closed serial 2 - Disable the syspref "RoutingSerials" 3 - Go to cgi-bin/koha/serials/serials-search.pl and search for the closed serial ; click on the "closed" panel of the result -> on the actions button, there is no option to reopen 4 - Apply patch 5 - Repeat 3, there is now an option to reopen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39997 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39997 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182783|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182800&action=edit Bug 39997: List of closed serials: reopening shouldn't require the syspref RoutingSerials Test plan: 1 - Create a closed serial 2 - Disable the syspref "RoutingSerials" 3 - Go to cgi-bin/koha/serials/serials-search.pl and search for the closed serial ; click on the "closed" panel of the result -> on the actions button, there is no option to reopen 4 - Apply patch 5 - Repeat 3, there is now an option to reopen. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39997 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39997 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182800|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184281&action=edit Bug 39997: List of closed serials: reopening shouldn't require the syspref RoutingSerials Test plan: 1 - Create a closed serial 2 - Disable the syspref "RoutingSerials" 3 - Go to cgi-bin/koha/serials/serials-search.pl and search for the closed serial ; click on the "closed" panel of the result -> on the actions button, there is no option to reopen 4 - Apply patch 5 - Repeat 3, there is now an option to reopen. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39997 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39997 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39997 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39997 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39997 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39997 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.02 |25.11.00,25.05.02,24.11.08 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39997 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org