[Bug 39072] New: 24.11 - Item Search Shareable Link Adding Selections for Similar LOC Auth Values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Bug ID: 39072 Summary: 24.11 - Item Search Shareable Link Adding Selections for Similar LOC Auth Values Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: heather@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When executing an Item Search and copying the shareable link, the Item Search results for the shared link differ from the original results. Specifically, if a LOC authorized value is similar to another authorized value (ex: ADULT with description Adult and ADULTG with description Adult - Grab and Go), if an Item Search is executed for the ADULTG LOC, the shareable link somehow includes the ADULT LOC, causing the results to differ radically from the initial search. To Test: - Create LOC authorized values of ADULT with description "Adult" and ADULTG with description "Adult - Grab and Go" - Create an Item Search using the ADULTG LOC value - Click Copy shareable link and paste/go in new tab - See that the results of the copied link's Item Search differ widely from the original results - Click Edit search button and notice that the LOC authorized value of ADULT was added to the selected criteria for the search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 --- Comment #1 from Heather Rommens <heather@bywatersolutions.com> --- Adding a comment to mention that this issue appears to be very similar to the bug reported in Comment 18 on Bug 14322 - Add option to create a shareable link for item searches. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Depends on| |14322 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14322 [Bug 14322] Add option to create a shareable link for item searches -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m Assignee|koha-bugs@lists.koha-commun |lisette@bywatersolutions.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|24.11 - Item Search |Item search shareable link |Shareable Link Adding |adding selections for |Selections for Similar LOC |aimilar LOC auth values |Auth Values | Version|24.11 |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com Summary|Item search shareable link |Item search shareable link |adding selections for |adding selections for |aimilar LOC auth values |similar LOC auth values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Sarah Cornell <sbcornell@cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell@cityofportsmouth. | |com --- Comment #2 from Sarah Cornell <sbcornell@cityofportsmouth.com> --- We're having the same problem with this feature. The link to a search for for PYBWF will return items with PYBWF and those with location PY. The link to a search for PYMG will return items with location codes PYMG, PYM, and PY. All of our location codes are built on this structure so the link feature won't be useful to us until the search is exact. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 --- Comment #3 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185393&action=edit Bug 39072: Only select exact matches when populating search terms This patch simply reduces our matching pattern to ensure the string is an exact match, rather than partial To test: - Create LOC authorized values of ADULT with description "Adult" and ADULTG with description "Adult - Grab and Go" - Find a record with items and set one item to shelving location "Adult" - Find a second record with items and set one item to shelving location "Adult - Grab and Go" - Create an Item Search for Shelving location and select 'Adult' only - Search and get one result from the record selected above - Click Copy shareable link and paste/go in new tab - See that the results now include both records from above - Click Edit search button and notice that the Shelving location 'Adult - Grab and Go' was added to the selected criteria for the search - Apply patch - Repeat original search for 'Adult' location - Click 'Copy shareable link' - Open in new tab and confirm correct results - Repeat with a search for 'Adult - Grab and Go' and confirm shareable link gets the correct results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40651 CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lisette@bywatersolutions.co |nick@bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #4 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I tested this in a several sandboxes but I could not replicate the original problem. The shared link worked correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185393|0 |1 is obsolete| | --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 185599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185599&action=edit Bug 39072: Only select exact matches when populating search terms This patch simply reduces our matching pattern to ensure the string is an exact match, rather than partial To test: - Create LOC authorized values of ADULT with description "Adult" and ADULTG with description "Adult - Grab and Go" - Find a record with items and set one item to shelving location "Adult" - Find a second record with items and set one item to shelving location "Adult - Grab and Go" - Create an Item Search for Shelving location and select 'Adult' only - Search and get one result from the record selected above - Click Copy shareable link and paste/go in new tab - See that the results now include both records from above - Click Edit search button and notice that the Shelving location 'Adult - Grab and Go' was added to the selected criteria for the search - Apply patch - Repeat original search for 'Adult' location - Click 'Copy shareable link' - Open in new tab and confirm correct results - Repeat with a search for 'Adult - Grab and Go' and confirm shareable link gets the correct results Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- This works and makes sense that the grep function should have a regular expression with an exact matching start and end. When testing I found that the test plan was slightly off, so it could be confusing to replicate. Copying the link for the Adult grab and go link and pasting it actually returns the results for selecting both Adult and Adult grab and go. To test: Create LOC authorized values of ADULT with description "Adult" and ADULTG with description "Adult - Grab and Go" - Find a record with items and set one item to shelving location "Adult" - Find a second record with items and set one item to shelving location "Adult - Grab and Go" *This step should be for Adult grab and go: - Create an Item Search for Shelving location and select 'Adult grab and go' only - Search and get one result from the record selected above - Click Copy shareable link and paste/go in new tab - See that the results now include both records from above *This step you should see the Adult shelving location was added when it shouldn't be: - Click Edit search button and notice that the Shelving location 'Adult' was added to the selected criteria for the search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- It's counterintuitive that the param that's longer actually selects the option that's shorter, but what's happening is it takes the url query param value for location, ADULTG and greps for the values of the options, so both option values ADULT and ADULTG match. That's why it's selecting both options when you paste the link for the longer param ADULTG. I would be happy to switch my sign off to QA if someone else signs off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185599|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 185876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185876&action=edit Bug 39072: Only select exact matches when populating search terms This patch simply reduces our matching pattern to ensure the string is an exact match, rather than partial To test: - Create LOC authorized values of ADULT with description "Adult" and ADULTG with description "Adult - Grab and Go" - Find a record with items and set one item to shelving location "Adult" - Find a second record with items and set one item to shelving location "Adult - Grab and Go" - Create an Item Search for Shelving location and select 'Adult' only - Search and get one result from the record selected above - Click Copy shareable link and paste/go in new tab - See that the results now include both records from above - Click Edit search button and notice that the Shelving location 'Adult - Grab and Go' was added to the selected criteria for the search - Apply patch - Repeat original search for 'Adult' location - Click 'Copy shareable link' - Open in new tab and confirm correct results - Repeat with a search for 'Adult - Grab and Go' and confirm shareable link gets the correct results Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.04 |25.11.00,25.05.04,24.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39072 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org