[Bug 10081] New: HomeOrHoldingBranch error missing a library name
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Bug ID: 10081 Summary: HomeOrHoldingBranch error missing a library name Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All URL: /cgi-bin/koha/circ/circulation.pl OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 17557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17557&action=edit error See attached. When you have HomeOrHoldingBranch set to home library you get an error when you try to check the item out at another branch - this is good, but the error is missing a library name I think cause it's not a sentence: "This item belongs to and cannot be issued from this location." I think it should be : "This item belongs to HOMEBRANCH and cannot be issued from this location." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Version|3.10 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Summary|HomeOrHoldingBranch error |IndependentBranches error |missing a library name |message missing the library | |name --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I can't tell what HomeOrHoldingBranch has to do with this bug. I can only trigger the error if IndependentBranches is on and I'm checking out an item from another branch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20321&action=edit Bug 10081 - IndependentBranches error message missing the library name With IndependentBranches turned on, if you try to check out an item which belongs to another library you will get an error message which is missing the library name. This patch corrects the problem by passing the necessary variable to the template and outputting the library name using the KohaBranchName TT plugin. To test, turn on IndependentBranches and try to check out an item belonging to another library (note that you must test with a staff user who is not a superlibrarian). The error message you see should include the name of the library to which the item belongs: "This item belongs to Nelsonville and cannot be checked out from this location." Checkouts of items belonging to the library should be unaffected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20321|0 |1 is obsolete| | --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 20331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20331&action=edit Bug 10081: add library name to IndependentBranches error message With IndependentBranches turned on, if you try to check out an item which belongs to another library you will get an error message which is missing the library name. This patch corrects the problem by passing the necessary variable to the template and outputting the library name using the KohaBranchName TT plugin. To test, turn on IndependentBranches and try to check out an item belonging to another library (note that you must test with a staff user who is not a superlibrarian). The error message you see should include the name of the library to which the item belongs: "This item belongs to Nelsonville and cannot be checked out from this location." Checkouts of items belonging to the library should be unaffected. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20331|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20504&action=edit Bug 10081: add library name to IndependentBranches error message With IndependentBranches turned on, if you try to check out an item which belongs to another library you will get an error message which is missing the library name. This patch corrects the problem by passing the necessary variable to the template and outputting the library name using the KohaBranchName TT plugin. To test, turn on IndependentBranches and try to check out an item belonging to another library (note that you must test with a staff user who is not a superlibrarian). The error message you see should include the name of the library to which the item belongs: "This item belongs to Nelsonville and cannot be checked out from this location." Checkouts of items belonging to the library should be unaffected. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10081 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org