[Bug 10701] New: In transit information doesn't display on the bibliographic detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 Bug ID: 10701 Summary: In transit information doesn't display on the bibliographic detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org My patch for Bug 10083 may have made the in-transit strings translatable, but it messed up the template variable names so that the details don't show. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20191&action=edit Bug 10701 - In transit information doesn't display on the bibliographic detail page The patch for Bug 10083 incorrectly changed some template variable names so that in-transit details could not be shown on the biblio detail page. This patch corrects the error. To test, perform any action that will trigger an transfer between libraries (for instance, check in an item from Library A at Library B). View the detail page for that title and look for the transfer details in the status column of the holdings table. It should show correct information: "In transit from Athens to Nelsonville since 08/08/2013" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20191|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 20194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20194&action=edit Bug 10701 - In transit information doesn't display on the bibliographic detail page The patch for Bug 10083 incorrectly changed some template variable names so that in-transit details could not be shown on the biblio detail page. This patch corrects the error. To test, perform any action that will trigger an transfer between libraries (for instance, check in an item from Library A at Library B). View the detail page for that title and look for the transfer details in the status column of the holdings table. It should show correct information: "In transit from Athens to Nelsonville since 08/08/2013" Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described, no errors. Before patch incorrect information: "In transit from to since" after patch correct information. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20194|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20434&action=edit [PASSED QA] Bug 10701 - In transit information doesn't display on the bibliographic detail page The patch for Bug 10083 incorrectly changed some template variable names so that in-transit details could not be shown on the biblio detail page. This patch corrects the error. To test, perform any action that will trigger an transfer between libraries (for instance, check in an item from Library A at Library B). View the detail page for that title and look for the transfer details in the status column of the holdings table. It should show correct information: "In transit from Athens to Nelsonville since 08/08/2013" Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described, no errors. Before patch incorrect information: "In transit from to since" after patch correct information. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works perfectly and passes all tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.5. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10701 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Does not apply cleanly to 3.10.x, please submit one formatted for 3.10.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org