[Bug 30613] New: Hide RSS feed link when viewing private list in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30613 Bug ID: 30613 Summary: Hide RSS feed link when viewing private list in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Koha requires that you be logged in to the OPAC in order to view a private list. This is true from the RSS view of a private list as well. We don't provide an alternative authentication method to enable access by RSS readers. Unless and until someone develops a means to provide RSS access to private lists it is logical to hide the RSS icon when viewing a private list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30613 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30613 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30613 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134641&action=edit Bug 30613: Hide RSS feed link when viewing private list in the OPAC This patch wraps the List RSS icon in a check on whether the list is public. Private lists RSS can only be accessed by a logged-in patron. To test apply the patch and view a public list in the OPAC. You should see an RSS link icon next to the list title. Now log in to the OPAC and view a private list. There should be no RSS link. Note the QA tool warning about the aria-hidden attribute is a false positive. The parent element has a label. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30613 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30613 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134641|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 134664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134664&action=edit Bug 30613: Hide RSS feed link when viewing private list in the OPAC This patch wraps the List RSS icon in a check on whether the list is public. Private lists RSS can only be accessed by a logged-in patron. To test apply the patch and view a public list in the OPAC. You should see an RSS link icon next to the list title. Now log in to the OPAC and view a private list. There should be no RSS link. Note the QA tool warning about the aria-hidden attribute is a false positive. The parent element has a label. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30613 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Working on this one :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30613 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30613 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134664|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134677&action=edit Bug 30613: Hide RSS feed link when viewing private list in the OPAC This patch wraps the List RSS icon in a check on whether the list is public. Private lists RSS can only be accessed by a logged-in patron. To test apply the patch and view a public list in the OPAC. You should see an RSS link icon next to the list title. Now log in to the OPAC and view a private list. There should be no RSS link. Note the QA tool warning about the aria-hidden attribute is a false positive. The parent element has a label. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30613 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30613 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org