[Bug 30688] New: Error in path to CSS background image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30688 Bug ID: 30688 Summary: Error in path to CSS background image Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org On the OPAC detail page, when any kind of cover image preference is enabled, the cover image container has a "spinner" background image which displays until the cover image has loaded. The path in the CSS file for this image is incorrect so the image doesn't load. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30688 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30688 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134634&action=edit Bug 30688: Error in path to CSS background image This patch corrects the path of an image specified as the background to a couple of elements in the OPAC. The incorrect path was causing 404 errors. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - If necessary, activate one or more cover image services in Administration, e.g. OPACAmazonCoverImages, OPACLocalCoverImages, and/or OpenLibraryCovers. - In the OPAC, locate a bibliographic record which has a cover image from one or more of the services you activated. - On the detail page for that record, the cover should load correctly. - In the browser console you should see no errors related to a file not found: /opac-tmpl/bootstrap/img/spinner-small.gif - In the browser console, submit this JavaScript snippet: $(".cover-image").remove(); The cover image should disappear, revealing the "spinner" icon behind it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30688 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30688 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134634|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 134656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134656&action=edit Bug 30688: Error in path to CSS background image This patch corrects the path of an image specified as the background to a couple of elements in the OPAC. The incorrect path was causing 404 errors. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - If necessary, activate one or more cover image services in Administration, e.g. OPACAmazonCoverImages, OPACLocalCoverImages, and/or OpenLibraryCovers. - In the OPAC, locate a bibliographic record which has a cover image from one or more of the services you activated. - On the detail page for that record, the cover should load correctly. - In the browser console you should see no errors related to a file not found: /opac-tmpl/bootstrap/img/spinner-small.gif - In the browser console, submit this JavaScript snippet: $(".cover-image").remove(); The cover image should disappear, revealing the "spinner" icon behind it. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134656|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 134678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134678&action=edit Bug 30688: Error in path to CSS background image This patch corrects the path of an image specified as the background to a couple of elements in the OPAC. The incorrect path was causing 404 errors. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - If necessary, activate one or more cover image services in Administration, e.g. OPACAmazonCoverImages, OPACLocalCoverImages, and/or OpenLibraryCovers. - In the OPAC, locate a bibliographic record which has a cover image from one or more of the services you activated. - On the detail page for that record, the cover should load correctly. - In the browser console you should see no errors related to a file not found: /opac-tmpl/bootstrap/img/spinner-small.gif - In the browser console, submit this JavaScript snippet: $(".cover-image").remove(); The cover image should disappear, revealing the "spinner" icon behind it. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30688 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30688 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org