[Bug 38373] New: Mandatory patron relationship has to be selected twice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Bug ID: 38373 Summary: Mandatory patron relationship has to be selected twice Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: johanna.raisa@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When relationship is a mandatory the field has to be selected twice, for non-patron guarantor and patron guarantor. There should be a some kind of check which input fields are filled and the relationship requirement is based on that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |johanna.raisa@koha-suomi.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 --- Comment #1 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 174102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174102&action=edit Bug 38373: check if mandatory relationship is needed for non-patron guarantor This patch checks if non-patron guarantor is added to the patron and changes the relationship to mandatory if needed. Test plan: 1) Add relationship as mandatory field 2) Add a child patron 3) See that the non-patron guarantor relationship is mandatory 4) Apply the patch 5) Add a child patron 6) See that the non-patron guarantor relationship is not mandatory 7) Fill a surname for the non-patron guarantor 8) See that the non-patron guarantor relationship turns mandatory Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Why not applying the same trigger for #contactfirstname? I'd say if at least one of them (#contactname or #contactfirstname) is not empty then the relationship must be required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- (In reply to Jonathan Druart from comment #2)
Why not applying the same trigger for #contactfirstname?
I'd say if at least one of them (#contactname or #contactfirstname) is not empty then the relationship must be required.
Yes, should be check that also. I fill fix that and add a patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174102|0 |1 is obsolete| | --- Comment #4 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 174118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174118&action=edit Bug 38373: check if mandatory relationship is needed for non-patron guarantor This patch checks if non-patron guarantor is added to the patron and changes the relationship to mandatory if needed. Test plan: 1) Add relationship as mandatory field 2) Add a child patron 3) See that the non-patron guarantor relationship is mandatory 4) Apply the patch 5) Add a child patron 6) See that the non-patron guarantor relationship is not mandatory 7) Fill surname or first name for the non-patron guarantor 8) See that the non-patron guarantor relationship turns mandatory Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #5 from Jesse Maseto <jesse@bywatersolutions.com> --- Patch does not apply. Merge conflicts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174118|0 |1 is obsolete| | --- Comment #6 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- Created attachment 181000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181000&action=edit Bug 38373: check if mandatory relationship is needed for non-patron guarantor This patch checks if non-patron guarantor is added to the patron and changes the relationship to mandatory if needed. Test plan: 1) Add relationship as mandatory field 2) Add a child patron 3) See that the non-patron guarantor relationship is mandatory 4) Apply the patch 5) Add a child patron 6) See that the non-patron guarantor relationship is not mandatory 7) Fill surname or first name for the non-patron guarantor 8) See that the non-patron guarantor relationship turns mandatory Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Lin Wei <lin-wei.li@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |lin-wei.li@inLibro.com --- Comment #7 from Lin Wei <lin-wei.li@inLibro.com> --- # Results before Applying Patch - Added "Relationship" to "BorrowerMandatoryField" in "Koha administration." - When trying to Add patron (kid), Non-patron guarantor > Relationship is "Required." # Results after Applying Patch - When trying to Add patron (kid), Non-patron guarantor > Relationship remains "Required." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Johanna Räisä <johanna.raisa@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Johanna Räisä <johanna.raisa@koha-suomi.fi> --- (In reply to Lin Wei from comment #7)
# Results before Applying Patch
- Added "Relationship" to "BorrowerMandatoryField" in "Koha administration." - When trying to Add patron (kid), Non-patron guarantor > Relationship is "Required."
# Results after Applying Patch
- When trying to Add patron (kid), Non-patron guarantor > Relationship remains "Required."
I tested this again with current main and to me it seems to be working as in test plan. The relationship field on non-patron guarantor should change to required when you fill surname or first name for non-patron guarantor, steps 7 and 8. You probably need to load the page with ctrl+f5, so the browser cache resets. Can you test again, please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 182779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182779&action=edit Bug 38373: Check if mandatory relationship is needed for non-patron guarantor This patch makes the non-guarantor relationship field mandatory only if a guarantor surname or first name is entered. Currently, if the relationship field is mandatory, you need to select a value even if there is no guarantor surname or first name. Test plan: 1) Add relationship as mandatory field 2) Add a child patron 3) See that the non-patron guarantor relationship is mandatory (note that it is mandtaory, even if there is no guarantor surname or first name) 4) Apply the patch 5) Add a child patron 6) See that the non-patron guarantor relationship is not mandatory 7) Fill surname or first name for the non-patron guarantor 8) See that the non-patron guarantor relationship turns mandatory Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes adding a release notes| |non-patron guarantor for a | |patron - the relationship | |field is only marked as | |mandatory if a guarantor | |surname or first name is | |entered (where the | |relationship field is | |marked as mandatory in the | |BorrowerMandatoryField | |system preference). | | | |Previously, the | |relationship field was | |marked as mandatory even if | |no guarantor surname or | |first name was entered. Summary|Mandatory patron |Mandatory non-patron |relationship has to be |guarantor relationship |selected twice |required where no guarantor | |surname or first name CC| |david@davidnind.com --- Comment #10 from David Nind <david@davidnind.com> --- I've changed the bug title, as I didn't understand this part of the description of the issue, and I found this confusing when trying to work out what the problem was: "...has to be selected twice". I think how it works after the patch is better, and is consistent with the patron guarantor. Testing notes (using KTD): 1. Before the patch, what I did (thanks Lin Wei): 1.1 For the BorrowerMandatoryField system preference, I added "Relationship" as a mandatory field. 1.2 When adding a Kid patron, under non-patron guarantor, the relationship field is marked as "Required" in red. 1.3 This works as expected for me: - don't add a patron guarantor surname or first name - if a value is not selected, the new patron isn't saved and the relationship has "This field is required." beside it OR - select a value from the dropdown list (note that the field is requieed even if you don't have a guarantor surname or first name) 2. After the patch, under non-patron guarantor, the relationship field is NOT marked as "Required" in red until a guarantor surname or first name is added. (This is now similar to the patron guarantor - until you select a patron as a guarantor, have the relationship field completed is not mandatory. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181000|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- [FAIL] koha-tmpl/intranet-tmpl/prog/js/members.js FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/js/members.js` -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org