https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38373 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes adding a release notes| |non-patron guarantor for a | |patron - the relationship | |field is only marked as | |mandatory if a guarantor | |surname or first name is | |entered (where the | |relationship field is | |marked as mandatory in the | |BorrowerMandatoryField | |system preference). | | | |Previously, the | |relationship field was | |marked as mandatory even if | |no guarantor surname or | |first name was entered. Summary|Mandatory patron |Mandatory non-patron |relationship has to be |guarantor relationship |selected twice |required where no guarantor | |surname or first name CC| |david@davidnind.com --- Comment #10 from David Nind <david@davidnind.com> --- I've changed the bug title, as I didn't understand this part of the description of the issue, and I found this confusing when trying to work out what the problem was: "...has to be selected twice". I think how it works after the patch is better, and is consistent with the patron guarantor. Testing notes (using KTD): 1. Before the patch, what I did (thanks Lin Wei): 1.1 For the BorrowerMandatoryField system preference, I added "Relationship" as a mandatory field. 1.2 When adding a Kid patron, under non-patron guarantor, the relationship field is marked as "Required" in red. 1.3 This works as expected for me: - don't add a patron guarantor surname or first name - if a value is not selected, the new patron isn't saved and the relationship has "This field is required." beside it OR - select a value from the dropdown list (note that the field is requieed even if you don't have a guarantor surname or first name) 2. After the patch, under non-patron guarantor, the relationship field is NOT marked as "Required" in red until a guarantor surname or first name is added. (This is now similar to the patron guarantor - until you select a patron as a guarantor, have the relationship field completed is not mandatory. -- You are receiving this mail because: You are watching all bug changes.