[Bug 11008] New: Useless column supplierreference in aqorders table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Bug ID: 11008 Summary: Useless column supplierreference in aqorders table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt@gmail.com Reporter: mathieu.saby@univ-rennes2.fr QA Contact: testopia@bugs.koha-community.org In Schemaspy, column supplierreference is reported as "not used? always NULL". "grep -r supplierreference *" give this result, so I suppose it is true : blib/INTRANET_CGI_DIR/installer/data/mysql/update22to30.pl: field => 'supplierreference', blib/INTRANET_CGI_DIR/installer/data/mysql/kohastructure.sql: `supplierreference` mediumtext, -- not used? always NULL blib/INTRANET_CGI_DIR/installer/data/Pg/kohastructure.sql:supplierreference text, installer/data/mysql/update22to30.pl: field => 'supplierreference', installer/data/mysql/kohastructure.sql: `supplierreference` mediumtext, -- not used? always NULL installer/data/Pg/kohastructure.sql:supplierreference text, t/db_dependent/Acquisition.t: supplierreference I propose the deletion of this column. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11007 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29822&action=edit Bug 11008: Drop column aqorders.supplierreference It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep supplierreference should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 --- Comment #2 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 33987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33987&action=edit [SIGNED-OFF] Bug 11008: Drop column aqorders.supplierreference It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep supplierreference should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29822|0 |1 is obsolete| | Attachment #33987|0 |1 is obsolete| | --- Comment #3 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 33988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33988&action=edit [SIGNED-OFF] Bug 11008: Drop column aqorders.supplierreference It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep supplierreference should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33988|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34161&action=edit [PASSED QA] Bug 11008: Drop column aqorders.supplierreference It seems that this column has never been used. Test plan: 1/ Execute the updatedatabase entry. 2/ git grep supplierreference should not return occurrence in the code (except in Koha/Schema/* 3/ prove t/db_dependent/Acquisition.t should return green. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 37738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37738&action=edit Bug 11008: (RM followup) DBIx schema update Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11008 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Useless column |Remove unused column |supplierreference in |supplierreference in |aqorders table |aqorders table CC| |katrin.fischer@bsz-bw.de Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org